Code Review for tddep

Prepared by:William Schumann <william.schumann@sun.com> on Wed May 28 15:38:41 MDT 2008
Workspace:/net/install-bldx-11.sfbay/export/home/william/tddep (at 58f34690ad40)
Compare against: ssh://wmsch@hg.opensolaris.org/hg/caiman/slim_source (at 58f34690ad40)
Summary of changes: 376 lines changed: 226 ins; 33 del; 117 mod; 19665 unchg
Patch of changes: tddep.patch
Printable review: tddep.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/pkgcmds/installf/Makefile

*** NO COMMENTS ***
2 lines changed: 0 ins; 0 del; 2 mod; 106 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/pkgcmds/pkgadd/Makefile

*** NO COMMENTS ***
2 lines changed: 0 ins; 0 del; 2 mod; 96 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/pkgcmds/pkgchk/Makefile

*** NO COMMENTS ***
2 lines changed: 0 ins; 0 del; 2 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/pkgcmds/pkgcond/Makefile

*** NO COMMENTS ***
2 lines changed: 0 ins; 0 del; 2 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/pkgcmds/pkginfo/Makefile

*** NO COMMENTS ***
2 lines changed: 0 ins; 0 del; 2 mod; 85 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/pkgcmds/pkginstall/Makefile

*** NO COMMENTS ***
2 lines changed: 0 ins; 0 del; 2 mod; 106 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/pkgcmds/pkgmk/Makefile

*** NO COMMENTS ***
3 lines changed: 0 ins; 0 del; 3 mod; 86 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/pkgcmds/pkgparam/Makefile

*** NO COMMENTS ***
2 lines changed: 0 ins; 0 del; 2 mod; 84 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/pkgcmds/pkgremove/Makefile

*** NO COMMENTS ***
2 lines changed: 0 ins; 0 del; 2 mod; 102 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/pkgcmds/pkgrm/Makefile

*** NO COMMENTS ***
2 lines changed: 0 ins; 0 del; 2 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/slim-install/finish/install-finish

*** NO COMMENTS ***
2 lines changed: 1 ins; 0 del; 1 mod; 504 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/liborchestrator/perform_slim_install.c

*** NO COMMENTS ***
35 lines changed: 35 ins; 0 del; 0 mod; 2784 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libpkg/Makefile

*** NO COMMENTS ***
2 lines changed: 0 ins; 0 del; 2 mod; 88 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libspmicommon/Makefile

*** NO COMMENTS ***
2 lines changed: 0 ins; 0 del; 2 mod; 119 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libspmisoft/Makefile

*** NO COMMENTS ***
2 lines changed: 1 ins; 0 del; 1 mod; 180 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libspmisvc/Makefile

*** NO COMMENTS ***
3 lines changed: 1 ins; 0 del; 2 mod; 189 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libspmizones/Makefile

*** NO COMMENTS ***
5 lines changed: 0 ins; 0 del; 5 mod; 104 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libspmizones/spmizones_api.h

*** NO COMMENTS ***
4 lines changed: 1 ins; 0 del; 3 mod; 182 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libspmizones/spmizones_lib.h

*** NO COMMENTS ***
10 lines changed: 7 ins; 0 del; 3 mod; 368 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libspmizones/zones.c

*** NO COMMENTS ***
18 lines changed: 2 ins; 1 del; 15 mod; 2257 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libspmizones/zones_args.c

*** NO COMMENTS ***
7 lines changed: 0 ins; 1 del; 6 mod; 301 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libspmizones/zones_locks.c

*** NO COMMENTS ***
5 lines changed: 0 ins; 1 del; 4 mod; 990 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libspmizones/zones_lofs.c

*** NO COMMENTS ***
9 lines changed: 0 ins; 1 del; 8 mod; 281 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libspmizones/zones_paths.c

*** NO COMMENTS ***
42 lines changed: 30 ins; 2 del; 10 mod; 424 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libspmizones/zones_states.c

*** NO COMMENTS ***
5 lines changed: 0 ins; 1 del; 4 mod; 582 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libspmizones/zones_str.c

*** NO COMMENTS ***
11 lines changed: 0 ins; 1 del; 10 mod; 702 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libspmizones/zones_utils.c

*** NO COMMENTS ***
143 lines changed: 128 ins; 6 del; 9 mod; 552 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libtd/Makefile

*** NO COMMENTS ***
15 lines changed: 0 ins; 11 del; 4 mod; 104 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libtd/td_dd.c

*** NO COMMENTS ***
4 lines changed: 1 ins; 2 del; 1 mod; 1877 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libtd/td_dd_svm.c

*** NO COMMENTS ***
2 lines changed: 0 ins; 1 del; 1 mod; 1404 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libtd/td_lib.h

*** NO COMMENTS ***
12 lines changed: 12 ins; 0 del; 0 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libtd/td_mg.c

*** NO COMMENTS ***
4 lines changed: 0 ins; 3 del; 1 mod; 2374 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libtd/td_mountall.c

*** NO COMMENTS ***
11 lines changed: 7 ins; 0 del; 4 mod; 1298 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libtd/test_td.c

*** NO COMMENTS ***
2 lines changed: 0 ins; 2 del; 0 mod; 959 unchg

This code review page was prepared using /opt/onbld/bin/webrev (vers 20%E%). Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.