Code Review for netcat-4664622.onnv

Prepared by: vladimir kotal - Sun Microsystems - Prague Czech Republic (vk199839) on Mon Nov 12 09:01:32 CET 2007
Workspace:/local/workspaces/netcat-4664622.onnv
Compare against: /local/workspaces/netcat.OpenBSD
Summary of changes: 654 lines changed: 497 ins; 22 del; 135 mod; 1887 unchg
Patch of changes: netcat-4664622.onnv.patch
Printable review: netcat-4664622.onnv.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/Makefile

PSARC 2007/389 Netcat In Solaris
4664622 Solaris needs netcat
4 lines changed: 1 ins; 2 del; 1 mod; 516 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.bin/Makefile

PSARC 2007/389 Netcat In Solaris
4664622 Solaris needs netcat
2 lines changed: 1 ins; 0 del; 1 mod; 182 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/cmd-inet/usr.bin/nc/Makefile

PSARC 2007/389 Netcat In Solaris
4664622 Solaris needs netcat
52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.bin/nc/atomicio.c

PSARC 2007/389 Netcat In Solaris
4664622 Solaris needs netcat
6 lines changed: 3 ins; 0 del; 3 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.bin/nc/atomicio.h

PSARC 2007/389 Netcat In Solaris
4664622 Solaris needs netcat
6 lines changed: 2 ins; 0 del; 4 mod; 35 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.bin/nc/netcat.c

PSARC 2007/389 Netcat In Solaris
4664622 Solaris needs netcat
123 lines changed: 35 ins; 19 del; 69 mod; 755 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.bin/nc/socks.c

PSARC 2007/389 Netcat In Solaris
4664622 Solaris needs netcat
57 lines changed: 7 ins; 1 del; 49 mod; 276 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/usr.bin/nc/strtonum.c

PSARC 2007/389 Netcat In Solaris
4664622 Solaris needs netcat
10 lines changed: 2 ins; 0 del; 8 mod; 57 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/cmd-inet/usr.bin/nc/strtonum.h

PSARC 2007/389 Netcat In Solaris
4664622 Solaris needs netcat
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkgdefs/SUNWnetcat/Makefile

PSARC 2007/389 Netcat In Solaris
4664622 Solaris needs netcat
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkgdefs/SUNWnetcat/copyright

PSARC 2007/389 Netcat In Solaris
4664622 Solaris needs netcat
71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkgdefs/SUNWnetcat/depend

PSARC 2007/389 Netcat In Solaris
4664622 Solaris needs netcat
51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkgdefs/SUNWnetcat/pkginfo.tmpl

PSARC 2007/389 Netcat In Solaris
4664622 Solaris needs netcat
59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkgdefs/SUNWnetcat/prototype_com

PSARC 2007/389 Netcat In Solaris
4664622 Solaris needs netcat
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkgdefs/SUNWnetcat/prototype_i386

PSARC 2007/389 Netcat In Solaris
4664622 Solaris needs netcat
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkgdefs/SUNWnetcat/prototype_sparc

PSARC 2007/389 Netcat In Solaris
4664622 Solaris needs netcat
47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /local/ontools/onnv-tools/onbld/bin/webrev (vers 2007/09/30). Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.