Code Review for nc_tet_versus_ksh93-6890086.stcnv

Prepared by:vladimir kotal - Sun Microsystems - Prague Czech Republic (vk199839) on Wed Nov 4 22:35:30 CET 2009
Workspace:/workspaces/nc_tet_versus_ksh93-6890086.stcnv
Compare against: /net/grok.czech/ws-local/stcnv-clone
Summary of changes: 127 lines changed: 96 ins; 8 del; 23 mod; 1967 unchg
Patch of changes: nc_tet_versus_ksh93-6890086.stcnv.patch
Printable review: nc_tet_versus_ksh93-6890086.stcnv.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/suites/net/nc/README 

6890086 ksh93 background execution behavior prevents nc test suite from running
8 lines changed: 8 ins; 0 del; 0 mod; 413 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/suites/net/nc/STC.INFO 

6890086 ksh93 background execution behavior prevents nc test suite from running
6897053 lflag test purposes 012,014 are negative so they should be named so
1 line changed: 0 ins; 0 del; 1 mod; 130 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/suites/net/nc/include/commands 

6890086 ksh93 background execution behavior prevents nc test suite from running
6 lines changed: 6 ins; 0 del; 0 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/suites/net/nc/src/lib/ksh/common_funcs.ksh 

6890086 ksh93 background execution behavior prevents nc test suite from running
6897054 nc_kill() should be more careful about which process it is killing
92 lines changed: 71 ins; 8 del; 13 mod; 1165 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/suites/net/nc/tests/iflag/tp_iflag_001_pos.ksh 

6890086 ksh93 background execution behavior prevents nc test suite from running
18 lines changed: 11 ins; 0 del; 7 mod; 81 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/suites/net/nc/tests/lflag/Makefile 

6897053 lflag test purposes 012,014 are negative so they should be named so
2 lines changed: 0 ins; 0 del; 2 mod; 49 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/suites/net/nc/tests/lflag/tp_lflag_012_neg.ksh (renamed only, was usr/src/suites/net/nc/tests/lflag/tp_lflag_012_pos.ksh) 

*** NO COMMENTS ***
0 lines changed: 0 ins; 0 del; 0 mod; 40 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/suites/net/nc/tests/lflag/tp_lflag_014_neg.ksh (renamed only, was usr/src/suites/net/nc/tests/lflag/tp_lflag_014_pos.ksh) 

*** NO COMMENTS ***
0 lines changed: 0 ins; 0 del; 0 mod; 39 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.