Code Review for nc-tet.onnv-stc2

Prepared by:vladimir kotal - Sun Microsystems - Prague Czech Republic (vk199839) on Fri Nov 7 11:47:16 CET 2008
Workspace:/local/workspaces/nc-tet.onnv-stc2
Compare against: /local/ws-mirrors/onnv-stc2-clone
Summary of changes: 5968 lines changed: 5968 ins; 0 del; 0 mod; 0 unchg
Patch of changes: nc-tet.onnv-stc2.patch
Printable review: nc-tet.onnv-stc2.pdf

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/Makefile 

6646967 netcat needs a test suite
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/README 

6646967 netcat needs a test suite
414 lines changed: 414 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/STC.INFO 

6646967 netcat needs a test suite
131 lines changed: 131 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/Targetdirs 

6646967 netcat needs a test suite
69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/include/commands 

6646967 netcat needs a test suite
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/include/vars 

6646967 netcat needs a test suite
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/src/Makefile 

6646967 netcat needs a test suite
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/src/lib/ksh/Makefile 

6646967 netcat needs a test suite
75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/src/lib/ksh/common_funcs.ksh 

6646967 netcat needs a test suite
1089 lines changed: 1089 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/Makefile 

6646967 netcat needs a test suite
57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/Makefile.src 

6646967 netcat needs a test suite
105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/Tflag/Makefile 

6646967 netcat needs a test suite
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/Tflag/tc_Tflag.ksh 

6646967 netcat needs a test suite
84 lines changed: 84 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/Tflag/tp_Tflag_001_pos.ksh 

6646967 netcat needs a test suite
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/Tflag/tp_Tflag_002_pos.ksh 

6646967 netcat needs a test suite
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/Tflag/tp_Tflag_003_pos.ksh 

6646967 netcat needs a test suite
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/Tflag/tp_Tflag_004_pos.ksh 

6646967 netcat needs a test suite
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/Tflag/tp_Tflag_005_neg.ksh 

6646967 netcat needs a test suite
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/Tflag/tp_Tflag_006_neg.ksh 

6646967 netcat needs a test suite
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/Tflag/tp_Tflag_007_neg.ksh 

6646967 netcat needs a test suite
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/Tflag/tp_Tflag_008_pos.ksh 

6646967 netcat needs a test suite
69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/Uflag/Makefile 

6646967 netcat needs a test suite
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/Uflag/tc_Uflag.ksh 

6646967 netcat needs a test suite
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/Uflag/tp_Uflag_001_pos.ksh 

6646967 netcat needs a test suite
45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/Uflag/tp_Uflag_002_neg.ksh 

6646967 netcat needs a test suite
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/dflag/Makefile 

6646967 netcat needs a test suite
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/dflag/tc_dflag.ksh 

6646967 netcat needs a test suite
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/dflag/tp_dflag_001_pos.ksh 

6646967 netcat needs a test suite
81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/hflag/Makefile 

6646967 netcat needs a test suite
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/hflag/tc_hflag.ksh 

6646967 netcat needs a test suite
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/hflag/tp_hflag_001_pos.ksh 

6646967 netcat needs a test suite
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/iflag/Makefile 

6646967 netcat needs a test suite
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/iflag/tc_iflag.ksh 

6646967 netcat needs a test suite
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/iflag/tp_iflag_001_pos.ksh 

6646967 netcat needs a test suite
79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/iflag/tp_iflag_002_neg.ksh 

6646967 netcat needs a test suite
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/kflag/Makefile 

6646967 netcat needs a test suite
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/kflag/tc_kflag.ksh 

6646967 netcat needs a test suite
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/kflag/tp_kflag_001_pos.ksh 

6646967 netcat needs a test suite
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/Makefile 

6646967 netcat needs a test suite
51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tc_lflag.ksh 

6646967 netcat needs a test suite
98 lines changed: 98 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_001_pos.ksh 

6646967 netcat needs a test suite
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_002_pos.ksh 

6646967 netcat needs a test suite
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_003_pos.ksh 

6646967 netcat needs a test suite
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_004_neg.ksh 

6646967 netcat needs a test suite
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_005_neg.ksh 

6646967 netcat needs a test suite
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_006_neg.ksh 

6646967 netcat needs a test suite
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_007_neg.ksh 

6646967 netcat needs a test suite
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_008_neg.ksh 

6646967 netcat needs a test suite
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_009_neg.ksh 

6646967 netcat needs a test suite
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_010_neg.ksh 

6646967 netcat needs a test suite
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_011_pos.ksh 

6646967 netcat needs a test suite
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_012_pos.ksh 

6646967 netcat needs a test suite
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_013_neg.ksh 

6646967 netcat needs a test suite
59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_014_pos.ksh 

6646967 netcat needs a test suite
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_015_neg.ksh 

6646967 netcat needs a test suite
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_016_neg.ksh 

6646967 netcat needs a test suite
59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_017_pos.ksh 

6646967 netcat needs a test suite
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/lflag/tp_lflag_018_pos.ksh 

6646967 netcat needs a test suite
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/nflag/Makefile 

6646967 netcat needs a test suite
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/nflag/tc_nflag.ksh 

6646967 netcat needs a test suite
58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/nflag/tp_nflag_001_pos.ksh 

6646967 netcat needs a test suite
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/nflag/tp_nflag_002_neg.ksh 

6646967 netcat needs a test suite
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/pflag/Makefile 

6646967 netcat needs a test suite
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/pflag/tc_pflag.ksh 

6646967 netcat needs a test suite
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/pflag/tp_pflag_001_pos.ksh 

6646967 netcat needs a test suite
67 lines changed: 67 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/portranges/Makefile 

6646967 netcat needs a test suite
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/portranges/tc_portranges.ksh 

6646967 netcat needs a test suite
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/portranges/tp_portranges_001_neg.ksh 

6646967 netcat needs a test suite
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/portranges/tp_portranges_002_pos.ksh 

6646967 netcat needs a test suite
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/portranges/tp_portranges_003_neg.ksh 

6646967 netcat needs a test suite
50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/portranges/tp_portranges_004_neg.ksh 

6646967 netcat needs a test suite
53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/rflag/Makefile 

6646967 netcat needs a test suite
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/rflag/tc_rflag.ksh 

6646967 netcat needs a test suite
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/rflag/tp_rflag_001_pos.ksh 

6646967 netcat needs a test suite
116 lines changed: 116 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/sflag/Makefile 

6646967 netcat needs a test suite
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/sflag/tc_sflag.ksh 

6646967 netcat needs a test suite
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/sflag/tp_sflag_001_pos.ksh 

6646967 netcat needs a test suite
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/sflag/tp_sflag_002_neg.ksh 

6646967 netcat needs a test suite
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/uflag/Makefile 

6646967 netcat needs a test suite
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/uflag/tc_uflag.ksh 

6646967 netcat needs a test suite
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/uflag/tp_uflag_001_pos.ksh 

6646967 netcat needs a test suite
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/uflag/tp_uflag_002_pos.ksh 

6646967 netcat needs a test suite
69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/uflag/tp_uflag_003_neg.ksh 

6646967 netcat needs a test suite
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/vflag/Makefile 

6646967 netcat needs a test suite
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/vflag/tc_vflag.ksh 

6646967 netcat needs a test suite
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/vflag/tp_vflag_001_pos.ksh 

6646967 netcat needs a test suite
69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/vflag/tp_vflag_002_pos.ksh 

6646967 netcat needs a test suite
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/wflag/Makefile 

6646967 netcat needs a test suite
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/wflag/tc_wflag.ksh 

6646967 netcat needs a test suite
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/wflag/tp_wflag_001_pos.ksh 

6646967 netcat needs a test suite
99 lines changed: 99 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/zflag/Makefile 

6646967 netcat needs a test suite
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/zflag/tc_zflag.ksh 

6646967 netcat needs a test suite
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tests/zflag/tp_zflag_001_pos.ksh 

6646967 netcat needs a test suite
65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/suites/net/nc/tet_scen 

6646967 netcat needs a test suite
108 lines changed: 108 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /local/workspaces/webrev_upload.onnv/usr/src/tools/scripts/webrev. Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.