Code Review for iscsit-nwsnv-clone

Prepared by:Peter Dunlap (pd144616) on Fri Apr 4 13:31:10 MDT 2008
Workspace:/myws/iscsit-nwsnv-clone
Compare against: /net/nwsc-gates.central/nws-pool/projects/comstar/stmf-nv
Summary of changes: 15641 lines changed: 15615 ins; 15 del; 11 mod; 3757 unchg
Patch of changes: iscsit-nwsnv-clone.patch
Printable review: iscsit-nwsnv-clone.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/sun_nws/Makefile.common

NO_COMMENT
17 lines changed: 0 ins; 15 del; 2 mod; 379 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/sun_nws/Makefile.config

NO_COMMENT
7 lines changed: 5 ins; 0 del; 2 mod; 256 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/comstar/port_providers/iscsit/Makefile

NO_COMMENT
128 lines changed: 128 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/comstar/port_providers/iscsit/hdrs/iscsit.h

NO_COMMENT
505 lines changed: 505 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/comstar/port_providers/iscsit/hdrs/iscsit_auth.h

NO_COMMENT
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/comstar/port_providers/iscsit/hdrs/iscsit_authclient.h

NO_COMMENT
162 lines changed: 162 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/comstar/port_providers/iscsit/hdrs/iscsit_authglue.h

NO_COMMENT
56 lines changed: 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/comstar/port_providers/iscsit/hdrs/iscsit_util.h

NO_COMMENT
168 lines changed: 168 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/comstar/port_providers/iscsit/hdrs/radius_auth.h

NO_COMMENT
76 lines changed: 76 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- --- ----- --- src/sun_nws/comstar/port_provide2s/iscsit/src/iscsit.c

NO_COMMENT

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/comstar/port_providers/iscsit/src/iscsit.conf

NO_COMMENT
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/comstar/port_providers/iscsit/src/iscsit_auth.c

NO_COMMENT
757 lines changed: 757 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/comstar/port_providers/iscsit/src/iscsit_authclient.c

NO_COMMENT
279 lines changed: 279 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/comstar/port_providers/iscsit/src/iscsit_authglue.c

NO_COMMENT
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/comstar/port_providers/iscsit/src/iscsit_login.c

NO_COMMENT
2262 lines changed: 2262 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/comstar/port_providers/iscsit/src/iscsit_sess.c

NO_COMMENT
731 lines changed: 731 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/comstar/port_providers/iscsit/src/iscsit_tgt.c

NO_COMMENT
669 lines changed: 669 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/comstar/port_providers/iscsit/src/iscsit_util.c

NO_COMMENT
1273 lines changed: 1273 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/comstar/port_providers/iscsit/src/radius_auth.c

NO_COMMENT
183 lines changed: 183 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/comstar/port_providers/iscsit/src/radius_packet.c

NO_COMMENT
265 lines changed: 265 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/sun_nws/headers/common/iscsi/iscsi_protocol.h

NO_COMMENT
21 lines changed: 19 ins; 0 del; 2 mod; 676 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/idm/Makefile

NO_COMMENT
125 lines changed: 125 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/idm/hdrs/idm.h

NO_COMMENT
253 lines changed: 253 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/idm/hdrs/idm_conn_sm.h

NO_COMMENT
188 lines changed: 188 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/idm/hdrs/idm_impl.h

NO_COMMENT
325 lines changed: 325 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/idm/hdrs/idm_so.h

NO_COMMENT
134 lines changed: 134 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/idm/hdrs/idm_transport.h

NO_COMMENT
176 lines changed: 176 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/idm/src/idm.c

NO_COMMENT
1307 lines changed: 1307 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/idm/src/idm_conn_sm.c

NO_COMMENT
1217 lines changed: 1217 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/idm/src/idm_impl.c

NO_COMMENT
896 lines changed: 896 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/idm/src/idm_so.c

NO_COMMENT
1768 lines changed: 1768 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/sun_nws/mdb_modules/fc/Makefile (modified and renamed, was src/sun_nws/mdb_modules/Makefile)

NO_COMMENT
16 lines changed: 11 ins; 0 del; 5 mod; 72 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/mdb_modules/iscsi/Makefile

NO_COMMENT
81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/mdb_modules/iscsi/src/iscsi.c

NO_COMMENT
1180 lines changed: 1180 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/pkgdefs/SUNWiscsitr/pkginfo.tmpl

NO_COMMENT
50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/pkgdefs/SUNWiscsitr/postinstall

NO_COMMENT
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/pkgdefs/SUNWiscsitr/preremove

NO_COMMENT
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/pkgdefs/SUNWiscsitr/prototype_com

NO_COMMENT
54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/pkgdefs/SUNWiscsitr/prototype_i386

NO_COMMENT
59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/sun_nws/pkgdefs/SUNWiscsitr/prototype_sparc

NO_COMMENT
55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old New Patch Raw src/sun_nws/headers/common/iscsi/chap.h (renamed only, was src/sun_nws/iscsi/hdrs/chap.h)

Renamed only (webrev comment generated by  wx, not an sccs comment)
0 lines changed: 0 ins; 0 del; 0 mod; 97 unchg

------ ------ ------ ------ ------ Old New Patch Raw src/sun_nws/headers/common/iscsi/radius_packet.h (renamed only, was src/sun_nws/iscsi/hdrs/radius_packet.h)

Renamed only (webrev comment generated by  wx, not an sccs comment)
0 lines changed: 0 ins; 0 del; 0 mod; 100 unchg

------ ------ ------ ------ ------ Old New Patch Raw src/sun_nws/headers/common/iscsi/radius_protocol.h (renamed only, was src/sun_nws/iscsi/hdrs/radius_protocol.h)

Renamed only (webrev comment generated by  wx, not an sccs comment)
0 lines changed: 0 ins; 0 del; 0 mod; 86 unchg

------ ------ ------ ------ ------ Old New Patch Raw src/sun_nws/mdb_modules/fc/src/fcip.c (renamed only, was src/sun_nws/mdb_modules/src/fcip.c)

Renamed only (webrev comment generated by  wx, not an sccs comment)
0 lines changed: 0 ins; 0 del; 0 mod; 165 unchg

------ ------ ------ ------ ------ Old New Patch Raw src/sun_nws/mdb_modules/fc/src/fcp.c (renamed only, was src/sun_nws/mdb_modules/src/fcp.c)

Renamed only (webrev comment generated by  wx, not an sccs comment)
0 lines changed: 0 ins; 0 del; 0 mod; 565 unchg

------ ------ ------ ------ ------ Old New Patch Raw src/sun_nws/mdb_modules/fc/src/fctl.c (renamed only, was src/sun_nws/mdb_modules/src/fctl.c)

Renamed only (webrev comment generated by  wx, not an sccs comment)
0 lines changed: 0 ins; 0 del; 0 mod; 1361 unchg

This code review page was prepared using /opt/onbld/bin/webrev (vers 20%E%). Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.