Code Review for 29_09_new_api

Prepared by:Michal Pryc <Michal.Pryc@Sun.Com> on Sat Sep 27 11:24:19 IST 2008
Workspace:/export/home/migi/Desktop/ips_gui_development/29_09_new_api (at 0aa73d2bf0bc)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 1fb81f8a566d)
Summary of changes: 5485 lines changed: 3172 ins; 1878 del; 435 mod; 11447 unchg
Patch of changes: 29_09_new_api.patch
Printable review: 29_09_new_api.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/client.py

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
652 lines changed: 80 ins; 437 del; 135 mod; 1625 unchg

executable file: mode 755

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/Makefile

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
4 lines changed: 0 ins; 2 del; 2 mod; 160 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/data/packagemanager.glade

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
412 lines changed: 211 ins; 158 del; 43 mod; 3029 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/modules/__init__.py

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
2 lines changed: 0 ins; 0 del; 2 mod; 25 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/modules/enumerations.py

*** NO COMMENTS ***
8 lines changed: 6 ins; 1 del; 1 mod; 71 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/gui/modules/filelist.py (deleted)

*** NO COMMENTS ***
113 lines changed: 0 ins; 113 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/modules/installupdate.py

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
738 lines changed: 78 ins; 560 del; 100 mod; 325 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/gui/modules/remove.py (deleted)

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
393 lines changed: 0 ins; 393 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/gui/modules/repository.py

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
500 lines changed: 500 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/gui/modules/thread.py (deleted)

*** NO COMMENTS ***
42 lines changed: 0 ins; 42 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/man/pkg.1.txt

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
8 lines changed: 0 ins; 0 del; 8 mod; 366 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/modules/client/api.py

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
762 lines changed: 762 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/modules/client/api_errors.py

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
162 lines changed: 162 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/client/image.py

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
219 lines changed: 151 ins; 47 del; 21 mod; 1953 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/client/imageplan.py

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
90 lines changed: 47 ins; 33 del; 10 mod; 662 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/client/progress.py

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
41 lines changed: 38 ins; 0 del; 3 mod; 604 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/misc.py

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
7 lines changed: 7 ins; 0 del; 0 mod; 445 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/packagemanager.py

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
422 lines changed: 222 ins; 92 del; 108 mod; 1726 unchg

executable file: mode 755

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/tests/baseline.txt

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
17 lines changed: 17 ins; 0 del; 0 mod; 322 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/tests/cli/t_api.py

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
247 lines changed: 247 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/tests/cli/t_api_info.py

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
138 lines changed: 138 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/tests/cli/t_pkg_api_install.py

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
501 lines changed: 501 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/tests/cli/t_pkg_history.py

Merged three patches for progress, edit repos and api in order:
API
progress
edit repos with one conflict
7 lines changed: 5 ins; 0 del; 2 mod; 134 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.