Code Review for storefront_merge

Prepared by:Michal Pryc <Michal.Pryc@Sun.Com> on Wed Dec 10 19:45:00 GMT 2008
Workspace:/export/home/migi/Desktop/development/gates/storefront_merge (at 68018dae1ed4)
Compare against: ssh://migi@hg.opensolaris.org/hg/pkg/gate (at 68018dae1ed4)
Summary of changes: 550 lines changed: 491 ins; 12 del; 47 mod; 6403 unchg
Patch of changes: storefront_merge.patch
Printable review: storefront_merge.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/Makefile

*** NO COMMENTS ***
16 lines changed: 15 ins; 0 del; 1 mod; 215 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/data/packagemanager.glade

*** NO COMMENTS ***
1 line changed: 0 ins; 0 del; 1 mod; 3325 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/storefrontbase/opensolaris.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/gui/data/storefrontbase/opensolaris.png`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/storefrontbase/store_star.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/gui/data/storefrontbase/store_star.png`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/storefrontbase/storefront.html

*** NO COMMENTS ***
13 lines changed: 13 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/storefrontbase/storefront.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/gui/data/storefrontbase/storefront.png`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/storefrontbase/top_picks.html

*** NO COMMENTS ***
24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/modules/repository.py

*** NO COMMENTS ***
43 lines changed: 26 ins; 1 del; 16 mod; 595 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/packagemanager.py

*** NO COMMENTS ***
450 lines changed: 413 ins; 11 del; 26 mod; 2106 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/tests/gui_pylintrc

*** NO COMMENTS ***
3 lines changed: 0 ins; 0 del; 3 mod; 162 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.