Code Review for gate_09_10_with_pm_api_um

Prepared by:Michal Pryc (michal) on Thursday 9 October 2008 15:15:34 IST
Workspace:/export/home/michal/Desktop/merging/gate_09_10_with_pm_api_um (at 8a013899174e)
Compare against: /export/home/michal/Desktop/merging/clean_gate_09_10_with_pm_api (at 8a013899174e)
Summary of changes: 3436 lines changed: 3429 ins; 0 del; 7 mod; 967 unchg
Patch of changes: gate_09_10_with_pm_api_um.patch
Printable review: gate_09_10_with_pm_api_um.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/Makefile

*** NO COMMENTS ***
6 lines changed: 6 ins; 0 del; 0 mod; 103 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/pkg-update.xml

*** NO COMMENTS ***
95 lines changed: 95 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/pkgdefs/Makefile

*** NO COMMENTS ***
1 line changed: 1 ins; 0 del; 0 mod; 32 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/pkgdefs/SUNWipkg-gui/Makefile

*** NO COMMENTS ***
1 line changed: 0 ins; 0 del; 1 mod; 72 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/pkgdefs/SUNWipkg-um/Makefile

*** NO COMMENTS ***
77 lines changed: 77 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/pkgdefs/SUNWipkg-um/SUNWipkg-um.import

*** NO COMMENTS ***
6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/pkgdefs/SUNWipkg-um/copyright

*** NO COMMENTS ***
344 lines changed: 344 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/pkgdefs/SUNWipkg-um/pkginfo

*** NO COMMENTS ***
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/pkgdefs/SUNWipkg/Makefile

*** NO COMMENTS ***
1 line changed: 0 ins; 0 del; 1 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/setup.py

*** NO COMMENTS ***
3 lines changed: 3 ins; 0 del; 0 mod; 534 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/tests/gui_pylintrc

*** NO COMMENTS ***
5 lines changed: 0 ins; 0 del; 5 mod; 160 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/um/Makefile

*** NO COMMENTS ***
190 lines changed: 190 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/um/data/PM_app_48x.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/um/data/PM_app_48x.png`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw src/um/data/PM_package_36x.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/um/data/PM_package_36x.png`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw src/um/data/icons/notify_update.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/um/data/icons/notify_update.png`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw src/um/data/icons/status_blank.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/um/data/icons/status_blank.png`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw src/um/data/icons/status_checkmark.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/um/data/icons/status_checkmark.png`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw src/um/data/updatemanager-preferences.schemas.in

*** NO COMMENTS ***
59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/um/data/updatemanager.desktop.in

*** NO COMMENTS ***
14 lines changed: 14 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/um/data/updatemanager.glade

*** NO COMMENTS ***
600 lines changed: 600 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/um/data/updatemanagernotifier.desktop.in

*** NO COMMENTS ***
13 lines changed: 13 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/um/pkg-update

*** NO COMMENTS ***
85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/um/update-refresh.sh

*** NO COMMENTS ***
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/updatemanager.py

*** NO COMMENTS ***
1503 lines changed: 1503 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/updatemanagernotifier.py

*** NO COMMENTS ***
362 lines changed: 362 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.