Code Review for gate_08_10_2008

Prepared by:Michal Pryc (michal) on Wednesday 8 October 2008 19:30:38 IST
Workspace:/export/home/michal/Desktop/gate_08_10_2008 (at 1a2452c33cb9)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 1a2452c33cb9)
Summary of changes: 3656 lines changed: 1747 ins; 1481 del; 428 mod; 8806 unchg
Patch of changes: gate_08_10_2008.patch
Printable review: gate_08_10_2008.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/Makefile

*** NO COMMENTS ***
24 lines changed: 17 ins; 2 del; 5 mod; 157 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/gui/data/icons/new_update.png (deleted)

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e old/src/gui/data/icons/new_update.png /dev/null`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/icons/status_installed.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/gui/data/icons/status_installed.png`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/icons/status_newupdate.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/gui/data/icons/status_newupdate.png`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/install_update24x.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/gui/data/install_update24x.png`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/legal.xml

*** NO COMMENTS ***
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/package-manager.xml

*** NO COMMENTS ***
253 lines changed: 253 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/data/packagemanager.glade

*** NO COMMENTS ***
696 lines changed: 361 ins; 219 del; 116 mod; 2895 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/reload24x.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/gui/data/reload24x.png`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/remove24x.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/gui/data/remove24x.png`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/update_all24x.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/gui/data/update_all24x.png`: $?=0, err= 1

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/modules/__init__.py

*** NO COMMENTS ***
2 lines changed: 0 ins; 0 del; 2 mod; 25 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/modules/enumerations.py

*** NO COMMENTS ***
8 lines changed: 6 ins; 1 del; 1 mod; 71 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/gui/modules/filelist.py (deleted)

*** NO COMMENTS ***
113 lines changed: 0 ins; 113 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/modules/installupdate.py

*** NO COMMENTS ***
848 lines changed: 170 ins; 544 del; 134 mod; 317 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/gui/modules/remove.py (deleted)

*** NO COMMENTS ***
395 lines changed: 0 ins; 395 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/gui/modules/repository.py

*** NO COMMENTS ***
501 lines changed: 501 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/gui/modules/thread.py (deleted)

*** NO COMMENTS ***
42 lines changed: 0 ins; 42 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/client/image.py

*** NO COMMENTS ***
1 line changed: 0 ins; 0 del; 1 mod; 2272 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/client/imageplan.py

*** NO COMMENTS ***
56 lines changed: 29 ins; 18 del; 9 mod; 700 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/client/progress.py

*** NO COMMENTS ***
16 lines changed: 13 ins; 0 del; 3 mod; 599 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/packagemanager.py

*** NO COMMENTS ***
660 lines changed: 360 ins; 147 del; 153 mod; 1634 unchg

executable file: mode 755

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/pkgdefs/SUNWipkg-gui/Makefile

*** NO COMMENTS ***
3 lines changed: 0 ins; 0 del; 3 mod; 70 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/pkgdefs/SUNWipkg/Makefile

*** NO COMMENTS ***
1 line changed: 0 ins; 0 del; 1 mod; 66 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.