Code Review for 05_10_with_api_and_gui

Prepared by:Michal Pryc <Michal.Pryc@Sun.Com> on Sun Oct 5 16:19:33 IST 2008
Workspace:/export/home/migi/Desktop/ips_gui_development/05_10_with_api_and_gui (at 6e4bcf53603e)
Compare against: /export/home/migi/Desktop/ips_gui_development/03_10_new_api_v1 (at 6e4bcf53603e)
Summary of changes: 3152 lines changed: 1316 ins; 1459 del; 377 mod; 8893 unchg
Patch of changes: 05_10_with_api_and_gui.patch
Printable review: 05_10_with_api_and_gui.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/Makefile

*** NO COMMENTS ***
23 lines changed: 16 ins; 2 del; 5 mod; 157 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/gui/data/icons/new_update.png (deleted)

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e old/src/gui/data/icons/new_update.png /dev/null`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/icons/status_installed.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/gui/data/icons/status_installed.png`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/icons/status_newupdate.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/gui/data/icons/status_newupdate.png`: $?=0, err= 1

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/install_update24x.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/gui/data/install_update24x.png`: $?=0, err= 1

new executable file: mode 755

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/package-manager.xml

*** NO COMMENTS ***
12 lines changed: 12 ins; 0 del; 0 mod; 0 unchg

new executable file: mode 755

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/data/packagemanager.glade

*** NO COMMENTS ***
548 lines changed: 295 ins; 177 del; 76 mod; 2977 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/reload24x.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/gui/data/reload24x.png`: $?=0, err= 1

new executable file: mode 755

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/remove24x.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/gui/data/remove24x.png`: $?=0, err= 1

new executable file: mode 755

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/update_all24x.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/gui/data/update_all24x.png`: $?=0, err= 1

new executable file: mode 755

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/modules/__init__.py

*** NO COMMENTS ***
2 lines changed: 0 ins; 0 del; 2 mod; 25 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/modules/enumerations.py

*** NO COMMENTS ***
8 lines changed: 6 ins; 1 del; 1 mod; 71 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/gui/modules/filelist.py (deleted)

*** NO COMMENTS ***
113 lines changed: 0 ins; 113 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/modules/installupdate.py

*** NO COMMENTS ***
784 lines changed: 113 ins; 549 del; 122 mod; 322 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/gui/modules/remove.py (deleted)

*** NO COMMENTS ***
395 lines changed: 0 ins; 395 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/gui/modules/repository.py

*** NO COMMENTS ***
501 lines changed: 501 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/gui/modules/thread.py (deleted)

*** NO COMMENTS ***
42 lines changed: 0 ins; 42 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/client/image.py

*** NO COMMENTS ***
1 line changed: 0 ins; 0 del; 1 mod; 2275 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/client/imageplan.py

*** NO COMMENTS ***
56 lines changed: 29 ins; 18 del; 9 mod; 694 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/client/progress.py

*** NO COMMENTS ***
16 lines changed: 13 ins; 0 del; 3 mod; 620 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/packagemanager.py

*** NO COMMENTS ***
647 lines changed: 331 ins; 162 del; 154 mod; 1616 unchg

executable file: mode 755

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/pkgdefs/SUNWipkg-gui/Makefile

*** NO COMMENTS ***
3 lines changed: 0 ins; 0 del; 3 mod; 70 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/pkgdefs/SUNWipkg/Makefile

*** NO COMMENTS ***
1 line changed: 0 ins; 0 del; 1 mod; 66 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.