Code Review for 02_10_new_api

Prepared by:Michal Pryc <Michal.Pryc@Sun.Com> on Thu Oct 2 08:03:08 IST 2008
Workspace:/export/home/migi/Desktop/ips_gui_development/02_10_new_api (at be1ad23e7704)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at be1ad23e7704)
Summary of changes: 3031 lines changed: 1232 ins; 1445 del; 354 mod; 8732 unchg
Patch of changes: 02_10_new_api.patch
Printable review: 02_10_new_api.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/Makefile

*** NO COMMENTS ***
6 lines changed: 1 ins; 2 del; 3 mod; 159 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/gui/data/icons/status_installed.png

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e /dev/null new/src/gui/data/icons/status_installed.png`: $?=0, err= 1

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/data/icons/status_newupdate.png (modified and renamed, was src/gui/data/icons/new_update.png)

*** NO COMMENTS ***
Unexpected Error occurred reading `diff -e old/src/gui/data/icons/new_update.png new/src/gui/data/icons/status_newupdate.png`: $?=0, err= 1

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/data/packagemanager.glade

*** NO COMMENTS ***
484 lines changed: 255 ins; 174 del; 55 mod; 3001 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/modules/__init__.py

*** NO COMMENTS ***
2 lines changed: 0 ins; 0 del; 2 mod; 25 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/modules/enumerations.py

*** NO COMMENTS ***
8 lines changed: 6 ins; 1 del; 1 mod; 71 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/gui/modules/filelist.py (deleted)

*** NO COMMENTS ***
113 lines changed: 0 ins; 113 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/gui/modules/installupdate.py

*** NO COMMENTS ***
780 lines changed: 111 ins; 544 del; 125 mod; 321 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/gui/modules/remove.py (deleted)

*** NO COMMENTS ***
393 lines changed: 0 ins; 393 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/gui/modules/repository.py

*** NO COMMENTS ***
501 lines changed: 501 ins; 0 del; 0 mod; 0 unchg

new executable file: mode 755

------ ------ ------ ------ ------ Old --- Patch --- src/gui/modules/thread.py (deleted)

*** NO COMMENTS ***
42 lines changed: 0 ins; 42 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/client/image.py

*** NO COMMENTS ***
1 line changed: 0 ins; 0 del; 1 mod; 2182 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/client/imageplan.py

*** NO COMMENTS ***
56 lines changed: 29 ins; 18 del; 9 mod; 691 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/client/progress.py

*** NO COMMENTS ***
15 lines changed: 12 ins; 0 del; 3 mod; 595 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/packagemanager.py

*** NO COMMENTS ***
629 lines changed: 317 ins; 158 del; 154 mod; 1615 unchg

executable file: mode 755

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/pkgdefs/SUNWipkg-gui/Makefile

*** NO COMMENTS ***
1 line changed: 0 ins; 0 del; 1 mod; 72 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.