Code Review for onnv-33

Prepared by:John Levon <john.levon@sun.com> on Mon Apr 6 14:24:03 PDT 2009
Workspace:/export/johnlev/33/onnv-33 (at 6d77f803a8b7)
Compare against: /net/heaped/export/3.3/onnv-3.3 (at 20e23a6259aa)
Summary of changes: 2589 lines changed: 680 ins; 1801 del; 108 mod; 26655 unchg
Patch of changes: onnv-33.patch
Printable review: onnv-33.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/i386_hwcap3/Makefile

* * *
8 lines changed: 5 ins; 2 del; 1 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWhea/prototype_i386

* * *
4 lines changed: 3 ins; 0 del; 1 mod; 172 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/xen/io/xdf.c

Move PV driver version xenstore writes into guest/
1 line changed: 0 ins; 0 del; 1 mod; 3524 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/xen/io/xnf.c

Move PV driver version xenstore writes into guest/
1 line changed: 0 ins; 0 del; 1 mod; 2631 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/xen/io/xpvd.c

Move PV driver version xenstore writes into guest/
1 line changed: 0 ins; 0 del; 1 mod; 1002 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/Makefile.files

* * *
1 line changed: 1 ins; 0 del; 0 mod; 234 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/i86hvm/io/xpv/xpv_support.c

Move PV driver version xenstore writes into guest/
1 line changed: 0 ins; 0 del; 1 mod; 956 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/ml/syscall_asm_amd64.s

* * *
25 lines changed: 10 ins; 4 del; 11 mod; 1255 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/cpr_impl.c

* * *
2 lines changed: 1 ins; 1 del; 0 mod; 1064 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/cpuid.c

* * *
* * *
179 lines changed: 24 ins; 145 del; 10 mod; 3793 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/cpupm/cpu_idle.c

* * *
1 line changed: 1 ins; 0 del; 0 mod; 877 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/intr.c

* * *
3 lines changed: 1 ins; 2 del; 0 mod; 1193 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/mp_machdep.c

* * *
11 lines changed: 1 ins; 10 del; 0 mod; 1518 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/mp_startup.c

* * *
* * *
167 lines changed: 1 ins; 165 del; 1 mod; 1641 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/i86pc/os/pc_platdep.c

* * *
272 lines changed: 272 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/sys/Makefile

* * *
3 lines changed: 2 ins; 0 del; 1 mod; 94 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/i86pc/sys/pc_platdep.h

* * *
* * *
50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/i86pc/sys/platdep.h

* * *
60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/Makefile.files

* * *
3 lines changed: 2 ins; 1 del; 0 mod; 251 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/os/mp_xen.c

* * *
9 lines changed: 0 ins; 8 del; 1 mod; 1050 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/os/xpv_platdep.c (modified and renamed, was usr/src/uts/i86xpv/os/xen_machdep.c)

* * *
583 lines changed: 174 ins; 349 del; 60 mod; 983 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/os/xpv_suspend.c (modified and renamed, was usr/src/uts/i86xpv/os/xen_machdep.c)

* * *
1006 lines changed: 1 ins; 998 del; 7 mod; 387 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/os/xpv_timestamp.c

Allow hrtime_fake_mt setting to be changed dynamically.
Disable hrtime_fake_mt.
2 lines changed: 1 ins; 1 del; 0 mod; 172 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/sys/Makefile

* * *
5 lines changed: 1 ins; 2 del; 2 mod; 68 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/sys/machprivregs.h

* * *
4 lines changed: 0 ins; 2 del; 2 mod; 532 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/i86xpv/sys/xpv_platdep.h

* * *
* * *
59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ia32/os/desctbls.c

* * *
102 lines changed: 1 ins; 100 del; 1 mod; 1301 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ia32/os/sysi86.c

* * *
5 lines changed: 1 ins; 0 del; 4 mod; 884 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/archsystm.h

* * *
2 lines changed: 0 ins; 1 del; 1 mod; 209 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/cpu.h

* * *
6 lines changed: 0 ins; 5 del; 1 mod; 82 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/machbrand.h

* * *
8 lines changed: 8 ins; 0 del; 0 mod; 60 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/x86_archext.h

* * *
* * *
5 lines changed: 0 ins; 5 del; 0 mod; 677 unchg

This code review page was prepared using /ws/onnv-tools/onbld/bin/webrev. Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.