Code Review for onnv-33

Prepared by:John Levon <john.levon@sun.com> on Mon Jul 27 07:00:12 PDT 2009
Workspace:/builds/johnlev/archive/33/onnv-33 (at 44fe5ea151aa)
Compare against: /net/heaped/export/3.3/onnv-3.3 (at 7c236e4079ef)
Summary of changes: 2577 lines changed: 692 ins; 1786 del; 99 mod; 15005 unchg
Patch of changes: onnv-33.patch
Printable review: onnv-33.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/i386_hwcap3/Makefile

* * *
8 lines changed: 5 ins; 2 del; 1 mod; 45 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWhea/prototype_i386

* * *
4 lines changed: 3 ins; 0 del; 1 mod; 172 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/Makefile.files

* * *
1 line changed: 1 ins; 0 del; 0 mod; 239 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/ml/syscall_asm_amd64.s

* * *
25 lines changed: 10 ins; 4 del; 11 mod; 1255 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/cpr_impl.c

* * *
2 lines changed: 1 ins; 1 del; 0 mod; 1064 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/cpuid.c

* * *
164 lines changed: 0 ins; 157 del; 7 mod; 3858 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/mp_startup.c

* * *
161 lines changed: 1 ins; 160 del; 0 mod; 1658 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/i86pc/os/pc_platdep.c

* * *
305 lines changed: 305 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/sys/Makefile

* * *
3 lines changed: 2 ins; 0 del; 1 mod; 94 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/i86pc/sys/pc_platdep.h

* * *
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/i86pc/sys/platdep.h

* * *
63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/Makefile.files

* * *
3 lines changed: 2 ins; 1 del; 0 mod; 251 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/os/mp_xen.c

* * *
6 lines changed: 0 ins; 6 del; 0 mod; 1053 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/os/xpv_platdep.c (modified and renamed, was usr/src/uts/i86xpv/os/xen_machdep.c)

* * *
595 lines changed: 186 ins; 349 del; 60 mod; 983 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/os/xpv_suspend.c (modified and renamed, was usr/src/uts/i86xpv/os/xen_machdep.c)

* * *
1006 lines changed: 1 ins; 998 del; 7 mod; 387 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/os/xpv_timestamp.c

Disable hrtime_fake_mt.
1 line changed: 0 ins; 0 del; 1 mod; 170 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/sys/Makefile

* * *
5 lines changed: 1 ins; 2 del; 2 mod; 68 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/sys/machprivregs.h

* * *
4 lines changed: 0 ins; 2 del; 2 mod; 532 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/i86xpv/sys/xpv_platdep.h

* * *
53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ia32/os/desctbls.c

* * *
102 lines changed: 1 ins; 100 del; 1 mod; 1301 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ia32/os/sysi86.c

* * *
5 lines changed: 1 ins; 0 del; 4 mod; 884 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/archsystm.h

* * *
2 lines changed: 0 ins; 1 del; 1 mod; 209 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/machbrand.h

* * *
8 lines changed: 8 ins; 0 del; 0 mod; 60 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/x86_archext.h

* * *
3 lines changed: 0 ins; 3 del; 0 mod; 722 unchg

This code review page was prepared using /ws/onnv-tools/onbld/bin/webrev. Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.