Code Review for pkg-mfst

Prepared by:johansen on Wed Nov 4 15:40:22 PST 2009
Workspace:/home/johansen/hg_ws/pkg-mfst (at 4d6fef1e9de2)
Compare against: ssh://johansen@opensolaris.org/hg/pkg/gate (at bfdf13d64d47)
Summary of changes: 603 lines changed: 473 ins; 93 del; 37 mod; 7497 unchg
Patch of changes: pkg-mfst.patch
Printable review: pkg-mfst.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/client.py 

12128 client should pipeline manifest retrieval
12418 StreamingFileObj prints AttributeError
12460 traceback if pkg-server absent during valid version test
12478 Temporary download directory needs more cleanup
1 line changed: 1 ins; 0 del; 0 mod; 2957 unchg

executable file: mode 755

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/client/api.py 

12128 client should pipeline manifest retrieval
12418 StreamingFileObj prints AttributeError
12460 traceback if pkg-server absent during valid version test
12478 Temporary download directory needs more cleanup
1 line changed: 1 ins; 0 del; 0 mod; 1762 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/client/transport/engine.py 

12128 client should pipeline manifest retrieval
12418 StreamingFileObj prints AttributeError
12460 traceback if pkg-server absent during valid version test
12478 Temporary download directory needs more cleanup
79 lines changed: 8 ins; 61 del; 10 mod; 757 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/client/transport/fileobj.py 

12128 client should pipeline manifest retrieval
12418 StreamingFileObj prints AttributeError
12460 traceback if pkg-server absent during valid version test
12478 Temporary download directory needs more cleanup
6 lines changed: 5 ins; 0 del; 1 mod; 297 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/client/transport/repo.py 

12128 client should pipeline manifest retrieval
12418 StreamingFileObj prints AttributeError
12460 traceback if pkg-server absent during valid version test
12478 Temporary download directory needs more cleanup
161 lines changed: 153 ins; 0 del; 8 mod; 453 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/modules/client/transport/transport.py 

12128 client should pipeline manifest retrieval
12418 StreamingFileObj prints AttributeError
12460 traceback if pkg-server absent during valid version test
12478 Temporary download directory needs more cleanup
355 lines changed: 305 ins; 32 del; 18 mod; 1271 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.