os-tmp

Code Review for os-tmp

Prepared by:	Gavin Maltby (gavinm) on Wed Aug 1 14:13:21 BST 2007
Workspace:	/net/tB3/tank/u/gavinm/generic_cpu/os-tmp
Compare against:	/net/tulasco.uk/gate/onnv-gates/onnv-clone
Summary of changes:	7663 lines changed: 5441 ins; 1231 del; 991 mod; 26271 unchg
Patch of changes:	os-tmp.patch
Printable review:	os-tmp.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/eversholt/files/Makefile.com

--- 1.8 ---
6567634 generic x86 MCA support needs to be improved
9 lines changed: 6 ins; 2 del; 1 mod; 54 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/eversholt/files/i386/i86pc/Makefile

--- 1.2 ---
6567634 generic x86 MCA support needs to be improved
2 lines changed: 0 ins; 0 del; 2 mod; 29 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/fm/eversholt/files/i386/i86pc/gcpu.esc

91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/i86pc/modules/Makefile

--- 1.6 ---
6567634 generic x86 MCA support needs to be improved
2 lines changed: 1 ins; 0 del; 1 mod; 33 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/i86pc/modules/amd_opteron/amd64/Makefile

--- 1.2 ---
6567634 generic x86 MCA support needs to be improved
2 lines changed: 0 ins; 0 del; 2 mod; 40 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/i86pc/modules/amd_opteron/ao.c

--- 1.3 ---
6567634 generic x86 MCA support needs to be improved
137 lines changed: 0 ins; 136 del; 1 mod; 387 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/i86pc/modules/amd_opteron/ia32/Makefile

--- 1.2 ---
6567634 generic x86 MCA support needs to be improved
2 lines changed: 0 ins; 0 del; 2 mod; 39 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mdb/i86pc/modules/generic_cpu/Makefile

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mdb/i86pc/modules/generic_cpu/amd64/Makefile

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mdb/i86pc/modules/generic_cpu/gcpu.c

186 lines changed: 186 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mdb/i86pc/modules/generic_cpu/ia32/Makefile

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/mc/mc-amd/mcamd_patounum.c

--- 1.4 ---
6567634 generic x86 MCA support needs to be improved
13 lines changed: 0 ins; 0 del; 13 mod; 707 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/mc/mc-amd/mcamd_rowcol.c

--- 1.3 ---
6567634 generic x86 MCA support needs to be improved
2 lines changed: 0 ins; 0 del; 2 mod; 665 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/mc/mc-amd/mcamd_rowcol_tbl.c

--- 1.4 ---
6567634 generic x86 MCA support needs to be improved
16 lines changed: 0 ins; 0 del; 16 mod; 902 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWcakr.i/prototype_com

--- 1.23 ---
6567634 generic x86 MCA support needs to be improved
7 lines changed: 4 ins; 0 del; 3 mod; 110 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWfmd/prototype_i386

--- 1.15 ---
6567634 generic x86 MCA support needs to be improved
2 lines changed: 1 ins; 0 del; 1 mod; 77 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWmdb/prototype_i386

--- 1.27 ---
6567634 generic x86 MCA support needs to be improved
5 lines changed: 2 ins; 0 del; 3 mod; 114 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWmdbr/prototype_i386

--- 1.15 ---
6567634 generic x86 MCA support needs to be improved
5 lines changed: 2 ins; 0 del; 3 mod; 97 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWonmtst.i/prototype_i386

--- 1.2 ---
6567634 generic x86 MCA support needs to be improved
3 lines changed: 2 ins; 0 del; 1 mod; 65 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/mem.c

--- 1.95 ---
6567634 generic x86 MCA support needs to be improved
3 lines changed: 0 ins; 0 del; 3 mod; 1209 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/kcpc.c

--- 1.18 ---
6567634 generic x86 MCA support needs to be improved
2 lines changed: 0 ins; 0 del; 2 mod; 1552 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/modctl.c

--- 1.217 ---
6567634 generic x86 MCA support needs to be improved
6475380 cmi_load() should unload unused CPU module

20 lines changed: 7 ins; 2 del; 11 mod; 4248 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/modctl.h

--- 1.113 ---
6567634 generic x86 MCA support needs to be improved
2 lines changed: 0 ins; 0 del; 2 mod; 664 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/Makefile.files

--- 1.149 ---
6567634 generic x86 MCA support needs to be improved
2 lines changed: 1 ins; 0 del; 1 mod; 218 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/Makefile.i86pc.shared

--- 1.18 ---
6567634 generic x86 MCA support needs to be improved
3 lines changed: 2 ins; 0 del; 1 mod; 306 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/Makefile.rules

--- 1.131 ---
6567634 generic x86 MCA support needs to be improved
11 lines changed: 2 ins; 0 del; 9 mod; 318 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/amd_opteron/Makefile

--- 1.4 ---
6567634 generic x86 MCA support needs to be improved
10 lines changed: 0 ins; 8 del; 2 mod; 103 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/i86pc/authenticamd/Makefile

90 lines changed: 90 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/cpu/Makefile.files

--- 1.2 ---
6567634 generic x86 MCA support needs to be improved
10 lines changed: 7 ins; 1 del; 2 mod; 34 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/cpu/amd_opteron/ao.h

--- 1.6 ---
6567634 generic x86 MCA support needs to be improved
186 lines changed: 41 ins; 101 del; 44 mod; 133 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/cpu/amd_opteron/ao_cpu.c

--- 1.5 ---
6567634 generic x86 MCA support needs to be improved
146 lines changed: 23 ins; 97 del; 26 mod; 118 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/cpu/amd_opteron/ao_main.c

--- 1.7 ---
6567634 generic x86 MCA support needs to be improved
72 lines changed: 11 ins; 24 del; 37 mod; 123 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/cpu/amd_opteron/ao_mca.c

--- 1.12 ---
6567634 generic x86 MCA support needs to be improved
728 lines changed: 88 ins; 421 del; 219 mod; 650 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/cpu/amd_opteron/ao_mca_disp.h

--- 1.3 ---
6567634 generic x86 MCA support needs to be improved
3 lines changed: 0 ins; 0 del; 3 mod; 64 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/cpu/amd_opteron/ao_mca_disp.in

--- 1.5 ---
6567634 generic x86 MCA support needs to be improved
131 lines changed: 50 ins; 0 del; 81 mod; 717 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/cpu/amd_opteron/ao_poll.c

--- 1.4 ---
6567634 generic x86 MCA support needs to be improved
229 lines changed: 5 ins; 202 del; 22 mod; 44 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/i86pc/cpu/authenticamd/authamd.h

112 lines changed: 112 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/i86pc/cpu/authenticamd/authamd_main.c

763 lines changed: 763 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/cpu/generic_cpu/gcpu.h

--- 1.2 ---
6567634 generic x86 MCA support needs to be improved
161 lines changed: 143 ins; 9 del; 9 mod; 54 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/cpu/generic_cpu/gcpu_main.c

--- 1.3 ---
6567634 generic x86 MCA support needs to be improved
79 lines changed: 45 ins; 3 del; 31 mod; 91 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/cpu/generic_cpu/gcpu_mca.c

--- 1.2 ---
6567634 generic x86 MCA support needs to be improved
1142 lines changed: 1018 ins; 24 del; 100 mod; 106 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/i86pc/cpu/generic_cpu/gcpu_poll.c

207 lines changed: 207 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/i86pc/cpu/genuineintel/gintel_main.c

87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/cpu/scripts/ao_gendisp.pl

--- 1.4 ---
6567634 generic x86 MCA support needs to be improved
34 lines changed: 10 ins; 0 del; 24 mod; 438 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/generic_cpu/Makefile

--- 1.2 ---
6567634 generic x86 MCA support needs to be improved
1 line changed: 0 ins; 0 del; 1 mod; 81 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/i86pc/genuineintel/Makefile

90 lines changed: 90 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/mc/mcamd.h

--- 1.7 ---
6567634 generic x86 MCA support needs to be improved
21 lines changed: 19 ins; 0 del; 2 mod; 225 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/mc/mcamd_dimmcfg.c

--- 1.3 ---
6567634 generic x86 MCA support needs to be improved
5 lines changed: 0 ins; 0 del; 5 mod; 467 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/mc/mcamd_drv.c

--- 1.10 ---
6567634 generic x86 MCA support needs to be improved
224 lines changed: 164 ins; 10 del; 50 mod; 1542 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/mc/mcamd_pcicfg.c

--- 1.4 ---
6567634 generic x86 MCA support needs to be improved
18 lines changed: 11 ins; 2 del; 5 mod; 94 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/mc/mcamd_pcicfg.h

--- 1.2 ---
6567634 generic x86 MCA support needs to be improved
2 lines changed: 1 ins; 0 del; 1 mod; 55 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/mc/mcamd_subr.c

--- 1.6 ---
6567634 generic x86 MCA support needs to be improved
56 lines changed: 37 ins; 12 del; 7 mod; 643 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/mc-amd/Makefile

--- 1.5 ---
6567634 generic x86 MCA support needs to be improved
9 lines changed: 0 ins; 8 del; 1 mod; 97 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/cmi.c

--- 1.6 ---
6567634 generic x86 MCA support needs to be improved
547 lines changed: 436 ins; 53 del; 58 mod; 234 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/i86pc/os/cms.c

545 lines changed: 545 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/cpuid.c

--- 1.34 ---
6567634 generic x86 MCA support needs to be improved
58 lines changed: 38 ins; 7 del; 13 mod; 3336 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/startup.c

--- 1.225 ---
6567634 generic x86 MCA support needs to be improved
2 lines changed: 0 ins; 0 del; 2 mod; 2659 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/sys/cpu_module.h

--- 1.5 ---
6567634 generic x86 MCA support needs to be improved
39 lines changed: 33 ins; 1 del; 5 mod; 64 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/sys/cpu_module_impl.h

--- 1.5 ---
6567634 generic x86 MCA support needs to be improved
33 lines changed: 16 ins; 9 del; 8 mod; 58 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/i86pc/sys/cpu_module_ms.h

121 lines changed: 121 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/i86pc/sys/cpu_module_ms_impl.h

71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/sys/machcpuvar.h

--- 1.52 ---
6567634 generic x86 MCA support needs to be improved
4 lines changed: 3 ins; 0 del; 1 mod; 141 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/fm/cpu/AMD.h

--- 1.3 ---
6567634 generic x86 MCA support needs to be improved
73 lines changed: 7 ins; 19 del; 47 mod; 171 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/intel/sys/fm/cpu/GCPU.h

201 lines changed: 201 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/intel/sys/fm/cpu/GENAMD.h

90 lines changed: 90 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/mc_amd.h

--- 1.6 ---
6567634 generic x86 MCA support needs to be improved
128 lines changed: 70 ins; 8 del; 50 mod; 680 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/mca_amd.h

--- 1.5 ---
6567634 generic x86 MCA support needs to be improved
84 lines changed: 7 ins; 59 del; 18 mod; 381 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/mca_x86.h

--- 1.2 ---
6567634 generic x86 MCA support needs to be improved
318 lines changed: 271 ins; 13 del; 34 mod; 79 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/memtest.h

--- 1.2 ---
6567634 generic x86 MCA support needs to be improved
16 lines changed: 14 ins; 0 del; 2 mod; 124 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/x86_archext.h

--- 1.45 ---
6567634 generic x86 MCA support needs to be improved
9 lines changed: 8 ins; 0 del; 1 mod; 631 unchg

------ ------ ------ ------ ------ --- New Patch Raw deleted_files/usr/src/uts/i86pc/cpu/amd_opteron/ao_mc.c (was deleted_files/usr/src/uts/i86pc/cpu/amd_opteron/ao_mc.c)

--- 1.2 ---
6491720 DC/IC/BU system infill only capture physical <39:6>
71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev (vers 2007/04/02). Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.