| Prepared by: | Garima Tripathi <Garima.Tripathi@Sun.COM> on Tue Jan 13 19:35:14 CST 2009 |
|---|---|
| Workspace: | /builds/gt145670/callback-rpc (at 92f0e685e71c) |
| Compare against: | ssh://aus1500-home//pool/ws/nfs41-clone (at 4041f54f1897) |
| Summary of changes: | 407 lines changed: 157 ins; 192 del; 58 mod; 22636 unchg |
| Patch of changes: | callback-rpc.patch |
| Printable review: | callback-rpc.pdf |
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs4_callback.c
Move CallBack Server thread creation, initial processing and destruction to RPC Cleanup some RPC code. Remove extraneous fields from nfs41_cb_info and clean up the code. Change KM_SLEEP in mir_nfs41_callback_thread to KM_NOSLEEP. Fix lint warnings155 lines changed: 1 ins; 149 del; 5 mod; 3203 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs4_subr.c
Move CallBack Server thread creation, initial processing and destruction to RPC Cleanup some RPC code. Remove extraneous fields from nfs41_cb_info and clean up the code. Change KM_SLEEP in mir_nfs41_callback_thread to KM_NOSLEEP. Fix lint warnings8 lines changed: 4 ins; 0 del; 4 mod; 4023 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs4_vfsops.c
Move CallBack Server thread creation, initial processing and destruction to RPC Cleanup some RPC code. Remove extraneous fields from nfs41_cb_info and clean up the code. Change KM_SLEEP in mir_nfs41_callback_thread to KM_NOSLEEP. Fix lint warnings Incorporate code review comments. Remove un-needed variable.14 lines changed: 6 ins; 6 del; 2 mod; 4451 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/nfs/nfs4_clnt.h
Move CallBack Server thread creation, initial processing and destruction to RPC Cleanup some RPC code. Remove extraneous fields from nfs41_cb_info and clean up the code. Change KM_SLEEP in mir_nfs41_callback_thread to KM_NOSLEEP. Fix lint warnings13 lines changed: 0 ins; 11 del; 2 mod; 2451 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/rpc/clnt_cots.c
Move CallBack Server thread creation, initial processing and destruction to RPC Cleanup some RPC code. Remove extraneous fields from nfs41_cb_info and clean up the code. Change KM_SLEEP in mir_nfs41_callback_thread to KM_NOSLEEP. Fix lint warnings10 lines changed: 0 ins; 1 del; 9 mod; 4194 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/rpc/rpcmod.c
Move CallBack Server thread creation, initial processing and destruction to RPC Cleanup some RPC code. Remove extraneous fields from nfs41_cb_info and clean up the code. Change KM_SLEEP in mir_nfs41_callback_thread to KM_NOSLEEP. Fix lint warnings Incorporate code review comments.197 lines changed: 139 ins; 24 del; 34 mod; 3165 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/rpc/svc.h
Move CallBack Server thread creation, initial processing and destruction to RPC Cleanup some RPC code. Remove extraneous fields from nfs41_cb_info and clean up the code. Change KM_SLEEP in mir_nfs41_callback_thread to KM_NOSLEEP. Fix lint warnings10 lines changed: 7 ins; 1 del; 2 mod; 1149 unchg
This code review page was prepared using /ws/onnv-tools/onbld/bin/webrev. Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.