Recently Published Codereviews 2010-01-27T18:32:34Z urn:uuid:d99fa050-ddf7-11dc-95ff-0800200c9a66 14038,14039,14133-pkgsend tag:cr.opensolaris.org,2010-01-25:~timf/14038,14039,14133-pkgsend/2010-01-25T20:25:23Z 2010-01-27T18:04:28Z Tim Foster
Tim Foster [timf's blog] posted a code review on 27 Jan 2010: 14038,14039,14133-pkgsend.
Tim Foster [timf's blog] posted a code review on 27 Jan 2010: 14038,14039,14133-pkgsend.

Code Review for 14038,14039,14133-pkgsend

Prepared by:Tim Foster tim.foster@sun.com on 2010-Jan-27 17:31 +0000 GMT
Workspace:/export/home/timf/projects/ips/14038-pkgsend-warn-unknown-pkg.hg (at af4d18d5bb29)
Compare against: /export/home/timf/projects/ips/pkg-gate.hg (at d09af96d5da9)
Summary of changes: 74 lines changed: 65 ins; 0 del; 9 mod; 1721 unchg 
14038 pkgsend can publish 'unknown' actions for pkginfo files
14039 subcommand in pkgsend include error incorrect
14133 pkgsend include only includes last manifest
 bug-12167 tag:cr.opensolaris.org,2010-01-27:~mattman/bug-12167/2010-01-27T17:32:52Z 2010-01-27T17:32:52Z Matt Keenan
Matt Keenan [mattman's blog] posted a code review on 27 Jan 2010: bug-12167.
Matt Keenan [mattman's blog] posted a code review on 27 Jan 2010: bug-12167.

Code Review for bug_12167

Prepared by:Matt Keenan matt.keenan@sun.com on 2010-Jan-27 17:27 +0000 GMT
Workspace:/export/home/caiman/bug_12167 (at f0203d0301fb)
Compare against: ssh://mattman@hg.opensolaris.org/hg/caiman/slim_source (at f1147878a249)
Summary of changes: 8 lines changed: 2 ins; 1 del; 5 mod; 826 unchg 
12167 GUI Installer Window Bar Icon Shows Up as Square Red X
 border_around_belist tag:cr.opensolaris.org,2010-01-27:~migi/border_around_belist/2010-01-27T17:09:52Z 2010-01-27T17:09:52Z Michal Pryc
Michal Pryc [migi's blog] posted a code review on 27 Jan 2010: border_around_belist.
Michal Pryc [migi's blog] posted a code review on 27 Jan 2010: border_around_belist.

Code Review for GATE

Prepared by:Michal Pryc Michal.Pryc@Sun.Com on 2010-Jan-27 17:05 +0000 GMT
Workspace:/export/home/migi/Development/GATE (at 36542108f3a7)
Compare against: ssh://migi@hg.opensolaris.org/hg/pkg/gate (at 36542108f3a7)
Summary of changes: 24 lines changed: 14 ins; 1 del; 9 mod; 6318 unchg 
no comments found
 bug-14077 tag:cr.opensolaris.org,2010-01-27:~chonan/bug-14077/2010-01-27T16:08:43Z 2010-01-27T16:08:43Z Hiroshi Chonan
Hiroshi Chonan [chonan's blog] posted a code review on 27 Jan 2010: bug-14077.
Hiroshi Chonan [chonan's blog] posted a code review on 27 Jan 2010: bug-14077.

Code Review for bug-14077

Prepared by:Hiroshi Chonan (chonan) on 2010-Jan-28 01:08 +0900 JST
Workspace:/export/home/chonan/OpenSolaris/bug-14077 (at 2e0ee3a77aa5)
Compare against: /export/home/chonan/OpenSolaris/onnv-gate (at 24344dea001d)
Summary of changes: 60 lines changed: 60 ins; 0 del; 0 mod; 6157 unchg 
EHCI QH and QTD pool sizes are now configurable in ehci.conf
 ips-14186-v1 tag:cr.opensolaris.org,2010-01-27:~padraig/ips-14186-v1/2010-01-27T14:24:47Z 2010-01-27T14:24:47Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 27 Jan 2010: ips-14186-v1.
Padraig O\'Briain [padraig] posted a code review on 27 Jan 2010: ips-14186-v1.

Code Review for 14186_gate

Prepared by:Padraig O'Briain padraig.obriain@sun.com on 2010-Jan-27 14:17 +0000 GMT
Workspace:/export/home/padraig/14186_gate (at 36542108f3a7)
Compare against: /export/home/padraig/gate (at 36542108f3a7)
Summary of changes: 28 lines changed: 15 ins; 11 del; 2 mod; 5976 unchg 
no comments found
 bug-12364 tag:cr.opensolaris.org,2010-01-27:~mattman/bug-12364/2010-01-27T14:22:06Z 2010-01-27T14:22:06Z Matt Keenan
Matt Keenan [mattman's blog] posted a code review on 27 Jan 2010: bug-12364.
Matt Keenan [mattman's blog] posted a code review on 27 Jan 2010: bug-12364.

Code Review for bug_12364

Prepared by:Matt Keenan matt.keenan@sun.com on 2010-Jan-27 14:16 +0000 GMT
Workspace:/export/home/caiman/bug_12364 (at 5e9583cd2388)
Compare against: ssh://mattman@hg.opensolaris.org/hg/caiman/slim_source (at f1147878a249)
Summary of changes: 9 lines changed: 4 ins; 0 del; 5 mod; 1003 unchg 
12364 Doing livecd install had complains about GUI:Gtk_E Oct 28 23:13:41 file gtkprogress.c: line 540: assertion percentage = 0  percentage = 1.0 failed
 gate tag:cr.opensolaris.org,2010-01-27:~garypen/gate/2010-01-27T12:18:00Z 2010-01-27T12:18:00Z Gary Pennington
Gary Pennington [garypen's blog] posted a code review on 27 Jan 2010: gate.
Gary Pennington [garypen's blog] posted a code review on 27 Jan 2010: gate.

Code Review for gate

Prepared by:Gary Pennington gary.pennington@sun.com on 2010-Jan-27 04:17 -0800 PST
Workspace:/builds/garypen/HG/pkg/gate (at f65705e2d98a)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at ce69ab869838)
Summary of changes: 179 lines changed: 140 ins; 10 del; 29 mod; 4408 unchg 
12738 zone install/attach incorporation logic needs enhancement
14053 pkg brand creation potentially broken with new publisher data
 onips_dep-2 tag:cr.opensolaris.org,2010-01-27:~lianep/onips_dep-2/2010-01-27T12:02:36Z 2010-01-27T12:02:36Z Liane Praza
Liane Praza [lianep's blog] posted a code review on 27 Jan 2010: onips_dep-2.
Liane Praza [lianep's blog] posted a code review on 27 Jan 2010: onips_dep-2.

Code Review for onips_dep

Prepared by:Liane Praza Liane.Praza@Sun.COM on 2010-Jan-27 03:57 -0800 PST
Workspace:/local/ws/onips_dep (at 1f2fb9b64c38)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/on_ips (at 7ef31a6af14c)
Summary of changes: 1001 lines changed: 97 ins; 573 del; 331 mod; 38303 unchg 
11123 need ips package dependencies
Explicit make dependencies.
merge
 13440_v1 tag:cr.opensolaris.org,2010-01-27:~migi/13440_v1/2010-01-27T11:44:33Z 2010-01-27T11:44:33Z Michal Pryc
Michal Pryc [migi's blog] posted a code review on 27 Jan 2010: 13440_v1.
Michal Pryc [migi's blog] posted a code review on 27 Jan 2010: 13440_v1.

Code Review for takeshi_webpage_updated

Prepared by:Michal Pryc Michal.Pryc@Sun.Com on 2010-Jan-27 11:43 +0000 GMT
Workspace:/export/home/migi/Development/takeshi_webpage_updated (at 2588129cb9c6)
Compare against: /export/home/migi/Development/takeshi_webpage (at 2588129cb9c6)
Summary of changes: 432 lines changed: 0 ins; 0 del; 432 mod; 6677 unchg 
no comments found
 ips-14003-v6 tag:cr.opensolaris.org,2010-01-27:~padraig/ips-14003-v6/2010-01-27T11:06:48Z 2010-01-27T11:06:48Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 27 Jan 2010: ips-14003-v6.
Padraig O\'Briain [padraig] posted a code review on 27 Jan 2010: ips-14003-v6.

Code Review for 14003_clone

Prepared by:Padraig O'Briain padraig.obriain@sun.com on 2010-Jan-27 10:27 +0000 GMT
Workspace:/export/home/padraig/14003_clone (at ce69ab869838)
Compare against: /export/home/padraig/gate (at ce69ab869838)
Summary of changes: 141 lines changed: 86 ins; 6 del; 49 mod; 6528 unchg 
no comments found
 14188_updates_dialog_title_27Jan_935am tag:cr.opensolaris.org,2010-01-27:~jmr/14188_updates_dialog_title_27Jan_935am/2010-01-27T09:36:36Z 2010-01-27T09:36:36Z John Rice
John Rice [jmr's blog] posted a code review on 27 Jan 2010: 14188_updates_dialog_title_27Jan_935am.
John Rice [jmr's blog] posted a code review on 27 Jan 2010: 14188_updates_dialog_title_27Jan_935am.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-27 09:36 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at ce69ab869838)
Compare against: /export/home/jr140578/work/ips_gate_clean (at ce69ab869838)
Summary of changes: 8 lines changed: 5 ins; 0 del; 3 mod; 1239 unchg 
no comments found
 14188_updates_dialog_title_27Jan_920am tag:cr.opensolaris.org,2010-01-27:~jmr/14188_updates_dialog_title_27Jan_920am/2010-01-27T09:19:14Z 2010-01-27T09:19:14Z John Rice
John Rice [jmr's blog] posted a code review on 27 Jan 2010: 14188_updates_dialog_title_27Jan_920am.
John Rice [jmr's blog] posted a code review on 27 Jan 2010: 14188_updates_dialog_title_27Jan_920am.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-27 09:16 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at ce69ab869838)
Compare against: /export/home/jr140578/work/ips_gate_clean (at ce69ab869838)
Summary of changes: 4 lines changed: 3 ins; 0 del; 1 mod; 1241 unchg 
no comments found
 6918313 tag:cr.opensolaris.org,2010-01-27:~sunandam/6918313/2010-01-27T05:55:08Z 2010-01-27T05:55:08Z Sunanda Menon
Sunanda Menon [sunandam] posted a code review on 27 Jan 2010: 6918313.
Sunanda Menon [sunandam] posted a code review on 27 Jan 2010: 6918313.

Code Review for 6918313

Prepared by:Sunanda Menon (sm156471) on 2010-Jan-26 21:55 -0800 PST
Workspace:/builds2/sunanda/6918313
Compare against: /ws/sfwnv-clone
Summary of changes: 201 lines changed: 200 ins; 0 del; 1 mod; 205 unchg 
6918313 [OSOL B131] Crash of Mysql server SSL connection security problem (5.1.30)(x86 only)
 0000017_block_inode_bitmaps_diferences_after_open_02 tag:cr.opensolaris.org,2010-01-27:~senoltj/0000017_block_inode_bitmaps_diferences_after_open_02/2010-01-27T05:50:58Z 2010-01-27T05:50:58Z Jan Senolt
Jan Senolt [senoltj] posted a code review on 27 Jan 2010: 0000017_block_inode_bitmaps_diferences_after_open_02.
Jan Senolt [senoltj] posted a code review on 27 Jan 2010: 0000017_block_inode_bitmaps_diferences_after_open_02.

Code Review for ext2-gate

Prepared by:senoltj@opensolaris.org on Tue Jan 26 22:20:00 CET 2010
Workspace:/export/home/honza/projects/ext2/ws-open2/ext2-gate (at d977342e3206)
Compare against: ssh://senoltj@hg.opensolaris.org/hg/ext3/ext2-gate (at d977342e3206)
Summary of changes: 113 lines changed: 60 ins; 15 del; 38 mod; 2833 unchg 
no comments found
 ips-14118-v1 tag:cr.opensolaris.org,2010-01-27:~bpytlik/ips-14118-v1/2010-01-27T04:20:03Z 2010-01-27T04:20:03Z Brock Pytlik
Brock Pytlik [bpytlik] posted a code review on 27 Jan 2010: ips-14118-v1.
Brock Pytlik [bpytlik] posted a code review on 27 Jan 2010: ips-14118-v1.

Code Review for recommit.bug-14118-v1

Prepared by:Brock Pytlik bpytlik@sun.com on 2010-Jan-26 20:20 -0800 PST
Workspace:/export/home/bpytlik/IPS/recommit.bug-14118-v1 (at b301d8ca9a2c)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at ce69ab869838)
Summary of changes: 240 lines changed: 226 ins; 7 del; 7 mod; 3569 unchg 
14118 pkgdepend resolve results in repeated dependencies
 pkg-lock-6-full tag:cr.opensolaris.org,2010-01-27:~swalker/pkg-lock-6-full/2010-01-27T03:40:18Z 2010-01-27T03:40:18Z Shawn Walker
Shawn Walker [swalker's blog] posted a code review on 27 Jan 2010: pkg-lock-6-full.
Shawn Walker [swalker's blog] posted a code review on 27 Jan 2010: pkg-lock-6-full.

Code Review for pkg-lock-6

Prepared by:Shawn Walker srw@sun.com on 2010-Jan-26 21:40 -0600 CST
Workspace:/export/home/swalker/devel/pkg-lock-6 (at 51d3a60a1dd7)
Compare against: /export/home/swalker/devel/pkg-tip (at d41d1e47198d)
Summary of changes: 804 lines changed: 634 ins; 72 del; 98 mod; 22406 unchg 
1668 image locking needed to prevent race conditions
review fixes round 1.2
review fixes round 1.3
review fixes round 1.5
added image state check
14182 catalog update_entry method doesn't set last_modified
review fixes round 1.1
review fixes round 1.4
Added missing unit test (didn't get added).
 pkg-lock-6 tag:cr.opensolaris.org,2010-01-27:~swalker/pkg-lock-6/2010-01-27T03:38:42Z 2010-01-27T03:38:42Z Shawn Walker
Shawn Walker [swalker's blog] posted a code review on 27 Jan 2010: pkg-lock-6.
Shawn Walker [swalker's blog] posted a code review on 27 Jan 2010: pkg-lock-6.

Code Review for pkg-lock-6

Prepared by:Shawn Walker srw@sun.com on 2010-Jan-26 21:38 -0600 CST
Workspace:/export/home/swalker/devel/pkg-lock-6 (at 51d3a60a1dd7)
Compare against: /export/home/swalker/devel/pkg-lock-5 (at 814714d8b284)
Summary of changes: 192 lines changed: 177 ins; 5 del; 10 mod; 16483 unchg 
review fixes round 1.5
added image state check
14182 catalog update_entry method doesn't set last_modified
 pkg-14150-v2 tag:cr.opensolaris.org,2010-01-27:~asano/pkg-14150-v2/2010-01-27T02:17:32Z 2010-01-27T02:17:32Z Takeshi Asano
Takeshi Asano [asano] posted a code review on 27 Jan 2010: pkg-14150-v2.
Takeshi Asano [asano] posted a code review on 27 Jan 2010: pkg-14150-v2.

Code Review for pkg-14150-v2

Prepared by:asano on 2010-Jan-27 10:54 +0900 JST
Workspace:/home/asano/wslocal/pkg-gate2 (at ce69ab869838)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at ce69ab869838)
Summary of changes: 132416 lines changed: 60850 ins; 37677 del; 33889 mod; 60754 unchg 
no comments found
 webrev.14082.13766.4069 tag:cr.opensolaris.org,2010-01-26:~equach/webrev.14082.13766.4069/2010-01-26T17:21:02Z 2010-01-27T01:50:22Z Ethan Quach
Ethan Quach [equach] posted a code review on 27 Jan 2010: webrev.14082.13766.4069.
Ethan Quach [equach] posted a code review on 27 Jan 2010: webrev.14082.13766.4069.

Code Review for ss

Prepared by:Ethan Quach Ethan.Quach@sun.com on 2010-Jan-26 17:50 -0800 PST
Workspace:/export/ws/ss (at 0db35ab7d09d)
Compare against: ssh://equach@hg.opensolaris.org/hg/caiman/slim_source (at e33dee6b3d42)
Summary of changes: 360 lines changed: 220 ins; 40 del; 100 mod; 3892 unchg 
14082 bootarg for booting automated installs over the network
13766 AI debug mode can only be activated in conjunction with service discovery
4069 The create-service setup doesn't work if a client is booted using a tip line
 13123-tftpboot tag:cr.opensolaris.org,2010-01-27:~johnfisc/13123-tftpboot/2010-01-27T00:41:55Z 2010-01-27T00:41:55Z John Fischer
John Fischer [johnfisc] posted a code review on 27 Jan 2010: 13123-tftpboot.
John Fischer [johnfisc] posted a code review on 27 Jan 2010: 13123-tftpboot.

Code Review for slim_source-tftpboot

Prepared by:John Fischer John.Fischer@Sun.COM on 2010-Jan-26 16:41 -0800 PST
Workspace:/tmp/slim_source-tftpboot (at e33dee6b3d42)
Compare against: ssh://johnfisc@hg.opensolaris.org/hg/caiman/slim_source (at e33dee6b3d42)
Summary of changes: 68 lines changed: 16 ins; 19 del; 33 mod; 877 unchg 
13123 installadm needs to reference SMF for tftp's base directory, not inetd.conf
 webrev.onnv_132 tag:cr.opensolaris.org,2010-01-26:~mjnelson/webrev.onnv_132/2010-01-26T19:28:40Z 2010-01-26T19:28:40Z Mark J. Nelson
Mark J. Nelson [mjnelson's blog] posted a code review on 26 Jan 2010: webrev.onnv_132.
Mark J. Nelson [mjnelson's blog] posted a code review on 26 Jan 2010: webrev.onnv_132.

Code Review for webrev.onnv_132

Prepared by:Mark J. Nelson Mark.J.Nelson@Sun.COM on 2010-Jan-26 12:24 -0700 MST
Workspace:/net/opensores/export/ws/mjnelson/on-ips-work (at f578ca104f38)
Compare against: ssh://anon@hg.opensolaris.org//hg/pkg/on_ips/ (at 10a7b32a14e5)
Summary of changes: 1079 lines changed: 780 ins; 159 del; 140 mod; 21881 unchg 
Sync with nightly 2010-01-20 (onnv_132, onnv-gate changeset 640c39cb2d82)
12660  SUNWcryptoint dependencies shouldn't be there for gatekeeper builds
6855745 wrong group ownership of files in /etc/security
6857150 policy.conf should refer to pfexec(1) instead of pfexec(1m)
6912488 Incorrect TEXT_DOMAIN binding
6855998 put signed crypto in its own tarball, not with the closed bins
6590779 bindrop cleanup: remove grfans, i2c_svc
6590785 bindrop: grppm is okay
6597124 bindrop: dis is now open
6702310 bindrop should not blacklist pcn(7D)
 + 10 more lines...
 onips_dep_1 tag:cr.opensolaris.org,2010-01-26:~lianep/onips_dep_1/2010-01-26T16:32:10Z 2010-01-26T16:32:10Z Liane Praza
Liane Praza [lianep's blog] posted a code review on 26 Jan 2010: onips_dep_1.
Liane Praza [lianep's blog] posted a code review on 26 Jan 2010: onips_dep_1.

Code Review for onips_dep

Prepared by:Liane Praza Liane.Praza@Sun.COM on 2010-Jan-26 08:29 -0800 PST
Workspace:/local/ws/onips_dep (at 10a7b32a14e5)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/on_ips (at 10a7b32a14e5)
Summary of changes: 987 lines changed: 85 ins; 572 del; 330 mod; 38228 unchg 
no comments found
 14151_subcat_names_l10n_issue_26Jan_330pm tag:cr.opensolaris.org,2010-01-26:~jmr/14151_subcat_names_l10n_issue_26Jan_330pm/2010-01-26T15:29:07Z 2010-01-26T15:29:07Z John Rice
John Rice [jmr's blog] posted a code review on 26 Jan 2010: 14151_subcat_names_l10n_issue_26Jan_330pm.
John Rice [jmr's blog] posted a code review on 26 Jan 2010: 14151_subcat_names_l10n_issue_26Jan_330pm.

Code Review for 14151_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-26 15:28 +0000 GMT
Workspace:/export/home/jr140578/work/14151_gate (at 3f3629415885)
Compare against: /export/home/jr140578/work/ips_gate_clean (at 3f3629415885)
Summary of changes: 3 lines changed: 2 ins; 0 del; 1 mod; 5923 unchg 
no comments found
 test_webrev.0 tag:cr.opensolaris.org,2010-01-21:~swilcox/test_webrev.0/2010-01-21T00:25:34Z 2010-01-26T15:07:06Z Sean D. Wilcox
Sean D. Wilcox [swilcox] posted a code review on 26 Jan 2010: test_webrev.0.
Sean D. Wilcox [swilcox] posted a code review on 26 Jan 2010: test_webrev.0.

Code Review for webrev.0

Prepared by:Sean Wilcox Sean.Wilcox@Sun.COM on 2010-Jan-26 07:07 -0800 PST
Workspace:/builds/swilcox/EMI_smf_testsuite_hg (at 8d0c0ca056f8)
Compare against: /ws/stcnv-clone (at c0a4209657e0)
Summary of changes: 4707 lines changed: 4696 ins; 4 del; 7 mod; 663 unchg 
simple manifest deletion fixes
 ips-14003-v5 tag:cr.opensolaris.org,2010-01-26:~padraig/ips-14003-v5/2010-01-26T15:01:00Z 2010-01-26T15:01:00Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 26 Jan 2010: ips-14003-v5.
Padraig O\'Briain [padraig] posted a code review on 26 Jan 2010: ips-14003-v5.

Code Review for 14003_gate

Prepared by:Padraig O'Briain padraig.obriain@sun.com on 2010-Jan-26 14:57 +0000 GMT
Workspace:/export/home/padraig/14003_gate (at d09af96d5da9)
Compare against: /export/home/padraig/gate (at d09af96d5da9)
Summary of changes: 128 lines changed: 75 ins; 6 del; 47 mod; 6532 unchg 
no comments found
 14152_subcat_names_l10n_issue_26Jan_240pm tag:cr.opensolaris.org,2010-01-26:~jmr/14152_subcat_names_l10n_issue_26Jan_240pm/2010-01-26T14:39:44Z 2010-01-26T14:39:44Z John Rice
John Rice [jmr's blog] posted a code review on 26 Jan 2010: 14152_subcat_names_l10n_issue_26Jan_240pm.
John Rice [jmr's blog] posted a code review on 26 Jan 2010: 14152_subcat_names_l10n_issue_26Jan_240pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-26 14:36 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at d09af96d5da9)
Compare against: /export/home/jr140578/work/ips_gate_clean (at d09af96d5da9)
Summary of changes: 7 lines changed: 0 ins; 4 del; 3 mod; 5917 unchg 
no comments found
 14151_information_pages_l10n_issue_26Jan_125pm tag:cr.opensolaris.org,2010-01-26:~jmr/14151_information_pages_l10n_issue_26Jan_125pm/2010-01-26T13:26:04Z 2010-01-26T13:26:04Z John Rice
John Rice [jmr's blog] posted a code review on 26 Jan 2010: 14151_information_pages_l10n_issue_26Jan_125pm.
John Rice [jmr's blog] posted a code review on 26 Jan 2010: 14151_information_pages_l10n_issue_26Jan_125pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-26 13:24 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at d09af96d5da9)
Compare against: /export/home/jr140578/work/ips_gate_clean (at d09af96d5da9)
Summary of changes: 9 lines changed: 3 ins; 0 del; 6 mod; 5918 unchg 
no comments found
 14151_information_pages_l10n_issue_26Jan_120pm tag:cr.opensolaris.org,2010-01-26:~jmr/14151_information_pages_l10n_issue_26Jan_120pm/2010-01-26T13:22:35Z 2010-01-26T13:22:35Z John Rice
John Rice [jmr's blog] posted a code review on 26 Jan 2010: 14151_information_pages_l10n_issue_26Jan_120pm.
John Rice [jmr's blog] posted a code review on 26 Jan 2010: 14151_information_pages_l10n_issue_26Jan_120pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-26 13:20 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at d09af96d5da9)
Compare against: /export/home/jr140578/work/ips_gate_clean (at d09af96d5da9)
Summary of changes: 10 lines changed: 3 ins; 0 del; 7 mod; 5917 unchg 
no comments found
 14152_subcat_l10n_missing_26Jan_1220pm tag:cr.opensolaris.org,2010-01-26:~jmr/14152_subcat_l10n_missing_26Jan_1220pm/2010-01-26T12:22:18Z 2010-01-26T12:22:18Z John Rice
John Rice [jmr's blog] posted a code review on 26 Jan 2010: 14152_subcat_l10n_missing_26Jan_1220pm.
John Rice [jmr's blog] posted a code review on 26 Jan 2010: 14152_subcat_l10n_missing_26Jan_1220pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-26 12:21 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at d09af96d5da9)
Compare against: /export/home/jr140578/work/ips_gate_clean (at d09af96d5da9)
Summary of changes: 3 lines changed: 0 ins; 1 del; 2 mod; 5921 unchg 
no comments found
 ips-14003-v4 tag:cr.opensolaris.org,2010-01-26:~padraig/ips-14003-v4/2010-01-26T12:19:37Z 2010-01-26T12:19:37Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 26 Jan 2010: ips-14003-v4.
Padraig O\'Briain [padraig] posted a code review on 26 Jan 2010: ips-14003-v4.

Code Review for 14003_gate

Prepared by:Padraig O'Briain padraig.obriain@sun.com on 2010-Jan-26 12:17 +0000 GMT
Workspace:/export/home/padraig/14003_gate (at d09af96d5da9)
Compare against: /export/home/padraig/gate (at d09af96d5da9)
Summary of changes: 126 lines changed: 74 ins; 6 del; 46 mod; 6533 unchg 
no comments found
 13036_persist_cat_act_exp_followon_26Jun_10am tag:cr.opensolaris.org,2010-01-26:~jmr/13036_persist_cat_act_exp_followon_26Jun_10am/2010-01-26T09:57:44Z 2010-01-26T09:57:44Z John Rice
John Rice [jmr's blog] posted a code review on 26 Jan 2010: 13036_persist_cat_act_exp_followon_26Jun_10am.
John Rice [jmr's blog] posted a code review on 26 Jan 2010: 13036_persist_cat_act_exp_followon_26Jun_10am.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-26 09:56 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at d09af96d5da9)
Compare against: /export/home/jr140578/work/ips_gate_clean (at d09af96d5da9)
Summary of changes: 3 lines changed: 2 ins; 0 del; 1 mod; 176 unchg 
no comments found
 ips-14003-v3 tag:cr.opensolaris.org,2010-01-26:~padraig/ips-14003-v3/2010-01-26T08:40:47Z 2010-01-26T08:40:47Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 26 Jan 2010: ips-14003-v3.
Padraig O\'Briain [padraig] posted a code review on 26 Jan 2010: ips-14003-v3.

Code Review for 14003_clone

Prepared by:Padraig O'Briain padraig.obriain@sun.com on 2010-Jan-26 08:38 +0000 GMT
Workspace:/export/home/padraig/14003_clone (at 51f832187af7)
Compare against: /export/home/padraig/gate (at 51f832187af7)
Summary of changes: 116 lines changed: 66 ins; 6 del; 44 mod; 6514 unchg 
no comments found
 pkg-14150-v1 tag:cr.opensolaris.org,2010-01-26:~asano/pkg-14150-v1/2010-01-26T06:44:46Z 2010-01-26T06:44:46Z Takeshi Asano
Takeshi Asano [asano] posted a code review on 26 Jan 2010: pkg-14150-v1.
Takeshi Asano [asano] posted a code review on 26 Jan 2010: pkg-14150-v1.

Code Review for pkg-14150-v1

Prepared by:asano on 2010-Jan-26 15:26 +0900 JST
Workspace:/home/asano/wslocal/pkg-gate2 (at d09af96d5da9)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at d09af96d5da9)
Summary of changes: 132414 lines changed: 60849 ins; 37677 del; 33888 mod; 60755 unchg 
no comments found
 expcbe tag:cr.opensolaris.org,2010-01-26:~kuriakos/expcbe/2010-01-26T04:20:26Z 2010-01-26T04:20:26Z Kuriakose Kuruvilla
Kuriakose Kuruvilla [kuriakos] posted a code review on 26 Jan 2010: expcbe.
Kuriakose Kuruvilla [kuriakos] posted a code review on 26 Jan 2010: expcbe.

Code Review for expcbe

Prepared by:Kuriakose Kuruvilla Kuriakose.Kuruvilla@Sun.COM on 2010-Jan-25 20:17 -0800 PST
Workspace:/export/kk208521/expcbe (at 4f7cd4f89b9a)
Compare against: ssh://anonhg@onnv.sfbay.sun.com//export/onnv-clone (at 640c39cb2d82)
Summary of changes: 36 lines changed: 23 ins; 0 del; 13 mod; 2172 unchg 
6875283 Update PCBE implementation for new Intel processors
 13248 tag:cr.opensolaris.org,2010-01-26:~barts/13248/2010-01-26T03:43:31Z 2010-01-26T03:43:31Z Bart Smaalders
Bart Smaalders [barts's blog] posted a code review on 26 Jan 2010: 13248.
Bart Smaalders [barts's blog] posted a code review on 26 Jan 2010: 13248.

Code Review for pkg-bugs

Prepared by:Bart Smaalders Bart.Smaalders@Sun.COM on 2010-Jan-25 19:43 -0800 PST
Workspace:/home/barts/ws/pkg-bugs (at c60493e44657)
Compare against: ssh://barts@hg.opensolaris.org/hg/pkg/gate (at d09af96d5da9)
Summary of changes: 18 lines changed: 11 ins; 0 del; 7 mod; 1216 unchg 
13248 client should not send intent for disabled publishers
 webrev-3720-4 tag:cr.opensolaris.org,2010-01-26:~johansen/webrev-3720-4/2010-01-26T01:36:43Z 2010-01-26T01:36:43Z johansen
johansen [johansen] posted a code review on 26 Jan 2010: webrev-3720-4.
johansen [johansen] posted a code review on 26 Jan 2010: webrev-3720-4.

Code Review for pkg-bugs

Prepared by:johansen on 2010-Jan-25 17:36 -0800 PST
Workspace:/home/johansen/hg_ws/pkg-bugs (at 577d2b4eac76)
Compare against: ssh://johansen@opensolaris.org/hg/pkg/gate (at d09af96d5da9)
Summary of changes: 162 lines changed: 107 ins; 37 del; 18 mod; 3567 unchg 
3720 Race condition exists for cancelation using the API
13925 installs slow down towards the end
14049 Classes that handle RLock have trouble with NRLock
 pkg-consolidate tag:cr.opensolaris.org,2010-01-26:~dduvall/pkg-consolidate/2010-01-26T00:19:27Z 2010-01-26T00:19:27Z Danek Duvall
Danek Duvall [dduvall] posted a code review on 26 Jan 2010: pkg-consolidate.
Danek Duvall [dduvall] posted a code review on 26 Jan 2010: pkg-consolidate.

Code Review for pkg-consolidate

Prepared by:Danek Duvall danek.duvall@sun.com on 2010-Jan-25 16:19 -0800 PST
Workspace:/export/home/dduvall/packaging/pkg-pbranch-together (at 7c0ba33cefd2)
Compare against: ssh://dduvall@hg.opensolaris.org/hg/pkg/gate (at d09af96d5da9)
Summary of changes: 355 lines changed: 279 ins; 9 del; 67 mod; 9428 unchg 
start new patch on default
merge of default
Introduce Action.globally_unique; get rid of the XXX comment.
add testcase and an implementation for files marked with original_name
Add support for name-based-only file preservation, plus a testcase.
This may not be as optimized as it could be.
Get the broader case working, if possibly slowly.
Use namedtuples to make the code more readable (hopefully).
Try to be a bit quicker about the consolidation.
Make sure ActionPlan objects are always used instead of raw tuples.
 + 12 more lines...
 webrev.14055 tag:cr.opensolaris.org,2010-01-23:~mjnelson/webrev.14055/2010-01-23T23:19:22Z 2010-01-25T23:53:40Z Mark J. Nelson
Mark J. Nelson [mjnelson's blog] posted a code review on 25 Jan 2010: webrev.14055.
Mark J. Nelson [mjnelson's blog] posted a code review on 25 Jan 2010: webrev.14055.

Code Review for webrev.14055

Prepared by:Mark J. Nelson Mark.J.Nelson@Sun.COM on 2010-Jan-25 16:47 -0700 MST
Workspace:/net/opensores.central/export/ws/mjnelson/on-ips-work (at 1f1d724f4e36)
Compare against: webrev at parent.fake
Summary of changes: 170 lines changed: 138 ins; 5 del; 27 mod; 2575 unchg 
14109 separate build number from usr/src/pkg/Makefile
14055 PKGPUBLISHER settings should probably move to Makefile.master
14105 indirect dependency leading to partial publication during incremental build
14134 package lists should be limited to $PKGS
 ikev2-gate tag:cr.opensolaris.org,2010-01-04:~danmcd/ikev2-gate/2010-01-04T16:05:02Z 2010-01-25T20:07:28Z Dan McDonald
Dan McDonald [danmcd's blog] posted a code review on 25 Jan 2010: ikev2-gate.
Dan McDonald [danmcd's blog] posted a code review on 25 Jan 2010: ikev2-gate.

Code Review for ikev2-gate

Prepared by:Dan McDonald danmcd@sun.com on 2010-Jan-25 14:52 -0500 EST
Workspace:/net/zhadum.east/export/ws/ikev2/ikev2-gate (at be215af519f9)
Compare against: /net/zhadum.east/export/clones/onnv (at b23c42c0c9d6)
Summary of changes: 8149 lines changed: 8077 ins; 2 del; 70 mod; 10286 unchg 
Added tag ikev2_132 for changeset 03405444cfca
More thread control, using signals to test it.  ISAKMP version checking.
Merge with onnv
Initial IKEv2 SA support, initial packet support, and some hg nits cleanup
IKEv2 gate bringup (2nd try).
Update copyrights to 2010, test HG hooks.
Removing build noise.
Introductory IKE SA structures, plus another ikev2-gate notification test.
Some additional IKE SA fields.
Removed racoon2's isakmp.h.
 + 16 more lines...
 10888 tag:cr.opensolaris.org,2010-01-25:~clayb/10888/2010-01-25T19:57:39Z 2010-01-25T19:57:39Z Clay Baenziger
Clay Baenziger [clayb] posted a code review on 25 Jan 2010: 10888.
Clay Baenziger [clayb] posted a code review on 25 Jan 2010: 10888.

Code Review for slim_source.10888

Prepared by:Clay Baenziger ClayB@OpenSolaris.ORG on 2010-Jan-25 12:57 -0700 MST
Workspace:/export/backup/hg_workspaces/slim_source.10888 (at e33dee6b3d42)
Compare against: ssh://clayb@hg.opensolaris.org/hg/caiman/slim_source (at b9e20f47cf31)
Summary of changes: 16 lines changed: 13 ins; 0 del; 3 mod; 333 unchg 
10888 creating an x86 install services fails due to dns/multicast service dependency
 10748-webrev tag:cr.opensolaris.org,2010-01-19:~timf/10748-webrev/2010-01-19T15:40:01Z 2010-01-25T15:44:21Z Tim Foster
Tim Foster [timf's blog] posted a code review on 25 Jan 2010: 10748-webrev.
Tim Foster [timf's blog] posted a code review on 25 Jan 2010: 10748-webrev.

Code Review for 10748-webrev

Prepared by:Tim Foster tim.foster@sun.com on 2010-Jan-25 15:31 +0000 GMT
Workspace:/export/home/timf/projects/ips/10748-unbundleds-pkg.hg (at e9a6ff94f7f9)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 51f832187af7)
Summary of changes: 25 lines changed: 15 ins; 5 del; 5 mod; 2360 unchg 
10748 importer.py cannot build unbundled products against older releases.
 bug-2822 tag:cr.opensolaris.org,2010-01-25:~mattman/bug-2822/2010-01-25T15:41:38Z 2010-01-25T15:41:38Z Matt Keenan
Matt Keenan [mattman's blog] posted a code review on 25 Jan 2010: bug-2822.
Matt Keenan [mattman's blog] posted a code review on 25 Jan 2010: bug-2822.

Code Review for bug_2822

Prepared by:Matt Keenan matt.keenan@sun.com on 2010-Jan-25 15:37 +0000 UTC
Workspace:/export/home/caiman/bug_2822 (at b9e20f47cf31)
Compare against: ssh://mattman@hg.opensolaris.org/hg/caiman/slim_source (at 3abf7ed68509)
Summary of changes: 60 lines changed: 55 ins; 2 del; 3 mod; 6369 unchg 
2822 GUI should display warning message, if disk/partition size is less than recommended
 13036_persist_cat_act_exp_25Jun_1230pm tag:cr.opensolaris.org,2010-01-25:~jmr/13036_persist_cat_act_exp_25Jun_1230pm/2010-01-25T12:29:04Z 2010-01-25T12:29:04Z John Rice
John Rice [jmr's blog] posted a code review on 25 Jan 2010: 13036_persist_cat_act_exp_25Jun_1230pm.
John Rice [jmr's blog] posted a code review on 25 Jan 2010: 13036_persist_cat_act_exp_25Jun_1230pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-25 12:28 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at f9b304e6d6d7)
Compare against: /export/home/jr140578/work/ips_gate_clean (at f9b304e6d6d7)
Summary of changes: 150 lines changed: 114 ins; 0 del; 36 mod; 6084 unchg 
no comments found
 13036_persist_cat_act_exp_25Jun_1220pm tag:cr.opensolaris.org,2010-01-25:~jmr/13036_persist_cat_act_exp_25Jun_1220pm/2010-01-25T12:25:32Z 2010-01-25T12:25:32Z John Rice
John Rice [jmr's blog] posted a code review on 25 Jan 2010: 13036_persist_cat_act_exp_25Jun_1220pm.
John Rice [jmr's blog] posted a code review on 25 Jan 2010: 13036_persist_cat_act_exp_25Jun_1220pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-25 12:24 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at f9b304e6d6d7)
Compare against: /export/home/jr140578/work/ips_gate_clean (at f9b304e6d6d7)
Summary of changes: 125 lines changed: 111 ins; 0 del; 14 mod; 6106 unchg 
no comments found
 11554,13987-pkg-arg-checks tag:cr.opensolaris.org,2010-01-20:~timf/11554,13987-pkg-arg-checks/2010-01-20T13:01:30Z 2010-01-25T11:40:54Z Tim Foster
Tim Foster [timf's blog] posted a code review on 25 Jan 2010: 11554,13987-pkg-arg-checks.
Tim Foster [timf's blog] posted a code review on 25 Jan 2010: 11554,13987-pkg-arg-checks.

Code Review for

Prepared by:Tim Foster tim.foster@sun.com on 2010-Jan-25 11:38 +0000 GMT
Workspace:/export/home/timf/projects/ips/11554,13987-pkg-arg-checks-pkg.hg (at ccafe77f3c35)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 51f832187af7)
Summary of changes: 32 lines changed: 21 ins; 8 del; 3 mod; 3600 unchg 
11554 pkg set-publisher should accept relative paths to keys and certs
13987 traceback when running 'pkg contents -a foo'
 bugs-14075 tag:cr.opensolaris.org,2010-01-25:~dambi/bugs-14075/2010-01-25T09:28:11Z 2010-01-25T11:32:54Z Jan Damborsky
Jan Damborsky [dambi] posted a code review on 25 Jan 2010: bugs-14075.
Jan Damborsky [dambi] posted a code review on 25 Jan 2010: bugs-14075.

Code Review for os-install-bug-14075

Prepared by:Jan Damborsky jan.damborsky@sun.com on 2010-Jan-25 12:32 +0100 CET
Workspace:/export/home/dambi/ws/os-install-bug-14075 (at 3abf7ed68509)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_source (at 194c6c516a71)
Summary of changes: 29 lines changed: 26 ins; 1 del; 2 mod; 269 unchg 
14075 some of territory names added between 2009.06 and 2010.03 don't displayed up on locale panel of Slim
 bug-13393-cr tag:cr.opensolaris.org,2010-01-21:~dambi/bug-13393-cr/2010-01-21T08:49:34Z 2010-01-25T10:32:19Z Jan Damborsky
Jan Damborsky [dambi] posted a code review on 25 Jan 2010: bug-13393-cr.
Jan Damborsky [dambi] posted a code review on 25 Jan 2010: bug-13393-cr.

Code Review for os-install-bug-13393

Prepared by:Jan Damborsky jan.damborsky@sun.com on 2010-Jan-25 11:32 +0100 CET
Workspace:/export/home/dambi/ws/os-install-bug-13393 (at 194c6c516a71)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_source (at fa057c8df659)
Summary of changes: 93 lines changed: 89 ins; 0 del; 4 mod; 3049 unchg 
13393 min_mem64=1536 in AI GRUB menu should be revisited
 ips-14003-v2 tag:cr.opensolaris.org,2010-01-25:~padraig/ips-14003-v2/2010-01-25T09:06:23Z 2010-01-25T09:06:23Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 25 Jan 2010: ips-14003-v2.
Padraig O\'Briain [padraig] posted a code review on 25 Jan 2010: ips-14003-v2.

Code Review for 14003_clone

Prepared by:Padraig O'Briain padraig.obriain@sun.com on 2010-Jan-25 08:53 +0000 GMT
Workspace:/export/home/padraig/14003_clone (at 51f832187af7)
Compare against: /export/home/padraig/gate (at 51f832187af7)
Summary of changes: 109 lines changed: 60 ins; 6 del; 43 mod; 6515 unchg 
no comments found
 onips_10988 tag:cr.opensolaris.org,2010-01-25:~richlowe/onips_10988/2010-01-25T02:39:23Z 2010-01-25T07:02:28Z Richard Lowe
Richard Lowe [richlowe's blog] posted a code review on 25 Jan 2010: onips_10988.
Richard Lowe [richlowe's blog] posted a code review on 25 Jan 2010: onips_10988.

Code Review for onips_10988

Prepared by:Richard Lowe richlowe@richlowe.net on 2010-Jan-25 02:02 -0500 EST
Workspace:/builds/work/onnv-ips/onnv-ovr-build (at 417d42b63c31)
Compare against: /builds/onnv-ips-clone (at b7138e186dce)
Summary of changes: 2057 lines changed: 1361 ins; 316 del; 380 mod; 5743 unchg 
10999 labeled zones files come from the IPS gate, and are not properly handled in on_ips gate
10988 OpenSolaris's SUNWcs delivers files that ON doesn't have
14117 SUNWcfcl and SUNWfchba both deliver etc/hba.conf
14102 developer/opensolaris/osnet should be in ON
14090 onu leaves depot running on error
 onips_dep tag:cr.opensolaris.org,2010-01-25:~lianep/onips_dep/2010-01-25T06:58:05Z 2010-01-25T06:58:05Z Liane Praza
Liane Praza [lianep's blog] posted a code review on 25 Jan 2010: onips_dep.
Liane Praza [lianep's blog] posted a code review on 25 Jan 2010: onips_dep.

Code Review for onips_dep

Prepared by:Liane Praza Liane.Praza@Sun.COM on 2010-Jan-24 22:57 -0800 PST
Workspace:/local/ws/onips_dep (at b7138e186dce)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/on_ips (at b7138e186dce)
Summary of changes: 1201 lines changed: 336 ins; 561 del; 304 mod; 38088 unchg 
no comments found
 onnv_6915602-kupfer tag:cr.opensolaris.org,2010-01-24:~richlowe/onnv_6915602-kupfer/2010-01-24T01:32:00Z 2010-01-25T06:06:31Z Richard Lowe
Richard Lowe [richlowe's blog] posted a code review on 25 Jan 2010: onnv_6915602-kupfer.
Richard Lowe [richlowe's blog] posted a code review on 25 Jan 2010: onnv_6915602-kupfer.

Code Review for onnv_6915602-kupfer

Prepared by:Richard Lowe richlowe@richlowe.net on 2010-Jan-25 01:06 -0500 EST
Workspace:/builds/work/onnv/onnv-cdm-py26 (at e9a25ee5aaac)
Compare against: /builds/onnv-clone (at 30da49fa0630)
Summary of changes: 297 lines changed: 152 ins; 36 del; 109 mod; 3801 unchg 
6915602 onbld python modules should install into python version specific directories
 webrev.14109 tag:cr.opensolaris.org,2010-01-24:~mjnelson/webrev.14109/2010-01-24T22:22:24Z 2010-01-24T22:22:24Z Mark J. Nelson
Mark J. Nelson [mjnelson's blog] posted a code review on 24 Jan 2010: webrev.14109.
Mark J. Nelson [mjnelson's blog] posted a code review on 24 Jan 2010: webrev.14109.

Code Review for webrev.14109

Prepared by:Mark J. Nelson Mark.J.Nelson@Sun.COM on 2010-Jan-24 15:16 -0700 MST
Workspace:/net/opensores/export/ws/mjnelson/on-ips-work (at 0173cdc220b9)
Compare against: webrev at webrev.fake
Summary of changes: 61 lines changed: 53 ins; 5 del; 3 mod; 670 unchg 
14109 separate build number from usr/src/pkg/Makefile
This script doesn't really live in onnv-gate, it's just here
to fake the webrev for more convenient review.
 5711 tag:cr.opensolaris.org,2010-01-22:~evanl/5711/2010-01-22T19:06:15Z 2010-01-24T05:13:15Z Evan J. Layton
Evan J. Layton [evanl] posted a code review on 24 Jan 2010: 5711.
Evan J. Layton [evanl] posted a code review on 24 Jan 2010: 5711.

Code Review for slim_5711

Prepared by:Evan Layton Evan.Layton@Sun.COM on 2010-Jan-23 22:28 -0700 MST
Workspace:/net/dv31/nfs1/ws/evanl/slim_5711 (at 2a5390377ab3)
Compare against: ssh://evanl@hg.opensolaris.org/hg/caiman/slim_source (at c6c48f08de33)
Summary of changes: 650 lines changed: 394 ins; 238 del; 18 mod; 7474 unchg 
5711 libbe autonaming for zones datasets should use the same method as the BE autonaming
 webrev-3720-3 tag:cr.opensolaris.org,2010-01-23:~johansen/webrev-3720-3/2010-01-23T01:05:30Z 2010-01-23T01:05:30Z johansen
johansen [johansen] posted a code review on 23 Jan 2010: webrev-3720-3.
johansen [johansen] posted a code review on 23 Jan 2010: webrev-3720-3.

Code Review for pkg-bugs

Prepared by:johansen on 2010-Jan-22 17:05 -0800 PST
Workspace:/home/johansen/hg_ws/pkg-bugs (at e732a53c4564)
Compare against: ssh://johansen@opensolaris.org/hg/pkg/gate (at 51f832187af7)
Summary of changes: 135 lines changed: 90 ins; 25 del; 20 mod; 3577 unchg 
3720 Race condition exists for cancelation using the API
13925 installs slow down towards the end
14049 Classes that handle RLock have trouble with NRLock
 ips-12271-v1 tag:cr.opensolaris.org,2010-01-23:~bpytlik/ips-12271-v1/2010-01-23T00:42:42Z 2010-01-23T00:42:42Z Brock Pytlik
Brock Pytlik [bpytlik] posted a code review on 23 Jan 2010: ips-12271-v1.
Brock Pytlik [bpytlik] posted a code review on 23 Jan 2010: ips-12271-v1.

Code Review for recommit.bug-12271-v1

Prepared by:Brock Pytlik bpytlik@sun.com on 2010-Jan-22 16:42 -0800 PST
Workspace:/export/home/bpytlik/IPS/recommit.bug-12271-v1 (at 4bae42b73adf)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at f9b304e6d6d7)
Summary of changes: 43 lines changed: 42 ins; 0 del; 1 mod; 4103 unchg 
12271 consecutive duplicate search rows should be eliminated
14088 search with single -o option doesn't print headers
 ips-14020-v3 tag:cr.opensolaris.org,2010-01-22:~bpytlik/ips-14020-v3/2010-01-22T23:35:33Z 2010-01-22T23:35:33Z Brock Pytlik
Brock Pytlik [bpytlik] posted a code review on 22 Jan 2010: ips-14020-v3.
Brock Pytlik [bpytlik] posted a code review on 22 Jan 2010: ips-14020-v3.

Code Review for recommit.bug-14020-v3

Prepared by:Brock Pytlik bpytlik@sun.com on 2010-Jan-22 15:35 -0800 PST
Workspace:/export/home/bpytlik/IPS/recommit.bug-14020-v3 (at 9eadbe6eb7d7)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at f9b304e6d6d7)
Summary of changes: 236 lines changed: 97 ins; 99 del; 40 mod; 938 unchg 
14020 test for alt python versions shouldn't hardcode paths
 ips-14020-v2 tag:cr.opensolaris.org,2010-01-22:~bpytlik/ips-14020-v2/2010-01-22T22:14:59Z 2010-01-22T22:14:59Z Brock Pytlik
Brock Pytlik [bpytlik] posted a code review on 22 Jan 2010: ips-14020-v2.
Brock Pytlik [bpytlik] posted a code review on 22 Jan 2010: ips-14020-v2.

Code Review for recommit.bug-14020-v2

Prepared by:Brock Pytlik bpytlik@sun.com on 2010-Jan-22 14:14 -0800 PST
Workspace:/export/home/bpytlik/IPS/recommit.bug-14020-v2 (at 9c8407d9738f)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 825ec1d3702e)
Summary of changes: 119 lines changed: 82 ins; 18 del; 19 mod; 1040 unchg 
14020 test for alt python versions shouldn't hardcode paths
 ips-14020-v1 tag:cr.opensolaris.org,2010-01-22:~bpytlik/ips-14020-v1/2010-01-22T21:19:52Z 2010-01-22T21:19:52Z Brock Pytlik
Brock Pytlik [bpytlik] posted a code review on 22 Jan 2010: ips-14020-v1.
Brock Pytlik [bpytlik] posted a code review on 22 Jan 2010: ips-14020-v1.

Code Review for recommit.bug-14020-v1

Prepared by:Brock Pytlik bpytlik@sun.com on 2010-Jan-22 13:19 -0800 PST
Workspace:/export/home/bpytlik/IPS/recommit.bug-14020-v1 (at e318107e1e3e)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 825ec1d3702e)
Summary of changes: 93 lines changed: 56 ins; 10 del; 27 mod; 1040 unchg 
14020 test for alt python versions shouldn't hardcode paths
 6918524 tag:cr.opensolaris.org,2010-01-22:~kupfer/6918524/2010-01-22T18:26:31Z 2010-01-22T18:26:31Z Mike Kupfer
Mike Kupfer [kupfer's blog] posted a code review on 22 Jan 2010: 6918524.
Mike Kupfer [kupfer's blog] posted a code review on 22 Jan 2010: 6918524.

Code Review for 6918524

Prepared by:Mike Kupfer Mike.Kupfer@Sun.COM on 2010-Jan-22 10:26 -0800 PST
Workspace:/net/tonic-gate/builds/kupfer/6918524 (at cc9eb43e2378)
Compare against: ssh://anonhg@onnv.sfbay.sun.com//export/onnv-clone (at 73d521803f1a)
Summary of changes: 17 lines changed: 10 ins; 0 del; 7 mod; 3630 unchg 
6918524 6855998 broke sfw build
 renaming_v1 tag:cr.opensolaris.org,2010-01-22:~migi/renaming_v1/2010-01-22T16:29:05Z 2010-01-22T16:29:05Z Michal Pryc
Michal Pryc [migi's blog] posted a code review on 22 Jan 2010: renaming_v1.
Michal Pryc [migi's blog] posted a code review on 22 Jan 2010: renaming_v1.

Code Review for GATE

Prepared by:Michal Pryc Michal.Pryc@Sun.Com on 2010-Jan-22 16:28 +0000 GMT
Workspace:/export/home/migi/Development/GATE (at f9b304e6d6d7)
Compare against: ssh://migi@hg.opensolaris.org/hg/pkg/gate (at f9b304e6d6d7)
Summary of changes: 66 lines changed: 64 ins; 0 del; 2 mod; 6382 unchg 
no comments found
 6919271_webrev.0 tag:cr.opensolaris.org,2010-01-22:~swilcox/6919271_webrev.0/2010-01-22T16:06:17Z 2010-01-22T16:06:17Z Sean D. Wilcox
Sean D. Wilcox [swilcox] posted a code review on 22 Jan 2010: 6919271_webrev.0.
Sean D. Wilcox [swilcox] posted a code review on 22 Jan 2010: 6919271_webrev.0.

Code Review for webrev.0

Prepared by:Sean Wilcox Sean.Wilcox@Sun.COM on 2010-Jan-22 08:06 -0800 PST
Workspace:/builds/swilcox/new_6311392 (at 4fc0a82e09f7)
Compare against: /ws/onnv-clone (at 4fc0a82e09f7)
Summary of changes: 4 lines changed: 1 ins; 3 del; 0 mod; 2447 unchg 
no comments found
 bug-13954 tag:cr.opensolaris.org,2010-01-19:~wmsch/bug-13954/2010-01-19T07:51:16Z 2010-01-22T14:39:56Z William Schumann
William Schumann [wmsch] posted a code review on 22 Jan 2010: bug-13954.
William Schumann [wmsch] posted a code review on 22 Jan 2010: bug-13954.

Code Review for noisc

Prepared by:William Schumann william.schumann@sun.com on 2010-Jan-22 07:39 -0700 MST
Workspace:/export/home/ws199450/noisc (at ed40a63fb1e5)
Compare against: ssh://wmsch@hg.opensolaris.org/hg/caiman/slim_source (at 12dca3ad0569)
Summary of changes: 28 lines changed: 25 ins; 3 del; 0 mod; 1888 unchg 
13954 iSCSI boot parameters in AI manifest are ignored
 old/bug-14061 tag:cr.opensolaris.org,2010-01-22:~mattman/bug_14061/2010-01-22T12:40:33Z 2010-01-22T12:40:33Z Matt Keenan
Matt Keenan [mattman's blog] posted a code review on 22 Jan 2010: old/bug-14061.
Matt Keenan [mattman's blog] posted a code review on 22 Jan 2010: old/bug-14061.

Code Review for bug_14061

Prepared by:Matt Keenan matt.keenan@sun.com on 2010-Jan-22 12:28 +0000 GMT
Workspace:/export/home/caiman/bug_14061 (at 12dca3ad0569)
Compare against: ssh://mattman@hg.opensolaris.org/hg/caiman/slim_source (at 68b0dc3a8806)
Summary of changes: 0 lines changed: 0 ins; 0 del; 0 mod; 0 unchg 
14061 Revised Marketing Image for GUI Installer required
 14036_all_search_to_pub_22Jan_1120am tag:cr.opensolaris.org,2010-01-22:~jmr/14036_all_search_to_pub_22Jan_1120am/2010-01-22T11:20:17Z 2010-01-22T11:20:17Z John Rice
John Rice [jmr's blog] posted a code review on 22 Jan 2010: 14036_all_search_to_pub_22Jan_1120am.
John Rice [jmr's blog] posted a code review on 22 Jan 2010: 14036_all_search_to_pub_22Jan_1120am.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-22 11:19 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at 750d69997c69)
Compare against: /export/home/jr140578/work/ips_gate_clean (at 750d69997c69)
Summary of changes: 5 lines changed: 1 ins; 3 del; 1 mod; 5901 unchg 
no comments found
 14036_all_search_to_pub_22Jan_1110am tag:cr.opensolaris.org,2010-01-22:~jmr/14036_all_search_to_pub_22Jan_1110am/2010-01-22T11:12:20Z 2010-01-22T11:12:20Z John Rice
John Rice [jmr's blog] posted a code review on 22 Jan 2010: 14036_all_search_to_pub_22Jan_1110am.
John Rice [jmr's blog] posted a code review on 22 Jan 2010: 14036_all_search_to_pub_22Jan_1110am.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-22 11:10 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at 750d69997c69)
Compare against: /export/home/jr140578/work/ips_gate_clean (at 750d69997c69)
Summary of changes: 5 lines changed: 0 ins; 3 del; 2 mod; 5900 unchg 
no comments found
 ips-14028-v1 tag:cr.opensolaris.org,2010-01-22:~padraig/ips-14028-v1/2010-01-22T11:06:38Z 2010-01-22T11:06:38Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 22 Jan 2010: ips-14028-v1.
Padraig O\'Briain [padraig] posted a code review on 22 Jan 2010: ips-14028-v1.

Code Review for 14028_clone

Prepared by:Padraig O'Briain padraig.obriain@sun.com on 2010-Jan-22 10:55 +0000 GMT
Workspace:/export/home/padraig/14028_clone (at 8b283110ba6d)
Compare against: /export/home/padraig/gate (at 8b283110ba6d)
Summary of changes: 4 lines changed: 0 ins; 2 del; 2 mod; 1238 unchg 
no comments found
 13846 tag:cr.opensolaris.org,2010-01-22:~barts/13846/2010-01-22T06:40:17Z 2010-01-22T06:40:17Z Bart Smaalders
Bart Smaalders [barts's blog] posted a code review on 22 Jan 2010: 13846.
Bart Smaalders [barts's blog] posted a code review on 22 Jan 2010: 13846.

Code Review for pkg-bugs

Prepared by:Bart Smaalders Bart.Smaalders@Sun.COM on 2010-Jan-21 22:40 -0800 PST
Workspace:/home/barts/ws/pkg-bugs (at 9c1636c9f77c)
Compare against: ssh://barts@hg.opensolaris.org/hg/pkg/gate (at 55ad88a93fad)
Summary of changes: 155 lines changed: 110 ins; 19 del; 26 mod; 3667 unchg 
13846 pkg awakes after reboot to discover that it has made a mistake
13589 __possible_dict KeyError on pkg install
13810 KeyError in PkgSolver:__filter_publishers
13834 pkg install -v should indicate why incorporated packages are not considered for installation
13981 unversioned dependencies on incorporations are relaxed during install, causing unneeded ipkg updates on systems w/o entire installed
 webrev.14024.incr tag:cr.opensolaris.org,2010-01-22:~mjnelson/webrev.14024.incr/2010-01-22T05:30:42Z 2010-01-22T05:30:42Z Mark J. Nelson
Mark J. Nelson [mjnelson's blog] posted a code review on 22 Jan 2010: webrev.14024.incr.
Mark J. Nelson [mjnelson's blog] posted a code review on 22 Jan 2010: webrev.14024.incr.

Code Review for webrev.14024.incr

Prepared by:Mark J. Nelson Mark.J.Nelson@Sun.COM on 2010-Jan-21 22:26 -0700 MST
Workspace:/net/mrliberal.central/export/ws/mjnelson/on-ips-work (at b7138e186dce)
Compare against: webrev at webrev.14024
Summary of changes: 37 lines changed: 1 ins; 27 del; 9 mod; 594 unchg 
14024 shell scripts embedded in usr/src/pkg/Makefile can make strong engineers cry
 onips_nits tag:cr.opensolaris.org,2010-01-22:~lianep/onips_nits/2010-01-22T01:12:12Z 2010-01-22T01:12:12Z Liane Praza
Liane Praza [lianep's blog] posted a code review on 22 Jan 2010: onips_nits.
Liane Praza [lianep's blog] posted a code review on 22 Jan 2010: onips_nits.

Code Review for onips_nits

Prepared by:Liane Praza Liane.Praza@Sun.COM on 2010-Jan-21 17:12 -0800 PST
Workspace:/builds/lianep/onips_nits (at 8acfe4cc98d2)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/on_ips (at 8acfe4cc98d2)
Summary of changes: 199 lines changed: 167 ins; 7 del; 25 mod; 5728 unchg 
no comments found
 webrev-3720-2 tag:cr.opensolaris.org,2010-01-22:~johansen/webrev-3720-2/2010-01-22T01:03:14Z 2010-01-22T01:03:14Z johansen
johansen [johansen] posted a code review on 22 Jan 2010: webrev-3720-2.
johansen [johansen] posted a code review on 22 Jan 2010: webrev-3720-2.

Code Review for pkg-bugs

Prepared by:johansen on 2010-Jan-21 17:02 -0800 PST
Workspace:/home/johansen/hg_ws/pkg-bugs (at b86acf53ad33)
Compare against: ssh://johansen@opensolaris.org/hg/pkg/gate (at 8b283110ba6d)
Summary of changes: 103 lines changed: 75 ins; 16 del; 12 mod; 3595 unchg 
3720 Race condition exists for cancelation using the API
13925 installs slow down towards the end
14049 Classes that handle RLock have trouble with NRLock
 webrev.14024 tag:cr.opensolaris.org,2010-01-21:~mjnelson/webrev.14024/2010-01-21T23:36:57Z 2010-01-21T23:36:57Z Mark J. Nelson
Mark J. Nelson [mjnelson's blog] posted a code review on 21 Jan 2010: webrev.14024.
Mark J. Nelson [mjnelson's blog] posted a code review on 21 Jan 2010: webrev.14024.

Code Review for webrev.14024

Prepared by:Mark J. Nelson Mark.J.Nelson@Sun.COM on 2010-Jan-21 16:30 -0700 MST
Workspace:/net/mrliberal.central/export/ws/mjnelson/on-ips-work (at 7dd35ae10e72)
Compare against: ssh://anon@hg.opensolaris.org//hg/pkg/on_ips (at 8acfe4cc98d2)
Summary of changes: 92 lines changed: 79 ins; 9 del; 4 mod; 547 unchg 
14024 shell scripts embedded in usr/src/pkg/Makefile can make strong engineers cry
 100121/webrev tag:cr.opensolaris.org,2010-01-21:~schwartz/100121/webrev/2010-01-21T23:16:59Z 2010-01-21T23:16:59Z Jack A. Schwartz
Jack A. Schwartz [schwartz] posted a code review on 21 Jan 2010: 100121/webrev.
Jack A. Schwartz [schwartz] posted a code review on 21 Jan 2010: 100121/webrev.

Code Review for hg-text-install

Prepared by:Jack Schwartz Jack.A.Schwartz@Sun.COM on 2010-Jan-21 15:14 -0800 PST
Workspace:/home/schwartz/gates/hg-text-install (at fb68ccb358a5)
Compare against: http://thunderfury:8000 (at fb68ccb358a5)
Summary of changes: 610 lines changed: 37 ins; 549 del; 24 mod; 3361 unchg 
no comments found
 webrev-3720 tag:cr.opensolaris.org,2010-01-21:~johansen/webrev-3720/2010-01-21T22:33:33Z 2010-01-21T22:33:33Z johansen
johansen [johansen] posted a code review on 21 Jan 2010: webrev-3720.
johansen [johansen] posted a code review on 21 Jan 2010: webrev-3720.

Code Review for pkg-bugs

Prepared by:johansen on 2010-Jan-21 14:33 -0800 PST
Workspace:/home/johansen/hg_ws/pkg-bugs (at 40c45b918e18)
Compare against: ssh://johansen@opensolaris.org/hg/pkg/gate (at 825ec1d3702e)
Summary of changes: 85 lines changed: 60 ins; 16 del; 9 mod; 3598 unchg 
3720 Race condition exists for cancelation using the API
13925 installs slow down towards the end
14049 Classes that handle RLock have trouble with NRLock
 6828622 tag:cr.opensolaris.org,2010-01-14:~gvasick/6828622/2010-01-14T00:44:20Z 2010-01-21T22:01:16Z George Vasick
George Vasick [gvasick] posted a code review on 21 Jan 2010: 6828622.
George Vasick [gvasick] posted a code review on 21 Jan 2010: 6828622.

Code Review for 6828622

Prepared by:George Vasick (gvasick) on 2010-Jan-21 14:07 -0800 PST
Workspace:/export/home/george/sfw
Compare against: /ws/sfwnv-clone
Summary of changes: 8 lines changed: 0 ins; 4 del; 4 mod; 151 unchg 
6828622 libnet Makefile invokes gcc directly, it should use $(CC) instead.
 0000017_block_inode_bitmaps_diferences_after_open_01 tag:cr.opensolaris.org,2010-01-21:~senoltj/0000017_block_inode_bitmaps_diferences_after_open_01/2010-01-21T21:12:41Z 2010-01-21T21:12:41Z Jan Senolt
Jan Senolt [senoltj] posted a code review on 21 Jan 2010: 0000017_block_inode_bitmaps_diferences_after_open_01.
Jan Senolt [senoltj] posted a code review on 21 Jan 2010: 0000017_block_inode_bitmaps_diferences_after_open_01.

Code Review for ext2-gate

Prepared by:senoltj@opensolaris.org on Thu Jan 21 22:07:01 CET 2010
Workspace:/export/home/honza/projects/ext2/ws-open2/ext2-gate (at d977342e3206)
Compare against: ssh://senoltj@hg.opensolaris.org/hg/ext3/ext2-gate (at d977342e3206)
Summary of changes: 110 lines changed: 57 ins; 14 del; 39 mod; 2833 unchg 
no comments found
 14046 tag:cr.opensolaris.org,2010-01-21:~ktung/14046/2010-01-21T21:07:55Z 2010-01-21T21:07:55Z Karen Tung
Karen Tung [ktung] posted a code review on 21 Jan 2010: 14046.
Karen Tung [ktung] posted a code review on 21 Jan 2010: 14046.

Code Review for 14046

Prepared by:Karen Tung Karen.Tung@Sun.COM on 2010-Jan-21 13:07 -0800 PST
Workspace:/code/12726 (at c6c48f08de33)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_source (at c6c48f08de33)
Summary of changes: 1 line changed: 0 ins; 1 del; 0 mod; 451 unchg 
no comments found
 webrev.13282 tag:cr.opensolaris.org,2010-01-21:~gjelinek/webrev.13282/2010-01-21T20:57:45Z 2010-01-21T20:57:45Z Gerald A. Jelinek
Gerald A. Jelinek [gjelinek] posted a code review on 21 Jan 2010: webrev.13282.
Gerald A. Jelinek [gjelinek] posted a code review on 21 Jan 2010: webrev.13282.

Code Review for pkg_bugs

Prepared by:gerald.jelinek@sun.com on 2010-Jan-21 13:56 -0700 MST
Workspace:/export/ws/pkg_bugs (at 629edb7daf58)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at f3c0aa5f3998)
Summary of changes: 12 lines changed: 0 ins; 6 del; 6 mod; 531 unchg 
13282 zoneadm attach -u always re-downloads pkgs
 CR_6908582/webrev tag:cr.opensolaris.org,2010-01-21:~priyak/CR_6908582/webrev/2010-01-21T13:35:16Z 2010-01-21T20:44:31Z Priya Krishnan
Priya Krishnan [priyak] posted a code review on 21 Jan 2010: CR_6908582/webrev.
Priya Krishnan [priyak] posted a code review on 21 Jan 2010: CR_6908582/webrev.

Code Review for onnv-snv130

Prepared by:Priya Krishnan Priya.Krishnan@Sun.COM on 2010-Jan-21 15:44 -0500 EST
Workspace:/export/build/priyak/onnv-snv130 (at bb7a484cfdce)
Compare against: ssh://anonhg@onnv.sfbay.sun.com//export/onnv-clone (at 73d521803f1a)
Summary of changes: 15 lines changed: 7 ins; 4 del; 4 mod; 6059 unchg 
6915174 Some commands get rejected inappropriately when using phase collapse
6908582 45% snv_129 comstar_tmpfs_64k_RandomWrite1th_osX_1gbnic_thump009cl5 performance regression x86
 13062_entire_details_21Jan_440pm tag:cr.opensolaris.org,2010-01-21:~jmr/13062_entire_details_21Jan_440pm/2010-01-21T16:42:23Z 2010-01-21T16:42:23Z John Rice
John Rice [jmr's blog] posted a code review on 21 Jan 2010: 13062_entire_details_21Jan_440pm.
John Rice [jmr's blog] posted a code review on 21 Jan 2010: 13062_entire_details_21Jan_440pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-21 16:40 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at 30e5bbe64fd3)
Compare against: /export/home/jr140578/work/ips_gate_clean (at 30e5bbe64fd3)
Summary of changes: 4 lines changed: 3 ins; 0 del; 1 mod; 5901 unchg 
no comments found
 ips-14003-v1 tag:cr.opensolaris.org,2010-01-21:~padraig/ips-14003-v1/2010-01-21T15:31:54Z 2010-01-21T15:31:54Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 21 Jan 2010: ips-14003-v1.
Padraig O\'Briain [padraig] posted a code review on 21 Jan 2010: ips-14003-v1.

Code Review for 14003_clone

Prepared by:Padraig O'Briain padraig.obriain@sun.com on 2010-Jan-21 15:20 +0000 GMT
Workspace:/export/home/padraig/14003_clone (at faf484754465)
Compare against: /export/home/padraig/gate (at faf484754465)
Summary of changes: 71 lines changed: 45 ins; 1 del; 25 mod; 7233 unchg 
no comments found
 13062_entire_details_21Jan_320pm tag:cr.opensolaris.org,2010-01-21:~jmr/13062_entire_details_21Jan_320pm/2010-01-21T15:20:50Z 2010-01-21T15:20:50Z John Rice
John Rice [jmr's blog] posted a code review on 21 Jan 2010: 13062_entire_details_21Jan_320pm.
John Rice [jmr's blog] posted a code review on 21 Jan 2010: 13062_entire_details_21Jan_320pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-21 15:19 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at 30e5bbe64fd3)
Compare against: /export/home/jr140578/work/ips_gate_clean (at 30e5bbe64fd3)
Summary of changes: 4 lines changed: 3 ins; 0 del; 1 mod; 5901 unchg 
no comments found
 old/bug-13972 tag:cr.opensolaris.org,2010-01-21:~mattman/bug_13972/2010-01-21T15:20:33Z 2010-01-21T15:20:33Z Matt Keenan
Matt Keenan [mattman's blog] posted a code review on 21 Jan 2010: old/bug-13972.
Matt Keenan [mattman's blog] posted a code review on 21 Jan 2010: old/bug-13972.

Code Review for bug_13972

Prepared by:Matt Keenan matt.keenan@sun.com on 2010-Jan-21 15:17 +0000 UTC
Workspace:/export/home/caiman/bug_13972 (at 72fbd24a6943)
Compare against: ssh://mattman@hg.opensolaris.org/hg/caiman/slim_source (at efcc9630d2b7)
Summary of changes: 27 lines changed: 17 ins; 0 del; 10 mod; 7380 unchg 
13972 Sometimes installer has unexpected insensitive Unused partition
 13062_entire_details_21Jan_315pm tag:cr.opensolaris.org,2010-01-21:~jmr/13062_entire_details_21Jan_315pm/2010-01-21T15:17:26Z 2010-01-21T15:17:26Z John Rice
John Rice [jmr's blog] posted a code review on 21 Jan 2010: 13062_entire_details_21Jan_315pm.
John Rice [jmr's blog] posted a code review on 21 Jan 2010: 13062_entire_details_21Jan_315pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-21 15:12 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at 30e5bbe64fd3)
Compare against: /export/home/jr140578/work/ips_gate_clean (at 30e5bbe64fd3)
Summary of changes: 4 lines changed: 3 ins; 0 del; 1 mod; 5901 unchg 
no comments found
 pm_8424_pm_out_of_memory_21Jan_1250pm tag:cr.opensolaris.org,2010-01-21:~jmr/pm_8424_pm_out_of_memory_21Jan_1250pm/2010-01-21T12:54:56Z 2010-01-21T12:54:56Z John Rice
John Rice [jmr's blog] posted a code review on 21 Jan 2010: pm_8424_pm_out_of_memory_21Jan_1250pm.
John Rice [jmr's blog] posted a code review on 21 Jan 2010: pm_8424_pm_out_of_memory_21Jan_1250pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-21 12:54 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at faf484754465)
Compare against: /export/home/jr140578/work/ips_gate_clean (at faf484754465)
Summary of changes: 28 lines changed: 25 ins; 1 del; 2 mod; 5865 unchg 
no comments found
 old/bug-13559 tag:cr.opensolaris.org,2010-01-21:~mattman/bug_13559/2010-01-21T11:36:32Z 2010-01-21T11:36:32Z Matt Keenan
Matt Keenan [mattman's blog] posted a code review on 21 Jan 2010: old/bug-13559.
Matt Keenan [mattman's blog] posted a code review on 21 Jan 2010: old/bug-13559.

Code Review for bug_13559

Prepared by:Matt Keenan matt.keenan@sun.com on 2010-Jan-21 11:33 +0000 UTC
Workspace:/export/home/caiman/bug_13559 (at 22f1ed89e029)
Compare against: ssh://mattman@hg.opensolaris.org/hg/caiman/slim_source (at efcc9630d2b7)
Summary of changes: 132 lines changed: 30 ins; 48 del; 54 mod; 121 unchg 
13559 Integrate New Help Files for 2010.03 Release
 pm_8424_pm_out_of_memory_21Jan_1120am tag:cr.opensolaris.org,2010-01-21:~jmr/pm_8424_pm_out_of_memory_21Jan_1120am/2010-01-21T11:20:17Z 2010-01-21T11:20:17Z John Rice
John Rice [jmr's blog] posted a code review on 21 Jan 2010: pm_8424_pm_out_of_memory_21Jan_1120am.
John Rice [jmr's blog] posted a code review on 21 Jan 2010: pm_8424_pm_out_of_memory_21Jan_1120am.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-21 11:19 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at faf484754465)
Compare against: /export/home/jr140578/work/ips_gate_clean (at faf484754465)
Summary of changes: 32 lines changed: 25 ins; 1 del; 6 mod; 5861 unchg 
no comments found
 pm_13975_transport_errs_21Jan_11am tag:cr.opensolaris.org,2010-01-21:~jmr/pm_13975_transport_errs_21Jan_11am/2010-01-21T11:05:57Z 2010-01-21T11:05:57Z John Rice
John Rice [jmr's blog] posted a code review on 21 Jan 2010: pm_13975_transport_errs_21Jan_11am.
John Rice [jmr's blog] posted a code review on 21 Jan 2010: pm_13975_transport_errs_21Jan_11am.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-21 10:59 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at faf484754465)
Compare against: /export/home/jr140578/work/ips_gate_clean (at faf484754465)
Summary of changes: 132 lines changed: 59 ins; 30 del; 43 mod; 10101 unchg 
no comments found
 template_changes tag:cr.opensolaris.org,2010-01-21:~rajkumar/template_changes/2010-01-21T09:40:08Z 2010-01-21T09:40:08Z Rajkumar Srinivasan
Rajkumar Srinivasan [rajkumar] posted a code review on 21 Jan 2010: template_changes.
Rajkumar Srinivasan [rajkumar] posted a code review on 21 Jan 2010: template_changes.

Code Review for 1000

Prepared by:Rajkumar (rajkumar) on Thu Jan 21 12:43:25 IST 2010
Workspace:/export/home/rajkumar/workspace/pkg5-jan12 (at e3c329ec8f96)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at d8c628675154)
Summary of changes: 2332 lines changed: 2327 ins; 3 del; 2 mod; 177 unchg 
Template chances for Issue 1000
 webrev.addcddl tag:cr.opensolaris.org,2010-01-21:~mjnelson/webrev.addcddl/2010-01-21T07:03:16Z 2010-01-21T07:24:13Z Mark J. Nelson
Mark J. Nelson [mjnelson's blog] posted a code review on 21 Jan 2010: webrev.addcddl.
Mark J. Nelson [mjnelson's blog] posted a code review on 21 Jan 2010: webrev.addcddl.

Code Review for webrev.addcddl

Prepared by:Mark J. Nelson Mark.J.Nelson@Sun.COM on 2010-Jan-21 00:19 -0700 MST
Workspace:/net/mrliberal.central/export/ws/mjnelson/on-ips-work (at 8acfe4cc98d2)
Compare against: ssh://anon@hg.opensolaris.org//hg/pkg/on_ips (at 8043cdb5c1b0)
Summary of changes: 10775 lines changed: 10766 ins; 5 del; 4 mod; 29873 unchg 
add cddl and copyright
 sockfilter/webrev tag:cr.opensolaris.org,2010-01-21:~anders/sockfilter/webrev/2010-01-21T06:47:11Z 2010-01-21T06:47:11Z Anders Persson
Anders Persson [anders] posted a code review on 21 Jan 2010: sockfilter/webrev.
Anders Persson [anders] posted a code review on 21 Jan 2010: sockfilter/webrev.

Code Review for sockfilter-codereview

Prepared by:Anders Persson Anders.Persson@Sun.COM on 2010-Jan-20 22:05 -0800 PST
Workspace:/exportz/apersson/sockfilter-codereview (at e5afdbd80cbf)
Compare against: ssh://anonhg@onnv.sfbay//export/onnv-clone (at 2a76e51f60ab)
Summary of changes: 4831 lines changed: 3932 ins; 503 del; 396 mod; 81648 unchg 
PSARC/2009/590 Socket Filter Framework
6802067 connect_failed kernel socket callback is not triggered
6776450 time spent in tcp_close could be reduced/deferred to a worker thread
6828586 assertion failed: family == 26, file: ../../common/fs/sockfs/socksyscalls.c, line: 1608
6802078 kernel socket 'newconn' callback is passing rcv queue size as an argument
 webrev.pkgmog.tests tag:cr.opensolaris.org,2010-01-20:~mjnelson/webrev.pkgmog.tests/2010-01-20T18:16:52Z 2010-01-21T05:43:12Z Mark J. Nelson
Mark J. Nelson [mjnelson's blog] posted a code review on 21 Jan 2010: webrev.pkgmog.tests.
Mark J. Nelson [mjnelson's blog] posted a code review on 21 Jan 2010: webrev.pkgmog.tests.

Code Review for webrev.pkgmog.tests

Prepared by:Mark J. Nelson Mark.J.Nelson@Sun.COM on 2010-Jan-20 22:39 -0700 MST
Workspace:/export/ws/mjnelson/ips-gate (at cacfae42fedb)
Compare against: ssh://anon@hg.opensolaris.org//hg/pkg/gate (at 6897b80bca9e)
Summary of changes: 173 lines changed: 111 ins; 4 del; 58 mod; 1375 unchg 
13792 on_ips needs abort and print operations for pkgmogrify's transform directive
 elxl tag:cr.opensolaris.org,2010-01-12:~gdamore/elxl/2010-01-12T20:43:44Z 2010-01-21T04:26:55Z Garrett D\'Amore
Garrett D\'Amore [gdamore's blog] posted a code review on 21 Jan 2010: elxl.
Garrett D\'Amore [gdamore's blog] posted a code review on 21 Jan 2010: elxl.

Code Review for yge

Prepared by:Garrett D'Amore gdamore@opensolaris.org on Wed Jan 20 20:26:54 PST 2010
Workspace:/work/gdamore/yge/yge (at 99d8a44c198a)
Compare against: ssh://anonhg@onnv.sfbay//export/onnv-clone/ (at 729e2aa450a6)
Summary of changes: 3189 lines changed: 3176 ins; 10 del; 3 mod; 6601 unchg 
Move elxl into its own packaging.
Cleanup cstyle issues.
Enabled hardware IP checksum offload (verified working!)
Added pci ID for 3c905B-FX to postinstall.
New Open Source elxl driver.  (Derived from NetBSD elinkxl.c)
branch merge
More dynamic device capability and media discovery.
Support for _media and _available_media private properties.
Don't default FX to full-duplex.  FreeBSD does, but Linux and NetBSD don't.
Not sure what the right answer here is.  The user should just pick the best
value.
lint fixes.
Add a few missing files.
Report "unknown" phys for internal PHYs reasonably.
 pkg-14013 tag:cr.opensolaris.org,2010-01-21:~swalker/pkg-14013/2010-01-21T03:27:27Z 2010-01-21T03:27:27Z Shawn Walker
Shawn Walker [swalker's blog] posted a code review on 21 Jan 2010: pkg-14013.
Shawn Walker [swalker's blog] posted a code review on 21 Jan 2010: pkg-14013.

Code Review for pkg-14013

Prepared by:Shawn Walker srw@sun.com on 2010-Jan-20 21:27 -0600 CST
Workspace:/export/home/swalker/devel/pkg-14013 (at 814ba8b713d8)
Compare against: /export/home/swalker/devel/pkg-tip (at 6897b80bca9e)
Summary of changes: 219 lines changed: 160 ins; 47 del; 12 mod; 3230 unchg 
14013 image catalog rebuild can stumble on v0 to v1 repo transition
 pkg-testfu tag:cr.opensolaris.org,2009-12-18:~dp/pkg-testfu/2009-12-18T03:05:16Z 2010-01-21T02:17:42Z Daniel B. Price
Daniel B. Price [dp's blog] posted a code review on 21 Jan 2010: pkg-testfu.
Daniel B. Price [dp's blog] posted a code review on 21 Jan 2010: pkg-testfu.

Code Review for pkg-testfu

Prepared by:Dan Price dp@eng.sun.com on 2010-Jan-20 18:17 -0800 PST
Workspace:/aux0/ws/pkg-testfu (at 6337715aa883)
Compare against: ssh://hg.opensolaris.org/hg/pkg/gate (at fc767eea5b69)
Summary of changes: 5386 lines changed: 2350 ins; 1918 del; 1118 mod; 36032 unchg 
test fixes save before nyc
merge
post merge
pre vacation commit
copyright 2010
pre refactoring for pkg5testenv
added archiving
improved output wrapping
kill depots, then rm files
more fixes, more relative paths for 'add file'
 + 15 more lines...
 12726-updated2 tag:cr.opensolaris.org,2010-01-19:~ktung/12726-updated2/2010-01-19T23:47:31Z 2010-01-20T21:24:56Z Karen Tung
Karen Tung [ktung] posted a code review on 20 Jan 2010: 12726-updated2.
Karen Tung [ktung] posted a code review on 20 Jan 2010: 12726-updated2.

Code Review for 12726-updated2

Prepared by:Karen Tung Karen.Tung@Sun.COM on 2010-Jan-20 13:24 -0800 PST
Workspace:/code/12726 (at a6d14d702c1e)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_source (at 8d0c12a091c3)
Summary of changes: 331 lines changed: 263 ins; 40 del; 28 mod; 4247 unchg 
12726 DC and installers shouldn't require a root password in the packaged /etc/shadow
12669 DC errors about /var/pkg/catalog
12186 Deleting catalog cache needs to be revisited with with catalog v1
 13537-13766-13795-13979-13892 tag:cr.opensolaris.org,2010-01-19:~aalok/13537-13766-13795-13979-13892/2010-01-19T22:43:54Z 2010-01-20T20:05:27Z Alok Aggarwal
Alok Aggarwal [aalok's blog] posted a code review on 20 Jan 2010: 13537-13766-13795-13979-13892.
Alok Aggarwal [aalok's blog] posted a code review on 20 Jan 2010: 13537-13766-13795-13979-13892.

Code Review for 13537-13766-13795-13979-13892

Prepared by:Alok Aggarwal Alok.Aggarwal@Sun.COM on 2010-Jan-20 12:03 -0800 PST
Workspace:/export/home/aalok/slim_source (at 4d28279263f0)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_source (at 4cd5a9a2640b)
Summary of changes: 96 lines changed: 49 ins; 26 del; 21 mod; 4034 unchg 
13537 transfer module keeps trying to contact an unreachable IPS server indefinitely
13766 AI debug mode can only be activated in conjunction with service discovery
13795 Debug mode cannot be enabled in build 130
13979 fix for 12659 results in auto-installer not retrying when unable to reach the IPS repo
13892 Selecting LiveCD Grub option "Enable SSH" should not prompt for language
 6878048 tag:cr.opensolaris.org,2010-01-19:~cmynhier/6878048/2010-01-19T20:16:10Z 2010-01-20T19:26:57Z Chad Mynhier
Chad Mynhier [cmynhier's blog] posted a code review on 20 Jan 2010: 6878048.
Chad Mynhier [cmynhier's blog] posted a code review on 20 Jan 2010: 6878048.

Code Review for dofusers-new

Prepared by:Chad Mynhier cmynhier@gmail.com on 2010-Jan-20 14:26 -0500 EST
Workspace:/export/home/mynhier/src/dofusers-new (at c9ff9f81a992)
Compare against: ssh://anon@hg.opensolaris.org/hg/onnv/onnv-gate (at c9ff9f81a992)
Summary of changes: 290 lines changed: 180 ins; 27 del; 83 mod; 14958 unchg 
no comments found
 pm_13975_transport_errs_20Jan_7pm tag:cr.opensolaris.org,2010-01-20:~jmr/pm_13975_transport_errs_20Jan_7pm/2010-01-20T19:04:50Z 2010-01-20T19:04:50Z John Rice
John Rice [jmr's blog] posted a code review on 20 Jan 2010: pm_13975_transport_errs_20Jan_7pm.
John Rice [jmr's blog] posted a code review on 20 Jan 2010: pm_13975_transport_errs_20Jan_7pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-20 19:01 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at 6897b80bca9e)
Compare against: /export/home/jr140578/work/ips_gate_clean (at 6897b80bca9e)
Summary of changes: 96 lines changed: 36 ins; 13 del; 47 mod; 10114 unchg 
no comments found
 pm_8424_pm_out_of_memory_20Jan_550pm tag:cr.opensolaris.org,2010-01-20:~jmr/pm_8424_pm_out_of_memory_20Jan_550pm/2010-01-20T17:48:27Z 2010-01-20T17:48:27Z John Rice
John Rice [jmr's blog] posted a code review on 20 Jan 2010: pm_8424_pm_out_of_memory_20Jan_550pm.
John Rice [jmr's blog] posted a code review on 20 Jan 2010: pm_8424_pm_out_of_memory_20Jan_550pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-20 17:48 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at 3a71439a03f3)
Compare against: /export/home/jr140578/work/ips_gate_clean (at 3a71439a03f3)
Summary of changes: 34 lines changed: 27 ins; 1 del; 6 mod; 5859 unchg 
no comments found
 pm_8424_pm_out_of_memory_20Jan_535pm tag:cr.opensolaris.org,2010-01-20:~jmr/pm_8424_pm_out_of_memory_20Jan_535pm/2010-01-20T17:34:20Z 2010-01-20T17:34:20Z John Rice
John Rice [jmr's blog] posted a code review on 20 Jan 2010: pm_8424_pm_out_of_memory_20Jan_535pm.
John Rice [jmr's blog] posted a code review on 20 Jan 2010: pm_8424_pm_out_of_memory_20Jan_535pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-20 17:33 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at 3a71439a03f3)
Compare against: /export/home/jr140578/work/ips_gate_clean (at 3a71439a03f3)
Summary of changes: 19 lines changed: 18 ins; 0 del; 1 mod; 5865 unchg 
no comments found
 pm_8424_pm_out_of_memory_20Jan_5pm tag:cr.opensolaris.org,2010-01-20:~jmr/pm_8424_pm_out_of_memory_20Jan_5pm/2010-01-20T17:02:43Z 2010-01-20T17:02:43Z John Rice
John Rice [jmr's blog] posted a code review on 20 Jan 2010: pm_8424_pm_out_of_memory_20Jan_5pm.
John Rice [jmr's blog] posted a code review on 20 Jan 2010: pm_8424_pm_out_of_memory_20Jan_5pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-20 17:02 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at 3a71439a03f3)
Compare against: /export/home/jr140578/work/ips_gate_clean (at 3a71439a03f3)
Summary of changes: 13 lines changed: 12 ins; 0 del; 1 mod; 5865 unchg 
no comments found
 pm_8424_pm_out_of_memory_20Jan_4pm tag:cr.opensolaris.org,2010-01-20:~jmr/pm_8424_pm_out_of_memory_20Jan_4pm/2010-01-20T16:01:09Z 2010-01-20T16:01:09Z John Rice
John Rice [jmr's blog] posted a code review on 20 Jan 2010: pm_8424_pm_out_of_memory_20Jan_4pm.
John Rice [jmr's blog] posted a code review on 20 Jan 2010: pm_8424_pm_out_of_memory_20Jan_4pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-20 15:59 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at 3a71439a03f3)
Compare against: /export/home/jr140578/work/ips_gate_clean (at 3a71439a03f3)
Summary of changes: 15 lines changed: 14 ins; 0 del; 1 mod; 5865 unchg 
no comments found
 ips-13444-v3 tag:cr.opensolaris.org,2010-01-20:~padraig/ips-13444-v3/2010-01-20T15:02:04Z 2010-01-20T15:02:04Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 20 Jan 2010: ips-13444-v3.
Padraig O\'Briain [padraig] posted a code review on 20 Jan 2010: ips-13444-v3.

Code Review for 13444_clone

Prepared by:Padraig O'Briain padraig.obriain@sun.com on 2010-Jan-20 15:01 +0000 GMT
Workspace:/export/home/padraig/13444_clone (at 3a71439a03f3)
Compare against: /export/home/padraig/gate (at 3a71439a03f3)
Summary of changes: 10 lines changed: 2 ins; 2 del; 6 mod; 1227 unchg 
no comments found
 13977_v1 tag:cr.opensolaris.org,2010-01-20:~migi/13977_v1/2010-01-20T12:31:12Z 2010-01-20T12:31:12Z Michal Pryc
Michal Pryc [migi's blog] posted a code review on 20 Jan 2010: 13977_v1.
Michal Pryc [migi's blog] posted a code review on 20 Jan 2010: 13977_v1.

Code Review for GATE

Prepared by:Michal Pryc Michal.Pryc@Sun.Com on 2010-Jan-20 12:30 +0000 GMT
Workspace:/export/home/migi/Development/GATE (at 3a71439a03f3)
Compare against: ssh://migi@hg.opensolaris.org/hg/pkg/gate (at 3a71439a03f3)
Summary of changes: 2 lines changed: 1 ins; 0 del; 1 mod; 480 unchg 
no comments found
 pm_13975_transport_errs_20Jan_1130am tag:cr.opensolaris.org,2010-01-20:~jmr/pm_13975_transport_errs_20Jan_1130am/2010-01-20T11:34:34Z 2010-01-20T11:34:34Z John Rice
John Rice [jmr's blog] posted a code review on 20 Jan 2010: pm_13975_transport_errs_20Jan_1130am.
John Rice [jmr's blog] posted a code review on 20 Jan 2010: pm_13975_transport_errs_20Jan_1130am.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-20 11:27 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at 3a71439a03f3)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 3a71439a03f3)
Summary of changes: 93 lines changed: 35 ins; 13 del; 45 mod; 10114 unchg 
no comments found
 gktools_locking/webrev tag:cr.opensolaris.org,2010-01-20:~jmcp/gktools_locking/webrev/2010-01-20T10:45:29Z 2010-01-20T10:58:20Z James C. McPherson
James C. McPherson [jmcp's blog] posted a code review on 20 Jan 2010: gktools_locking/webrev.
James C. McPherson [jmcp's blog] posted a code review on 20 Jan 2010: gktools_locking/webrev.

Code Review for gk_tools_update

Prepared by:jmcp James.McPherson@Sun.COM on 2010-Jan-20 20:58 +1000 EST
Workspace:/scratch/src/build/rfes/gk_tools_update (at 8816d2caf700)
Compare against: ssh://anon@hg.opensolaris.org/hg/scm-migration/onnv-gk-tools (at c8144507d7ef)
Summary of changes: 20 lines changed: 19 ins; 1 del; 0 mod; 518 unchg 
fix the locking so incrementals don't overwrite themselves
ignore the gate write lock
make the notification more instructive
 bug-13393 tag:cr.opensolaris.org,2010-01-18:~dambi/bug-13393/2010-01-18T13:58:10Z 2010-01-20T09:28:50Z Jan Damborsky
Jan Damborsky [dambi] posted a code review on 20 Jan 2010: bug-13393.
Jan Damborsky [dambi] posted a code review on 20 Jan 2010: bug-13393.

Code Review for os-install-bug-13393

Prepared by:Jan Damborsky jan.damborsky@sun.com on 2010-Jan-20 10:28 +0100 CET
Workspace:/export/home/dambi/ws/os-install-bug-13393 (at 9e26e2dee251)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_source (at 39c6c403ab24)
Summary of changes: 74 lines changed: 69 ins; 0 del; 5 mod; 1274 unchg 
13393 min_mem64=1536 in AI GRUB menu should be revisited
 ips-13973-v1 tag:cr.opensolaris.org,2010-01-20:~padraig/ips-13973-v1/2010-01-20T08:30:04Z 2010-01-20T08:30:04Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 20 Jan 2010: ips-13973-v1.
Padraig O\'Briain [padraig] posted a code review on 20 Jan 2010: ips-13973-v1.

Code Review for 13973_gate

Prepared by:Padraig O'Briain padraig.obriain@sun.com on 2010-Jan-20 08:11 +0000 GMT
Workspace:/export/home/padraig/13973_gate (at 3a71439a03f3)
Compare against: /export/home/padraig/gate (at 3a71439a03f3)
Summary of changes: 4 lines changed: 4 ins; 0 del; 0 mod; 6510 unchg 
no comments found
 ips-9970-v1 tag:cr.opensolaris.org,2010-01-20:~bpytlik/ips-9970-v1/2010-01-20T00:42:46Z 2010-01-20T00:42:46Z Brock Pytlik
Brock Pytlik [bpytlik] posted a code review on 20 Jan 2010: ips-9970-v1.
Brock Pytlik [bpytlik] posted a code review on 20 Jan 2010: ips-9970-v1.

Code Review for recommit.bug-9970-v1

Prepared by:Brock Pytlik bpytlik@sun.com on 2010-Jan-19 16:42 -0800 PST
Workspace:/export/home/bpytlik/IPS/recommit.bug-9970-v1 (at 4007417acd97)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 3a71439a03f3)
Summary of changes: 113 lines changed: 8 ins; 49 del; 56 mod; 3293 unchg 
9970 pkg search pv doesn't return entire description
13928 multivalued description causes stack traces
 1000022_webrev_inc.1 tag:cr.opensolaris.org,2010-01-19:~swilcox/1000022_webrev_inc.1/2010-01-19T23:05:45Z 2010-01-19T23:05:45Z Sean D. Wilcox
Sean D. Wilcox [swilcox] posted a code review on 19 Jan 2010: 1000022_webrev_inc.1.
Sean D. Wilcox [swilcox] posted a code review on 19 Jan 2010: 1000022_webrev_inc.1.

Code Review for 1000022_webrev_inc.1

Prepared by:Sean Wilcox Sean.Wilcox@Sun.COM on 2010-Jan-19 15:05 -0800 PST
Workspace:/builds/swilcox/myEMI_gate (at 7539ce6101b9)
Compare against: webrev at 1000022_webrev.0
Summary of changes: 32 lines changed: 25 ins; 0 del; 7 mod; 16865 unchg 
1000022 multiple manifest services do not have instances removed when a single manifest is removed
1000023 Should only use one log file
 1000022_webrev.1 tag:cr.opensolaris.org,2010-01-19:~swilcox/1000022_webrev.1/2010-01-19T23:04:10Z 2010-01-19T23:04:10Z Sean D. Wilcox
Sean D. Wilcox [swilcox] posted a code review on 19 Jan 2010: 1000022_webrev.1.
Sean D. Wilcox [swilcox] posted a code review on 19 Jan 2010: 1000022_webrev.1.

Code Review for 1000022_webrev.1

Prepared by:Sean Wilcox Sean.Wilcox@Sun.COM on 2010-Jan-19 15:04 -0800 PST
Workspace:/builds/swilcox/myEMI_gate (at 7539ce6101b9)
Compare against: http://kodiak.sfbay:9181 (at c94dbde63290)
Summary of changes: 160 lines changed: 113 ins; 34 del; 13 mod; 16771 unchg 
1000022 multiple manifest services do not have instances removed when a single manifest is removed
1000023 Should only use one log file
 pkg-3005 tag:cr.opensolaris.org,2010-01-19:~swalker/pkg-3005/2010-01-19T22:55:10Z 2010-01-19T22:55:10Z Shawn Walker
Shawn Walker [swalker's blog] posted a code review on 19 Jan 2010: pkg-3005.
Shawn Walker [swalker's blog] posted a code review on 19 Jan 2010: pkg-3005.

Code Review for pkg-3005

Prepared by:Shawn Walker srw@sun.com on 2010-Jan-19 16:55 -0600 CST
Workspace:/export/home/swalker/devel/pkg-3005 (at 71130b406344)
Compare against: /export/home/swalker/devel/pkg-tip (at 027b61eb249c)
Summary of changes: 646 lines changed: 359 ins; 52 del; 235 mod; 21638 unchg 
3005 some pkg verify errors should be warnings or informational messages
 ips-13059-v2 tag:cr.opensolaris.org,2010-01-19:~bpytlik/ips-13059-v2/2010-01-19T22:51:05Z 2010-01-19T22:51:05Z Brock Pytlik
Brock Pytlik [bpytlik] posted a code review on 19 Jan 2010: ips-13059-v2.
Brock Pytlik [bpytlik] posted a code review on 19 Jan 2010: ips-13059-v2.

Code Review for recommit.bug-13059-v2

Prepared by:Brock Pytlik bpytlik@sun.com on 2010-Jan-19 14:51 -0800 PST
Workspace:/export/home/bpytlik/IPS/recommit.bug-13059-v2 (at fba707d9a4ff)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 13280d5e53d2)
Summary of changes: 920 lines changed: 754 ins; 82 del; 84 mod; 4936 unchg 
13059 pkgdep generate should analyze python modules using the version of python they use
13835 api_inst no longer needed by find_package
13843 ModuleInfo __str__ should work
13838 make_paths in dependencies.py needs to cope with rp's which are a string, instead of a list
 bug13488 tag:cr.opensolaris.org,2010-01-19:~joev/bug13488/2010-01-19T21:46:26Z 2010-01-19T21:46:26Z Joseph VLcek
Joseph VLcek [joev] posted a code review on 19 Jan 2010: bug13488.
Joseph VLcek [joev] posted a code review on 19 Jan 2010: bug13488.

Code Review for bug13488

Prepared by:Joseph J Vlcek Joseph.Vlcek@Sun.COM on 2010-Jan-19 15:01 -0700 MST
Workspace:/export/home/jv35168/bug13488 (at fe62a074d0cb)
Compare against: ssh://joev@hg.opensolaris.org/hg/caiman/slim_source (at 4cd5a9a2640b)
Summary of changes: 6 lines changed: 0 ins; 0 del; 6 mod; 106 unchg 
13488 LiveCD changes required for new GDM
 ptop-usage tag:cr.opensolaris.org,2010-01-14:~rafaelv/ptop-usage/2010-01-14T22:32:46Z 2010-01-19T19:24:56Z Rafael Vanoni
Rafael Vanoni [rafaelv's blog] posted a code review on 19 Jan 2010: ptop-usage.
Rafael Vanoni [rafaelv's blog] posted a code review on 19 Jan 2010: ptop-usage.

Code Review for ptop-usage

Prepared by:Rafael Vanoni rafael.vanoni@sun.com on 2010-Jan-19 11:24 -0800 PST
Workspace:/builds/rv207048/ptop-usage (at 29d2435ea436)
Compare against: ssh://onnv.sfbay.sun.com//export/onnv-clone (at 69b45e632792)
Summary of changes: 7 lines changed: 5 ins; 0 del; 2 mod; 413 unchg 
6911087 powertop(1) doesn't exit when given incorrect arguments after snv_129
 webrev.pkgmetadata.1-2 tag:cr.opensolaris.org,2010-01-19:~mjnelson/webrev.pkgmetadata.1-2/2010-01-19T19:06:36Z 2010-01-19T19:06:36Z Mark J. Nelson
Mark J. Nelson [mjnelson's blog] posted a code review on 19 Jan 2010: webrev.pkgmetadata.1-2.
Mark J. Nelson [mjnelson's blog] posted a code review on 19 Jan 2010: webrev.pkgmetadata.1-2.

Code Review for webrev.pkgmetadata.1-2

Prepared by:Mark J. Nelson Mark.J.Nelson@Sun.COM on 2010-Jan-19 12:00 -0700 MST
Workspace:/export/ws/mjnelson/on-ips-work (at 8043cdb5c1b0)
Compare against: webrev at webrev.pkgmetadata
Summary of changes: 166 lines changed: 17 ins; 124 del; 25 mod; 3733 unchg 
11127 need to handle export build
11131 aggregate_package is pretty dumb
11148 developer/opensolaris/osnet should allow for SUNWonbld updates
13565 nightly mail_msg shouldn't contain manifest build output
13932 package makefiles should not contain package metadata
 webrev.pkgmetadata.2 tag:cr.opensolaris.org,2010-01-19:~mjnelson/webrev.pkgmetadata.2/2010-01-19T19:06:30Z 2010-01-19T19:06:30Z Mark J. Nelson
Mark J. Nelson [mjnelson's blog] posted a code review on 19 Jan 2010: webrev.pkgmetadata.2.
Mark J. Nelson [mjnelson's blog] posted a code review on 19 Jan 2010: webrev.pkgmetadata.2.

Code Review for webrev.pkgmetadata.2

Prepared by:Mark J. Nelson Mark.J.Nelson@Sun.COM on 2010-Jan-19 12:00 -0700 MST
Workspace:/export/ws/mjnelson/on-ips-work (at 8043cdb5c1b0)
Compare against: ssh://anon@hg.opensolaris.org//hg/pkg/on_ips (at 1e7cc27e04eb)
Summary of changes: 859 lines changed: 305 ins; 360 del; 194 mod; 3276 unchg 
11127 need to handle export build
11131 aggregate_package is pretty dumb
11148 developer/opensolaris/osnet should allow for SUNWonbld updates
13565 nightly mail_msg shouldn't contain manifest build output
13932 package makefiles should not contain package metadata
 bug_6875154 tag:cr.opensolaris.org,2009-11-23:~ksadhukh/bug_6875154/2009-11-23T23:00:30Z 2010-01-19T17:55:14Z Krishnendu Sadhukhan
Krishnendu Sadhukhan [ksadhukh] posted a code review on 19 Jan 2010: bug_6875154.
Krishnendu Sadhukhan [ksadhukh] posted a code review on 19 Jan 2010: bug_6875154.

Code Review for bug_6875154

Prepared by:Krishnendu Sadhukhan - Sun Microsystems Krishnendu.Sadhukhan@Sun.COM on 2010-Jan-19 09:55 -0800 PST
Workspace:/export/ksadhukh/bug_6875154 (at 7709077cafee)
Compare against: /ws/onnv-clone (at 11ccf37e57ed)
Summary of changes: 61 lines changed: 20 ins; 32 del; 9 mod; 17866 unchg 
6875154 6801244 fix misses corner case
Contributed by Chad Mynhier cmynhier@gmail.com
 pm_13756_search_over_reporting_19Jan_333pm tag:cr.opensolaris.org,2010-01-19:~jmr/pm_13756_search_over_reporting_19Jan_333pm/2010-01-19T15:33:45Z 2010-01-19T15:33:45Z John Rice
John Rice [jmr's blog] posted a code review on 19 Jan 2010: pm_13756_search_over_reporting_19Jan_333pm.
John Rice [jmr's blog] posted a code review on 19 Jan 2010: pm_13756_search_over_reporting_19Jan_333pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-19 15:33 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at 027b61eb249c)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 027b61eb249c)
Summary of changes: 50 lines changed: 30 ins; 8 del; 12 mod; 12152 unchg 
no comments found
 13858_v2 tag:cr.opensolaris.org,2010-01-19:~migi/13858_v2/2010-01-19T14:33:10Z 2010-01-19T14:33:10Z Michal Pryc
Michal Pryc [migi's blog] posted a code review on 19 Jan 2010: 13858_v2.
Michal Pryc [migi's blog] posted a code review on 19 Jan 2010: 13858_v2.

Code Review for GATE

Prepared by:Michal Pryc Michal.Pryc@Sun.Com on 2010-Jan-19 14:32 +0000 GMT
Workspace:/export/home/migi/Development/GATE (at 9e78475ffee1)
Compare against: ssh://migi@hg.opensolaris.org/hg/pkg/gate (at 9e78475ffee1)
Summary of changes: 51 lines changed: 40 ins; 0 del; 11 mod; 1185 unchg 
no comments found
 pm_13756_search_over_reporting_19Jan_145pm tag:cr.opensolaris.org,2010-01-19:~jmr/pm_13756_search_over_reporting_19Jan_145pm/2010-01-19T13:45:31Z 2010-01-19T13:45:31Z John Rice
John Rice [jmr's blog] posted a code review on 19 Jan 2010: pm_13756_search_over_reporting_19Jan_145pm.
John Rice [jmr's blog] posted a code review on 19 Jan 2010: pm_13756_search_over_reporting_19Jan_145pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-19 13:40 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at 9e78475ffee1)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 9e78475ffee1)
Summary of changes: 48 lines changed: 28 ins; 8 del; 12 mod; 12138 unchg 
no comments found
 pm_13736_pm_hang_transport_err_19Jan_1140am tag:cr.opensolaris.org,2010-01-19:~jmr/pm_13736_pm_hang_transport_err_19Jan_1140am/2010-01-19T11:42:09Z 2010-01-19T11:42:09Z John Rice
John Rice [jmr's blog] posted a code review on 19 Jan 2010: pm_13736_pm_hang_transport_err_19Jan_1140am.
John Rice [jmr's blog] posted a code review on 19 Jan 2010: pm_13736_pm_hang_transport_err_19Jan_1140am.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on 2010-Jan-19 11:41 +0000 GMT
Workspace:/export/home/jr140578/work/ips_gate (at 9e78475ffee1)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 9e78475ffee1)
Summary of changes: 16 lines changed: 14 ins; 0 del; 2 mod; 5837 unchg 
no comments found
 fix-13778.pkg tag:cr.opensolaris.org,2010-01-19:~rbalada/fix-13778.pkg/2010-01-19T10:11:10Z 2010-01-19T10:11:10Z Rudolf Balada
Rudolf Balada [rbalada] posted a code review on 19 Jan 2010: fix-13778.pkg.
Rudolf Balada [rbalada] posted a code review on 19 Jan 2010: fix-13778.pkg.

Code Review for fix-13778.pkg

Prepared by:Rudolf Balada Rudolf.Balada@Sun.COM on 2010-Jan-19 11:11 +0100 CET
Workspace:/export/home/tester/pkg/bugs/13778/fix-13778.pkg (at 2679e6b10e71)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 9e78475ffee1)
Summary of changes: 1 line changed: 0 ins; 0 del; 1 mod; 12 unchg 
13778 - Update Eclipse from 3.4.2 to 3.5.1
 bug-13331 tag:cr.opensolaris.org,2010-01-19:~wmsch/bug-13331/2010-01-19T08:58:10Z 2010-01-19T08:58:10Z William Schumann
William Schumann [wmsch] posted a code review on 19 Jan 2010: bug-13331.
William Schumann [wmsch] posted a code review on 19 Jan 2010: bug-13331.

Code Review for alt

Prepared by:William Schumann william.schumann@sun.com on 2010-Jan-19 01:58 -0700 MST
Workspace:/export/home/ws199450/alt (at e63c1475e17e)
Compare against: ssh://wmsch@hg.opensolaris.org/hg/caiman/slim_source (at 1cb4b13c8892)
Summary of changes: 26 lines changed: 24 ins; 1 del; 1 mod; 1998 unchg 
13331 - auto-install creates bogus partition table
 ips-13444-v2 tag:cr.opensolaris.org,2010-01-19:~padraig/ips-13444-v2/2010-01-19T08:31:27Z 2010-01-19T08:31:27Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 19 Jan 2010: ips-13444-v2.
Padraig O\'Briain [padraig] posted a code review on 19 Jan 2010: ips-13444-v2.

Code Review for 13444_gate

Prepared by:Padraig O'Briain padraig.obriain@sun.com on 2010-Jan-19 08:23 +0000 GMT
Workspace:/export/home/padraig/13444_gate (at 19c85bdf5c1d)
Compare against: /export/home/padraig/gate (at 19c85bdf5c1d)
Summary of changes: 11 lines changed: 2 ins; 3 del; 6 mod; 1187 unchg 
no comments found
 6795293 tag:cr.opensolaris.org,2010-01-18:~sjelinek/6795293/2010-01-18T20:54:26Z 2010-01-18T20:54:26Z Sarah J. Jelinek
Sarah J. Jelinek [sjelinek] posted a code review on 18 Jan 2010: 6795293.
Sarah J. Jelinek [sjelinek] posted a code review on 18 Jan 2010: 6795293.

Code Review for 6795293

Prepared by:Sarah Jelinek Sarah.Jelinek@Sun.COM on 2010-Jan-18 15:51 -0500 EST
Workspace:/export/build/sjelinek/on_build/onnv-clone (at b9cd3c4fe749)
Compare against: ssh://sjelinek@onnv.sfbay.sun.com//export/onnv-clone (at 887ee1196411)
Summary of changes: 811 lines changed: 190 ins; 120 del; 501 mod; 1260 unchg 
6795293 libdiskmgt coredump on x86 with devices under mpxio control/SUN-Universal Xport inbound mangement
 webrev.6887823 tag:cr.opensolaris.org,2010-01-18:~gjelinek/webrev.6887823/2010-01-18T20:25:16Z 2010-01-18T20:25:16Z Gerald A. Jelinek
Gerald A. Jelinek [gjelinek] posted a code review on 18 Jan 2010: webrev.6887823.
Gerald A. Jelinek [gjelinek] posted a code review on 18 Jan 2010: webrev.6887823.

Code Review for on

Prepared by:gerald.jelinek@sun.com on 2010-Jan-18 13:24 -0700 MST
Workspace:/export/ws/on (at 9575bbfcc567)
Compare against: ssh://onnv.sfbay.sun.com//export/onnv-clone (at 3e8510aaac0f)
Summary of changes: 1096 lines changed: 111 ins; 833 del; 152 mod; 3170 unchg 
6887823 brandz on x86 should ignore %gs and simplify brand hooks
 13104-followup tag:cr.opensolaris.org,2010-01-18:~migi/13104-followup/2010-01-18T16:40:58Z 2010-01-18T16:40:58Z Michal Pryc
Michal Pryc [migi's blog] posted a code review on 18 Jan 2010: 13104-followup.
Michal Pryc [migi's blog] posted a code review on 18 Jan 2010: 13104-followup.

Code Review for IPS_GATE_MIGI

Prepared by:Michal Pryc Michal.Pryc@Sun.Com on 2010-Jan-18 16:40 +0000 GMT
Workspace:/export/home/migi/Development/IPS_GATE_MIGI (at 6affe8f8586b)
Compare against: ssh://migi@hg.opensolaris.org/hg/pkg/gate (at 6affe8f8586b)
Summary of changes: 1 line changed: 0 ins; 0 del; 1 mod; 5831 unchg 
no comments found