Recently Published Codereviews 2009-11-07T14:38:12Z urn:uuid:d99fa050-ddf7-11dc-95ff-0800200c9a66 blk2scsa-dma tag:cr.opensolaris.org,2009-10-27:~gdamore/blk2scsa-dma/2009-10-27T05:42:18Z 2009-11-07T07:05:18Z Garrett D\'Amore
Garrett D\'Amore [gdamore's blog] posted a code review on 07 Nov 2009: blk2scsa-dma.
Garrett D\'Amore [gdamore's blog] posted a code review on 07 Nov 2009: blk2scsa-dma.

Code Review for blk2scsa

Prepared by:Garrett D'Amore gdamore@opensolaris.org on Friday, November 6, 2009 11:05:18 PM PST
Workspace:/work/gdamore/ddr/blk2scsa (at 7279de9592e3)
Compare against: ssh://anonhg@onnv.sfbay//export/onnv-clone (at 6e5cc5c0a74f)
Summary of changes: 102 lines changed: 30 ins; 46 del; 26 mod; 2106 unchg 
PSARC 2009/608 blk2scsa VPD83 support
6899046 blk2scsa needs to vendor page 83 support
6899045 blk2scsa needs to support DMA
 sfwnv-cups-tx tag:cr.opensolaris.org,2009-10-28:~jacobs/sfwnv-cups-tx/2009-10-28T20:59:18Z 2009-11-07T06:08:19Z Norm Jacobs
Norm Jacobs [jacobs's blog] posted a code review on 07 Nov 2009: sfwnv-cups-tx.
Norm Jacobs [jacobs's blog] posted a code review on 07 Nov 2009: sfwnv-cups-tx.

Code Review for sfwnv-cups

Prepared by:Norman Jacobs (jacobs) on 2009-Nov-06 22:07 -0800 PST
Workspace:/builds1/jacobs/sfwnv-cups
Compare against: /ws/sfwnv-clone
Summary of changes: 758 lines changed: 756 ins; 0 del; 2 mod; 1103 unchg 
6893007 cups should include TX support
 cups-tx tag:cr.opensolaris.org,2009-10-28:~jacobs/cups-tx/2009-10-28T21:02:25Z 2009-11-07T05:50:50Z Norm Jacobs
Norm Jacobs [jacobs's blog] posted a code review on 07 Nov 2009: cups-tx.
Norm Jacobs [jacobs's blog] posted a code review on 07 Nov 2009: cups-tx.

Code Review for cups-tx

Prepared by:Norman Jacobs (jacobs) on 2009-Nov-06 21:50 -0800 PST
Workspace:/builds/jacobs/cups-tx
Compare against:
Summary of changes: 453 lines changed: 447 ins; 1 del; 5 mod; 27761 unchg 
no comments found
 vmlgrp.2 tag:cr.opensolaris.org,2009-11-07:~mec/vmlgrp.2/2009-11-07T01:32:04Z 2009-11-07T01:34:29Z Michael E. Corcoran
Michael E. Corcoran [mec] posted a code review on 07 Nov 2009: vmlgrp.2.
Michael E. Corcoran [mec] posted a code review on 07 Nov 2009: vmlgrp.2.

Code Review for intel-hotplug

Prepared by:Michael Corcoran Michael.Corcoran@Sun.COM on 2009-Nov-06 17:33 -0800 PST
Workspace:/export/mec/numa_cloned/intel/cpu-hotplug/dr_framework/intel-hotplug (at 40c5e48fa41c)
Compare against: ssh://mec@hg.opensolaris.org//hg/intel-platform/intel-hotplug (at e7eda6eee343)
Summary of changes: 64 lines changed: 41 ins; 13 del; 10 mod; 3501 unchg 
allow multiple mnodes per leaf lgroup
 pkg-gate1106 tag:cr.opensolaris.org,2009-11-07:~erisch/pkg-gate1106/2009-11-07T00:47:42Z 2009-11-07T00:47:42Z Erik Trauschke
Erik Trauschke [erisch] posted a code review on 07 Nov 2009: pkg-gate1106.
Erik Trauschke [erisch] posted a code review on 07 Nov 2009: pkg-gate1106.

Code Review for pkg-gate

Prepared by:Erik Trauschke Erik.Trauschke@Sun.COM on Fri Nov 6 16:47:23 PST 2009
Workspace:/export/work/pkg/pkg-gate (at dd6d99950746)
Compare against: ssh://Tpkg@hg.opensolaris.org//hg/pkg/gate (at bd6ffa78fed9)
Summary of changes: 33 lines changed: 29 ins; 0 del; 4 mod; 355 unchg 
fix for 12477
 pkg-gate1106b tag:cr.opensolaris.org,2009-11-07:~erisch/pkg-gate1106/2009-11-07T00:41:27Z 2009-11-07T00:41:27Z Erik Trauschke
Erik Trauschke [erisch] posted a code review on 07 Nov 2009: pkg-gate1106b.
Erik Trauschke [erisch] posted a code review on 07 Nov 2009: pkg-gate1106b.

Code Review for pkg-gate

Prepared by:Erik Trauschke Erik.Trauschke@Sun.COM on Fri Nov 6 16:40:37 PST 2009
Workspace:/export/work/pkg/pkg-gate (at dd6d99950746)
Compare against: ssh://Tpkg@hg.opensolaris.org//hg/pkg/gate (at bd6ffa78fed9)
Summary of changes: 32 lines changed: 28 ins; 0 del; 4 mod; 355 unchg 
fix for 12477
 pkg-gate1106m tag:cr.opensolaris.org,2009-11-07:~erisch/pkg-gate1106m/2009-11-07T00:36:12Z 2009-11-07T00:36:12Z Erik Trauschke
Erik Trauschke [erisch] posted a code review on 07 Nov 2009: pkg-gate1106m.
Erik Trauschke [erisch] posted a code review on 07 Nov 2009: pkg-gate1106m.

Code Review for pkg-gate

Prepared by:Erik Trauschke Erik.Trauschke@Sun.COM on Fri Nov 6 16:35:39 PST 2009
Workspace:/export/work/pkg/pkg-gate (at bd6ffa78fed9)
Compare against: ssh://Tpkg@hg.opensolaris.org//hg/pkg/gate (at bd6ffa78fed9)
Summary of changes: 32 lines changed: 28 ins; 0 del; 4 mod; 355 unchg 
no comments found
 EMI_webrev_inc.3 tag:cr.opensolaris.org,2009-11-06:~swilcox/EMI_webrev_inc.3/2009-11-06T23:28:14Z 2009-11-07T00:01:51Z Sean D. Wilcox
Sean D. Wilcox [swilcox] posted a code review on 07 Nov 2009: EMI_webrev_inc.3.
Sean D. Wilcox [swilcox] posted a code review on 07 Nov 2009: EMI_webrev_inc.3.

Code Review for webrev_inc.3

Prepared by:Sean Wilcox Sean.Wilcox@Sun.COM on 2009-Nov-06 16:01 -0800 PST
Workspace:/builds/swilcox/myEMI_gate (at 4a62a47f3eca)
Compare against: webrev at webrev.2
Summary of changes: 2 lines changed: 1 ins; 1 del; 0 mod; 1865 unchg 
prototype build errors
manifest-import import modifications
netservices update to create links in the correct location
 EMI_webrev.3 tag:cr.opensolaris.org,2009-11-06:~swilcox/EMI_webrev.3/2009-11-06T23:24:54Z 2009-11-07T00:00:53Z Sean D. Wilcox
Sean D. Wilcox [swilcox] posted a code review on 07 Nov 2009: EMI_webrev.3.
Sean D. Wilcox [swilcox] posted a code review on 07 Nov 2009: EMI_webrev.3.

Code Review for webrev.3

Prepared by:Sean Wilcox Sean.Wilcox@Sun.COM on 2009-Nov-06 16:00 -0800 PST
Workspace:/builds/swilcox/myEMI_gate (at 4a62a47f3eca)
Compare against: ssh://swilcox@hg.opensolaris.org//hg/smf-doc/smf-emi (at c883bc19d858)
Summary of changes: 112 lines changed: 25 ins; 65 del; 22 mod; 1819 unchg 
prototype build errors
manifest-import import modifications
netservices update to create links in the correct location
 11680_3 tag:cr.opensolaris.org,2009-11-06:~luisbg/11680_3/2009-11-06T23:57:51Z 2009-11-06T23:57:51Z Luis de Bethencourt
Luis de Bethencourt [luisbg's blog] posted a code review on 06 Nov 2009: 11680_3.
Luis de Bethencourt [luisbg's blog] posted a code review on 06 Nov 2009: 11680_3.

Code Review for slim_source

Prepared by:Luis de Bethencourt luisbg@sun.com on 2009-Nov-07 00:56 +0000 GMT
Workspace:/export/home/luisbg/development/webrev/slim_source (at e84402006fa5)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_source (at e84402006fa5)
Summary of changes: 2233 lines changed: 756 ins; 648 del; 829 mod; 288 unchg 
no comments found
 091101.1/webrev tag:cr.opensolaris.org,2009-11-06:~schwartz/091101.1/webrev/2009-11-06T23:52:59Z 2009-11-06T23:52:59Z Jack A. Schwartz
Jack A. Schwartz [schwartz] posted a code review on 06 Nov 2009: 091101.1/webrev.
Jack A. Schwartz [schwartz] posted a code review on 06 Nov 2009: 091101.1/webrev.

Code Review for python26

Prepared by:Jack Schwartz Jack.A.Schwartz@Sun.COM on 2009-Nov-06 15:46 -0800 PST
Workspace:/home/schwartz/gates/python26 (at 1650e5841f78)
Compare against: http://indiana-build.central:8081 (at f36eaae56b3b)
Summary of changes: 5838 lines changed: 1414 ins; 1561 del; 2863 mod; 1727 unchg 
12466 Update ManifestServ and finalizer to work with python version 2.6
 091101.1/webrev-2-1-diff tag:cr.opensolaris.org,2009-11-06:~schwartz/091101.1/webrev-2-1-diff/2009-11-06T23:52:38Z 2009-11-06T23:52:38Z Jack A. Schwartz
Jack A. Schwartz [schwartz] posted a code review on 06 Nov 2009: 091101.1/webrev-2-1-diff.
Jack A. Schwartz [schwartz] posted a code review on 06 Nov 2009: 091101.1/webrev-2-1-diff.

Code Review for python26

Prepared by:Jack Schwartz Jack.A.Schwartz@Sun.COM on 2009-Nov-06 15:44 -0800 PST
Workspace:/home/schwartz/gates/python26 (at 1650e5841f78)
Compare against: ../python26-cr1 (at d8ec8a7eed3a)
Summary of changes: 8826 lines changed: 2036 ins; 1879 del; 4911 mod; 17764 unchg 
Python 2.4-2.6 bridge conversion and Makefile conversion
12391 Transition from Python2.4 to Python2.6 - AI client portion
AI client - PEP8 changes
12459 AI hangs if "Disk doesn't contain valid Solaris partition"
cstyle nit: cmd/auto-install/auto_parse_manifest.c: 186: space after cast
12192 RFE: Supply x86 usb image for bootable AI
12466 Update ManifestServ and finalizer to work with python version 2.6
installadm fixes
12521 - libaiscf_pymod: needs to be linked against /usr/lib/libscf!
3136 TI fails to create VTOC on unlabeled disk on Sparc
12476 migrate libtransfer to python2.6
 webrev.osolify tag:cr.opensolaris.org,2009-11-06:~mjnelson/webrev.osolify/2009-11-06T07:26:51Z 2009-11-06T23:40:28Z Mark J. Nelson
Mark J. Nelson [mjnelson's blog] posted a code review on 06 Nov 2009: webrev.osolify.
Mark J. Nelson [mjnelson's blog] posted a code review on 06 Nov 2009: webrev.osolify.

Code Review for webrev.osolify

Prepared by:Mark J. Nelson Mark.J.Nelson@Sun.COM on Friday, November 6, 2009 4:36:58 PM MST
Workspace:/export/ws/mjnelson/on-ips-work (at 1d48bd7ef2cb)
Compare against: ssh://anon@hg.opensolaris.org//hg/pkg/on_ips (at cb9400c6ddfe)
Summary of changes: 465 lines changed: 70 ins; 370 del; 25 mod; 14880 unchg 
11125 some opensolaris additions and modifications aren't included
11132 shouldn't check ksh binary wrapper in
 11680_2 tag:cr.opensolaris.org,2009-11-06:~luisbg/11680_2/2009-11-06T23:11:49Z 2009-11-06T23:11:49Z Luis de Bethencourt
Luis de Bethencourt [luisbg's blog] posted a code review on 06 Nov 2009: 11680_2.
Luis de Bethencourt [luisbg's blog] posted a code review on 06 Nov 2009: 11680_2.

Code Review for slim_source

Prepared by:Luis de Bethencourt luisbg@sun.com on 2009-Nov-07 00:12 +0000 GMT
Workspace:/export/home/luisbg/development/webrev/slim_source (at e84402006fa5)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_source (at e84402006fa5)
Summary of changes: 2230 lines changed: 757 ins; 644 del; 829 mod; 292 unchg 
no comments found
 12532_2 tag:cr.opensolaris.org,2009-11-06:~luisbg/12532_2/2009-11-06T23:02:16Z 2009-11-06T23:02:16Z Luis de Bethencourt
Luis de Bethencourt [luisbg's blog] posted a code review on 06 Nov 2009: 12532_2.
Luis de Bethencourt [luisbg's blog] posted a code review on 06 Nov 2009: 12532_2.

Code Review for slim_source

Prepared by:Luis de Bethencourt luisbg@sun.com on 2009-Nov-07 00:00 +0000 GMT
Workspace:/export/home/luisbg/development/webrev/slim_source (at e84402006fa5)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_source (at e84402006fa5)
Summary of changes: 15 lines changed: 1 ins; 0 del; 14 mod; 351 unchg 
no comments found
 b128.3/webrev tag:cr.opensolaris.org,2009-11-03:~sn123202/b128.3/webrev/2009-11-03T22:48:56Z 2009-11-06T22:55:50Z Sriram Natarajan
Sriram Natarajan [sn123202] posted a code review on 06 Nov 2009: b128.3/webrev.
Sriram Natarajan [sn123202] posted a code review on 06 Nov 2009: b128.3/webrev.

Code Review for php-gate

Prepared by:Sriram Natarajan (sn123202) on 2009-Nov-06 14:55 -0800 PST
Workspace:/builds/sn123202/php-gate
Compare against: /ws/sfwnv-gate
Summary of changes: 6486 lines changed: 5464 ins; 986 del; 36 mod; 2987 unchg 
6877619 remove redundant PHP DTrace extension
6893914 split 3rd party extensions into its own packages
 intel.genericevents tag:cr.opensolaris.org,2009-11-06:~kuriakos/intel.genericevents/2009-11-06T22:46:19Z 2009-11-06T22:46:19Z Kuriakose Kuruvilla
Kuriakose Kuruvilla [kuriakos] posted a code review on 06 Nov 2009: intel.genericevents.
Kuriakose Kuruvilla [kuriakos] posted a code review on 06 Nov 2009: intel.genericevents.

Code Review for g

Prepared by:Kuriakose Kuruvilla Kuriakose.Kuruvilla@Sun.COM on 2009-Nov-06 14:29 -0800 PST
Workspace:/export/kk208521/g (at cddc713b3d25)
Compare against: ssh://anonhg@onnv//export/onnv-clone (at 881ceecbca49)
Summary of changes: 279 lines changed: 218 ins; 15 del; 46 mod; 1715 unchg 
6750860 core_pcbe back-end needs to support generic events
 sleep-4175 tag:cr.opensolaris.org,2009-11-06:~johnfisc/sleep-4175/2009-11-06T22:38:17Z 2009-11-06T22:38:17Z John Fischer
John Fischer [johnfisc] posted a code review on 06 Nov 2009: sleep-4175.
John Fischer [johnfisc] posted a code review on 06 Nov 2009: sleep-4175.

Code Review for slim_source

Prepared by:John Fischer (johnf) on 2009-Nov-06 14:38 -0800 PST
Workspace:/export/home/johnf/projects/auto-install/slim_source (at e84402006fa5)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_source (at e84402006fa5)
Summary of changes: 3 lines changed: 0 ins; 0 del; 3 mod; 460 unchg 
4175 - install list error slips out (edit)
       -- one last set of sleeps for this defect
 11680 tag:cr.opensolaris.org,2009-11-06:~luisbg/11680/2009-11-06T22:34:18Z 2009-11-06T22:34:18Z Luis de Bethencourt
Luis de Bethencourt [luisbg's blog] posted a code review on 06 Nov 2009: 11680.
Luis de Bethencourt [luisbg's blog] posted a code review on 06 Nov 2009: 11680.

Code Review for slim_source

Prepared by:Luis de Bethencourt luisbg@sun.com on 2009-Nov-06 23:34 +0000 GMT
Workspace:/export/home/luisbg/development/webrev/slim_source (at e84402006fa5)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_source (at e84402006fa5)
Summary of changes: 2230 lines changed: 757 ins; 644 del; 829 mod; 292 unchg 
no comments found
 path-7325 tag:cr.opensolaris.org,2009-11-06:~johnfisc/path-7325/2009-11-06T22:23:23Z 2009-11-06T22:23:23Z John Fischer
John Fischer [johnfisc] posted a code review on 06 Nov 2009: path-7325.
John Fischer [johnfisc] posted a code review on 06 Nov 2009: path-7325.

Code Review for slim_source

Prepared by:John Fischer (johnf) on 2009-Nov-06 14:23 -0800 PST
Workspace:/export/home/johnf/projects/auto-install/slim_source (at e84402006fa5)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_source (at e84402006fa5)
Summary of changes: 9 lines changed: 9 ins; 0 del; 0 mod; 482 unchg 
7325 - installadm script should set PATH
     added a putenv for an appropriate path
 EMI_webrev_inc.2 tag:cr.opensolaris.org,2009-11-06:~swilcox/EMI_webrev_inc.2/2009-11-06T22:10:31Z 2009-11-06T22:10:31Z Sean D. Wilcox
Sean D. Wilcox [swilcox] posted a code review on 06 Nov 2009: EMI_webrev_inc.2.
Sean D. Wilcox [swilcox] posted a code review on 06 Nov 2009: EMI_webrev_inc.2.

Code Review for webrev_inc.2

Prepared by:Sean Wilcox Sean.Wilcox@Sun.COM on 2009-Nov-06 14:10 -0800 PST
Workspace:/builds/swilcox/myEMI_gate (at 799618816e97)
Compare against: webrev at webrev.1
Summary of changes: 9 lines changed: 4 ins; 3 del; 2 mod; 1860 unchg 
prototype build errors
manifest-import import modifications
netservices update to create links in the correct location
 EMI_webrev.2 tag:cr.opensolaris.org,2009-11-06:~swilcox/EMI_webrev.2/2009-11-06T22:09:54Z 2009-11-06T22:09:54Z Sean D. Wilcox
Sean D. Wilcox [swilcox] posted a code review on 06 Nov 2009: EMI_webrev.2.
Sean D. Wilcox [swilcox] posted a code review on 06 Nov 2009: EMI_webrev.2.

Code Review for webrev.2

Prepared by:Sean Wilcox Sean.Wilcox@Sun.COM on 2009-Nov-06 14:09 -0800 PST
Workspace:/builds/swilcox/myEMI_gate (at 799618816e97)
Compare against: ssh://swilcox@hg.opensolaris.org//hg/smf-doc/smf-emi (at c883bc19d858)
Summary of changes: 112 lines changed: 25 ins; 65 del; 22 mod; 1819 unchg 
prototype build errors
manifest-import import modifications
netservices update to create links in the correct location
 CR6871404 tag:cr.opensolaris.org,2009-11-04:~tekgrrl/CR6871404/2009-11-04T14:10:22Z 2009-11-06T21:31:37Z Amanda Waite
Amanda Waite [tekgrrl's blog] posted a code review on 06 Nov 2009: CR6871404.
Amanda Waite [tekgrrl's blog] posted a code review on 06 Nov 2009: CR6871404.

Code Review for CR6871404

Prepared by:Amanda Waite (aw74431) on 2009-Nov-06 13:31 -0800 PST
Workspace:/export/workspace/amanda/lighttpdUpdate
Compare against: /ws/sfwnv-clone
Summary of changes: 661 lines changed: 583 ins; 34 del; 44 mod; 6985 unchg 
6879769 Lighttpd community recommends not to use multiple Lighttpd workers
6871404 Update Lighttpd in OpenSolaris to v1.4.23
6812193 lighttpd14 should take advantage of lua after snv_110
6790767 default lighttpd.conf need to reflect opesolararis file locations
6898070 Move the lighttpd spawn-fcgi utility and man page to a separate package
 PY26 tag:cr.opensolaris.org,2009-11-06:~joev/PY26/2009-11-06T21:09:29Z 2009-11-06T21:09:29Z Joseph VLcek
Joseph VLcek [joev] posted a code review on 06 Nov 2009: PY26.
Joseph VLcek [joev] posted a code review on 06 Nov 2009: PY26.

Code Review for PY26

Prepared by:Joseph Vlcek (jv35168) on 2009-Nov-06 14:17 -0700 MST
Workspace:/export/home/jv35168/PY26 (at f36eaae56b3b)
Compare against: http://indiana-build:8081 (at f36eaae56b3b)
Summary of changes: 3175 lines changed: 1181 ins; 924 del; 1070 mod; 397 unchg 
no comments found
 CR_6766563/webrev tag:cr.opensolaris.org,2009-09-10:~priyak/CR_6766563/webrev/2009-09-10T20:01:12Z 2009-11-06T20:02:55Z Priya Krishnan
Priya Krishnan [priyak] posted a code review on 06 Nov 2009: CR_6766563/webrev.
Priya Krishnan [priyak] posted a code review on 06 Nov 2009: CR_6766563/webrev.

Code Review for onnv-iser

Prepared by:Priya Krishnan Priya.Krishnan@Sun.COM on 2009-Nov-06 15:02 -0500 EST
Workspace:/export/build/priyak/onnv-iser (at 438da5f87955)
Compare against: ssh://onnv.sfbay.sun.com//export/onnv-clone (at e83d7b593311)
Summary of changes: 260 lines changed: 175 ins; 62 del; 23 mod; 14786 unchg 
6766563 iscsit should support phase collapse
 6133 tag:cr.opensolaris.org,2009-11-06:~error404/6133/2009-11-06T19:50:30Z 2009-11-06T19:50:30Z John Sonnenschein
John Sonnenschein [error404's blog] posted a code review on 06 Nov 2009: 6133.
John Sonnenschein [error404's blog] posted a code review on 06 Nov 2009: 6133.

Code Review for 6133

Prepared by:John Sonnenschein John.Sonnenschein@Sun.COM on Friday, November 6, 2009 11:50:12 AM PST
Workspace:/builds/js228356/pkg5/pkg-gate (at ec8fb10acb46)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 0775809e07bd)
Summary of changes: 11 lines changed: 10 ins; 0 del; 1 mod; 355 unchg 
6133 need to add pkg commands in /etc/security/exec_attr with "Software Installation" profile
 lxml tag:cr.opensolaris.org,2009-11-06:~johnfisc/lxml/2009-11-06T18:34:52Z 2009-11-06T18:34:52Z John Fischer
John Fischer [johnfisc] posted a code review on 06 Nov 2009: lxml.
John Fischer [johnfisc] posted a code review on 06 Nov 2009: lxml.

Code Review for slim_prototype

Prepared by:John Fischer (johnf) on 2009-Nov-06 10:31 -0800 PST
Workspace:/export/home/johnf/projects/auto-install/other-src/slim_prototype (at 37eb6e4beaba)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_prototype (at 37eb6e4beaba)
Summary of changes: 17 lines changed: 16 ins; 0 del; 1 mod; 218 unchg
Invalid HTML in comments
 12532 tag:cr.opensolaris.org,2009-11-06:~luisbg/12532/2009-11-06T18:15:15Z 2009-11-06T18:15:15Z Luis de Bethencourt
Luis de Bethencourt [luisbg's blog] posted a code review on 06 Nov 2009: 12532.
Luis de Bethencourt [luisbg's blog] posted a code review on 06 Nov 2009: 12532.

Code Review for slim_source

Prepared by:Luis de Bethencourt luisbg@sun.com on 2009-Nov-06 19:13 +0000 GMT
Workspace:/export/home/luisbg/development/webrev/slim_source (at e84402006fa5)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_source (at e84402006fa5)
Summary of changes: 15 lines changed: 1 ins; 0 del; 14 mod; 351 unchg 
no comments found
 beadm_test tag:cr.opensolaris.org,2009-11-06:~luisbg/beadm_test/2009-11-06T17:53:42Z 2009-11-06T17:53:42Z Luis de Bethencourt
Luis de Bethencourt [luisbg's blog] posted a code review on 06 Nov 2009: beadm_test.
Luis de Bethencourt [luisbg's blog] posted a code review on 06 Nov 2009: beadm_test.

Code Review for caiman_slim_source

Prepared by:Luis de Bethencourt luisbg@sun.com on 2009-Nov-06 18:47 +0000 GMT
Workspace:/export/home/luisbg/development/caiman_slim_source (at 2557d4648745)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_source (at 6cc86f2c6a71)
Summary of changes: 2259 lines changed: 767 ins; 650 del; 842 mod; 394 unchg 
python2.6 and pep8 for beadm
cmd/beadm/BootEnvironment.py: fixing some weird code
 pm_12178_export_p5i_6Nov_530pm tag:cr.opensolaris.org,2009-11-06:~jmr/pm_12178_export_p5i_6Nov_530pm/2009-11-06T17:28:14Z 2009-11-06T17:28:14Z John Rice
John Rice [jmr's blog] posted a code review on 06 Nov 2009: pm_12178_export_p5i_6Nov_530pm.
John Rice [jmr's blog] posted a code review on 06 Nov 2009: pm_12178_export_p5i_6Nov_530pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on Fri Nov 6 17:27:57 GMT 2009
Workspace:/export/home/jr140578/work/ips_gate (at 30f9e05c523d)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 30f9e05c523d)
Summary of changes: 184 lines changed: 169 ins; 3 del; 12 mod; 11141 unchg 
no comments found
 pm_12178_export_p5i_6Nov_520pm tag:cr.opensolaris.org,2009-11-06:~jmr/pm_12178_export_p5i_6Nov_520pm/2009-11-06T17:23:03Z 2009-11-06T17:23:03Z John Rice
John Rice [jmr's blog] posted a code review on 06 Nov 2009: pm_12178_export_p5i_6Nov_520pm.
John Rice [jmr's blog] posted a code review on 06 Nov 2009: pm_12178_export_p5i_6Nov_520pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on Fri Nov 6 17:22:40 GMT 2009
Workspace:/export/home/jr140578/work/ips_gate (at 30f9e05c523d)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 30f9e05c523d)
Summary of changes: 187 lines changed: 172 ins; 3 del; 12 mod; 11141 unchg 
no comments found
 pm_12178_export_p5i_6Nov_5pm tag:cr.opensolaris.org,2009-11-06:~jmr/pm_12178_export_p5i_6Nov_5pm/2009-11-06T17:02:10Z 2009-11-06T17:02:10Z John Rice
John Rice [jmr's blog] posted a code review on 06 Nov 2009: pm_12178_export_p5i_6Nov_5pm.
John Rice [jmr's blog] posted a code review on 06 Nov 2009: pm_12178_export_p5i_6Nov_5pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on Fri Nov 6 17:01:45 GMT 2009
Workspace:/export/home/jr140578/work/ips_gate (at 30f9e05c523d)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 30f9e05c523d)
Summary of changes: 181 lines changed: 168 ins; 3 del; 10 mod; 11143 unchg 
no comments found
 11679v2 tag:cr.opensolaris.org,2009-11-06:~evanl/11679v2/2009-11-06T15:28:40Z 2009-11-06T15:28:40Z Evan J. Layton
Evan J. Layton [evanl] posted a code review on 06 Nov 2009: 11679v2.
Evan J. Layton [evanl] posted a code review on 06 Nov 2009: 11679v2.

Code Review for slim_Py2.6

Prepared by:Evan Layton Evan.Layton@Sun.COM on 2009-Nov-06 08:40 -0700 MST
Workspace:/brmnas/evanl/slim_Py2.6 (at ebd0b2657cce)
Compare against: webrev at vers-1
Summary of changes: 121 lines changed: 0 ins; 15 del; 106 mod; 5282 unchg 
11679 beadm should be updated to work with Python version 2.6
11680 The libbe Python bridge needs to be compiled against libpython2.6
 gui_list_api_v2 tag:cr.opensolaris.org,2009-11-06:~padraig/gui_list_api_v2/2009-11-06T15:23:21Z 2009-11-06T15:23:21Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 06 Nov 2009: gui_list_api_v2.
Padraig O\'Briain [padraig] posted a code review on 06 Nov 2009: gui_list_api_v2.

Code Review for gui_list_api

Prepared by:Padraig O'Briain padraig.obriain@sun.com on Friday, November 6, 2009 2:50:25 PM GMT
Workspace:/export/home/padraig/gui_list_api (at b18f5b5ffde0)
Compare against: /export/home/padraig/list_api (at b18f5b5ffde0)
Summary of changes: 170 lines changed: 117 ins; 20 del; 33 mod; 5602 unchg 
no comments found
 rfe-6479874 tag:cr.opensolaris.org,2009-10-16:~janp/rfe-6479874/2009-10-16T13:43:26Z 2009-11-06T13:54:55Z Jan Pechanec
Jan Pechanec [janp] posted a code review on 06 Nov 2009: rfe-6479874.
Jan Pechanec [janp] posted a code review on 06 Nov 2009: rfe-6479874.

Code Review for rfe-6479874

Prepared by: (jp161948) on 2009-Nov-06 14:54 +0100 CET
Workspace:/export/workspace/rfe-6479874
Compare against: /net/grok.czech/ws-local/sfwnv-clone
Summary of changes: 2238 lines changed: 1973 ins; 181 del; 84 mod; 10354 unchg 
6479874 OpenSSL should support RSA key by reference/hardware keystores
6732677 make check to trigger Solaris specific code automatic in the PKCS#11 engine
6896677 PKCS#11 engine's hw_pk11_err.h needs to be split
6872415 pkcs11 engine's check_new_rsa_key_priv() should use a public key component
 10098 tag:cr.opensolaris.org,2009-10-30:~alhazred/10098/2009-10-30T11:33:50Z 2009-11-06T13:27:53Z Alexander Eremin
Alexander Eremin [alhazred's blog] posted a code review on 06 Nov 2009: 10098.
Alexander Eremin [alhazred's blog] posted a code review on 06 Nov 2009: 10098.

Code Review for 10098

Prepared by:Alexander Eremin eremin@milax.org on 2009-Nov-06 16:24 +0300 VOLT
Workspace:/admin/10098 (at 71ffb1bad847)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_source (at 8fa4ad8f6db1)
Summary of changes: 18 lines changed: 16 ins; 0 del; 2 mod; 231 unchg 
10098 -  usbcopy does not deal with smedia mounted usb flash properly
 pm_12178_export_p5i_6Nov_1pm tag:cr.opensolaris.org,2009-11-06:~jmr/pm_12178_export_p5i_6Nov_1pm/2009-11-06T12:58:39Z 2009-11-06T12:58:39Z John Rice
John Rice [jmr's blog] posted a code review on 06 Nov 2009: pm_12178_export_p5i_6Nov_1pm.
John Rice [jmr's blog] posted a code review on 06 Nov 2009: pm_12178_export_p5i_6Nov_1pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on Fri Nov 6 12:57:40 GMT 2009
Workspace:/export/home/jr140578/work/ips_gate (at 30f9e05c523d)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 30f9e05c523d)
Summary of changes: 115 lines changed: 113 ins; 0 del; 2 mod; 11154 unchg 
no comments found
 6213311 tag:cr.opensolaris.org,2009-11-06:~lewellyn/6213311/2009-11-06T09:56:19Z 2009-11-06T10:03:56Z Matt Lewandowsky
Matt Lewandowsky [lewellyn's blog] posted a code review on 06 Nov 2009: 6213311.
Matt Lewandowsky [lewellyn's blog] posted a code review on 06 Nov 2009: 6213311.

Code Review for 6213311

Prepared by: (pencil) on 2009-Nov-06 02:02 -0800 PST
Workspace:/home/pencil/opensolaris/6213311 (at 2d0d7434a4fb)
Compare against: ssh://anon@hg.opensolaris.org/hg/onnv/onnv-gate (at 2d0d7434a4fb)
Summary of changes: 6 lines changed: 0 ins; 0 del; 6 mod; 2137 unchg 
This does not prevent running zlogin if there are multiple escape
characters specified on the command line. Doing so would potentially
break user scripts, and would add needless confusion. I propose that
the man page is the correct place to deal with the potential issue,
if it even needs to be dealt with now that zlogin prints the escape
character it recognizes, when you zlogin to a zone.
These are the suggested changes to zlogin(1)'s man page.
 ips-12346-v3 tag:cr.opensolaris.org,2009-11-06:~padraig/ips-12346-v3/2009-11-06T08:46:56Z 2009-11-06T08:46:56Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 06 Nov 2009: ips-12346-v3.
Padraig O\'Briain [padraig] posted a code review on 06 Nov 2009: ips-12346-v3.

Code Review for 12346_clone

Prepared by:Padraig O'Briain padraig.obriain@sun.com on Friday, November 6, 2009 8:31:40 AM GMT
Workspace:/export/home/padraig/12346_clone (at 54133287c1c5)
Compare against: /export/home/padraig/gate (at 54133287c1c5)
Summary of changes: 127 lines changed: 98 ins; 26 del; 3 mod; 12265 unchg 
no comments found
 python-24-26 tag:cr.opensolaris.org,2009-10-26:~dambi/python-24-26/2009-10-26T13:40:07Z 2009-11-06T08:16:47Z Jan Damborsky
Jan Damborsky [dambi] posted a code review on 06 Nov 2009: python-24-26.
Jan Damborsky [dambi] posted a code review on 06 Nov 2009: python-24-26.

Code Review for os-install-24-26-clay-gate

Prepared by:Jan Damborsky jan.damborsky@sun.com on Friday, November 6, 2009 9:16:47 AM CET
Workspace:/export/home/dambi/ws/os-install-24-26-clay-gate (at f36eaae56b3b)
Compare against: http://indiana-build.central:8081 (at f94d9b9b3245)
Summary of changes: 58 lines changed: 4 ins; 25 del; 29 mod; 1387 unchg 
AI client - PEP8 changes
 kclient tag:cr.opensolaris.org,2009-07-09:~semery/kclient/2009-07-09T07:34:27Z 2009-11-06T07:02:33Z Shawn M. Emery
Shawn M. Emery [semery] posted a code review on 06 Nov 2009: kclient.
Shawn M. Emery [semery] posted a code review on 06 Nov 2009: kclient.

Code Review for kclient

Prepared by:Shawn Emery Shawn.Emery@Sun.COM on Friday, November 6, 2009 12:01:23 AM MST
Workspace:/export/home/semery/builds/kclient (at f08074dbebaa)
Compare against: /export/home/semery/builds/onnv-gate (at b3afbf06f20d)
Summary of changes: 170 lines changed: 124 ins; 18 del; 28 mod; 11343 unchg 
6885980 Need case-insensitive keytab lookups for MS interop
6885387 gsskrb5_extract_authz_data_from_sec_context() fails with service ticket sent by Windows 7 client
6858400 kclient cant join Windows AD domain if hostname is 20 characters or longer
6867203 Solaris acceptors fail in Windows 2000 environment
6868908 Solaris acceptors should have returned KRB5KRB_AP_ERR_MODIFIED for Microsoft interoperability
6867208 Windows client cannot recover from KRB5KRB_AP_ERR_SKEW error
 webrev.sync1105 tag:cr.opensolaris.org,2009-11-06:~mjnelson/webrev.sync1105/2009-11-06T06:32:14Z 2009-11-06T06:32:14Z Mark J. Nelson
Mark J. Nelson [mjnelson's blog] posted a code review on 06 Nov 2009: webrev.sync1105.
Mark J. Nelson [mjnelson's blog] posted a code review on 06 Nov 2009: webrev.sync1105.

Code Review for webrev.sync1105

Prepared by:Mark J. Nelson Mark.J.Nelson@Sun.COM on Thu Nov 5 23:30:06 MST 2009
Workspace:/brmnas/mjnelson/onnv-ips (at 98b742cfbac1)
Compare against: ssh://mrliberal.central//export/ws/mjnelson/on-ips-work (at f6a15b5e0f49)
Summary of changes: 27 lines changed: 9 ins; 17 del; 1 mod; 4417 unchg 
Sync with 11-05-2009 nightly.  onnv-changeset 7681ab1c3e80
 webrev_qlogic_qlge_12 tag:cr.opensolaris.org,2009-11-06:~ss118570/webrev_qlogic_qlge_12/2009-11-06T05:36:53Z 2009-11-06T05:36:53Z Sukumar Swaminathan
Sukumar Swaminathan [ss118570] posted a code review on 06 Nov 2009: webrev_qlogic_qlge_12.
Sukumar Swaminathan [ss118570] posted a code review on 06 Nov 2009: webrev_qlogic_qlge_12.

Code Review for qlogic_qlge

Prepared by:Sukumar Swaminathan Sukumar.Swaminathan@Sun.COM on 2009-Nov-05 21:29 -0800 PST
Workspace:/builds/ss118570/qlogic_qlge (at da331160e867)
Compare against: ssh://anonhg@onnv.sfbay.sun.com//export/onnv-clone (at de59debacdeb)
Summary of changes: 17777 lines changed: 17600 ins; 172 del; 5 mod; 6000 unchg 
PSARC/2009/525 qlge - QLogic PCIe converged NIC driver
6871527 FCoE, qlge driver - Add NIC side of support for new Qlogic FCoE adapter, Europa
 ips-12475-v2 tag:cr.opensolaris.org,2009-11-06:~bpytlik/ips-12475-v2/2009-11-06T05:29:19Z 2009-11-06T05:29:19Z Brock Pytlik
Brock Pytlik [bpytlik] posted a code review on 06 Nov 2009: ips-12475-v2.
Brock Pytlik [bpytlik] posted a code review on 06 Nov 2009: ips-12475-v2.

Code Review for recommit.bug-12475-v2

Prepared by:Brock Pytlik bpytlik@sun.com on Thursday, November 5, 2009 9:29:19 PM PST
Workspace:/export/home/bpytlik/IPS/recommit.bug-12475-v2 (at ddfdf8e01a8b)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 7526bfca96f9)
Summary of changes: 273 lines changed: 273 ins; 0 del; 0 mod; 2654 unchg 
12475 Need a program to migrate a depot from v0 layout to v1 layout
 installadm_python2.6 tag:cr.opensolaris.org,2009-11-06:~clayb/installadm_python2.6/2009-11-06T05:18:28Z 2009-11-06T05:18:28Z Clay Baenziger
Clay Baenziger [clayb] posted a code review on 06 Nov 2009: installadm_python2.6.
Clay Baenziger [clayb] posted a code review on 06 Nov 2009: installadm_python2.6.

Code Review for slim_python_installadm

Prepared by:Clay Baenziger ClayB@OpenSolaris.ORG on Thursday, November 5, 2009 10:17:58 PM MST
Workspace:/net/xsplat/export/backup/hg_workspaces/slim_python_installadm (at f94d9b9b3245)
Compare against: http://indiana-build:8081 (at 593044a30059)
Summary of changes: 3 lines changed: 0 ins; 0 del; 3 mod; 1046 unchg 
installadm fixes
12521 - libaiscf_pymod: needs to be linked against /usr/lib/libscf!
 webrev-12128-1v2 tag:cr.opensolaris.org,2009-11-06:~johansen/webrev-12128-1v2/2009-11-06T03:11:38Z 2009-11-06T03:11:38Z johansen
johansen [johansen] posted a code review on 06 Nov 2009: webrev-12128-1v2.
johansen [johansen] posted a code review on 06 Nov 2009: webrev-12128-1v2.

Code Review for webrev-diff

Prepared by:johansen on Thu Nov 5 19:09:30 PST 2009
Workspace:/home/johansen/hg_ws/pkg-mfst (at 3e6271b095c2)
Compare against: webrev at webrev-old
Summary of changes: 91 lines changed: 27 ins; 16 del; 48 mod; 11839 unchg 
12128 client should pipeline manifest retrieval
12418 StreamingFileObj prints AttributeError
12460 traceback if pkg-server absent during valid version test
12478 Temporary download directory needs more cleanup
12502 Catalog contains incorrect manifest signatures
 webrev-12128-2 tag:cr.opensolaris.org,2009-11-06:~johansen/webrev-12128-2/2009-11-06T03:09:45Z 2009-11-06T03:09:45Z johansen
johansen [johansen] posted a code review on 06 Nov 2009: webrev-12128-2.
johansen [johansen] posted a code review on 06 Nov 2009: webrev-12128-2.

Code Review for pkg-mfst

Prepared by:johansen on Thu Nov 5 19:08:46 PST 2009
Workspace:/home/johansen/hg_ws/pkg-mfst (at 3e6271b095c2)
Compare against: ssh://johansen@opensolaris.org/hg/pkg/gate (at 7526bfca96f9)
Summary of changes: 640 lines changed: 487 ins; 96 del; 57 mod; 11370 unchg 
12128 client should pipeline manifest retrieval
12418 StreamingFileObj prints AttributeError
12460 traceback if pkg-server absent during valid version test
12478 Temporary download directory needs more cleanup
12502 Catalog contains incorrect manifest signatures
 EMI_webrev_inc.1 tag:cr.opensolaris.org,2009-11-05:~swilcox/EMI_webrev_inc.1/2009-11-05T23:57:29Z 2009-11-06T00:31:57Z Sean D. Wilcox
Sean D. Wilcox [swilcox] posted a code review on 06 Nov 2009: EMI_webrev_inc.1.
Sean D. Wilcox [swilcox] posted a code review on 06 Nov 2009: EMI_webrev_inc.1.

Code Review for webrev_inc.1

Prepared by:Sean Wilcox Sean.Wilcox@Sun.COM on 2009-Nov-05 16:31 -0800 PST
Workspace:/builds/swilcox/myEMI_gate (at 8a4a4cc917fd)
Compare against: webrev at webrev.0
Summary of changes: 23 lines changed: 5 ins; 5 del; 13 mod; 1847 unchg 
prototype build errors
manifest-import import modifications
netservices update to create links in the correct location
 EMI_webrev.1 tag:cr.opensolaris.org,2009-11-05:~swilcox/EMI_webrev.1/2009-11-05T23:56:33Z 2009-11-06T00:31:07Z Sean D. Wilcox
Sean D. Wilcox [swilcox] posted a code review on 06 Nov 2009: EMI_webrev.1.
Sean D. Wilcox [swilcox] posted a code review on 06 Nov 2009: EMI_webrev.1.

Code Review for webrev.1

Prepared by:Sean Wilcox Sean.Wilcox@Sun.COM on 2009-Nov-05 16:30 -0800 PST
Workspace:/builds/swilcox/myEMI_gate (at 8a4a4cc917fd)
Compare against: ssh://swilcox@hg.opensolaris.org//hg/smf-doc/smf-emi (at c883bc19d858)
Summary of changes: 103 lines changed: 19 ins; 60 del; 24 mod; 1822 unchg 
prototype build errors
manifest-import import modifications
netservices update to create links in the correct location
 slim_8347_6092 tag:cr.opensolaris.org,2009-11-05:~jeanm/slim_8347_6092/2009-11-05T23:12:37Z 2009-11-05T23:12:37Z Jean E. McCormack
Jean E. McCormack [jeanm] posted a code review on 05 Nov 2009: slim_8347_6092.
Jean E. McCormack [jeanm] posted a code review on 05 Nov 2009: slim_8347_6092.

Code Review for slim_pre_alok

Prepared by:Jean McCormack Jean.McCormack@Sun.COM on 2009-Nov-05 16:24 -0700 MST
Workspace:/brmnas/jeanm/slim_pre_alok (at 6b4b908dc2e2)
Compare against: ssh://hg.opensolaris.org/hg/caiman/slim_source (at e631367ff83d)
Summary of changes: 1808 lines changed: 256 ins; 215 del; 1337 mod; 8127 unchg 
6092 Rename bootroot to boot_archive in DC
8347 Move boot archive from /boot/x86.microroot to /platform/i86pc/boot_archive
 NumaTOP tag:cr.opensolaris.org,2009-11-05:~ksadhukh/NumaTOP/2009-11-05T21:37:25Z 2009-11-05T21:37:25Z Krishnendu Sadhukhan
Krishnendu Sadhukhan [ksadhukh] posted a code review on 05 Nov 2009: NumaTOP.
Krishnendu Sadhukhan [ksadhukh] posted a code review on 05 Nov 2009: NumaTOP.

Code Review for NumaTOP

Prepared by:Krishnendu Sadhukhan - Sun Microsystems Krishnendu.Sadhukhan@Sun.COM on 2009-Nov-05 13:37 -0800 PST
Workspace:/export/ksadhukh/NumaTOP (at 270624bd70f1)
Compare against: /ws/onnv-clone (at 270624bd70f1)
Summary of changes: 139 lines changed: 123 ins; 3 del; 13 mod; 2799 unchg 
no comments found
 nc_tet-execution.stcnv tag:cr.opensolaris.org,2009-11-05:~vkotal/nc_tet-execution.stcnv/2009-11-05T20:55:23Z 2009-11-05T20:55:23Z Vladimir Kotal
Vladimir Kotal [vkotal's blog] posted a code review on 05 Nov 2009: nc_tet-execution.stcnv.
Vladimir Kotal [vkotal's blog] posted a code review on 05 Nov 2009: nc_tet-execution.stcnv.

Code Review for nc_tet-execution.stcnv

Prepared by:vladimir kotal - Sun Microsystems - Prague Czech Republic (vk199839) on Thu Nov 5 21:55:15 CET 2009
Workspace:/workspaces/nc_tet-execution.stcnv
Compare against: /net/grok.czech/ws-local/stcnv-clone
Summary of changes: 107 lines changed: 76 ins; 8 del; 23 mod; 1967 unchg 
6898627 tp_iflag_001_pos should use start_nc for all background executions
6897053 lflag test purposes 012,014 are negative so they should be named so
6897054 nc_kill() should be more careful about which process it is killing
 pkg-clone-1 tag:cr.opensolaris.org,2009-11-05:~lianep/pkg-clone-1/2009-11-05T20:16:34Z 2009-11-05T20:16:34Z Liane Praza
Liane Praza [lianep's blog] posted a code review on 05 Nov 2009: pkg-clone-1.
Liane Praza [lianep's blog] posted a code review on 05 Nov 2009: pkg-clone-1.

Code Review for pkg-clone

Prepared by:Liane Praza Liane.Praza@Sun.COM on 2009-Nov-05 12:05 -0800 PST
Workspace:/local/pkg/pkg-clone (at e4d3ec67ac62)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 6785a9e640dd)
Summary of changes: 1666 lines changed: 1666 ins; 0 del; 0 mod; 14955 unchg 
12347 new dependencies required for developer/opensolaris/osnet
12463 need consolidation incorporations
 7360_4 tag:cr.opensolaris.org,2009-11-05:~error404/7360_4/2009-11-05T20:16:08Z 2009-11-05T20:16:08Z John Sonnenschein
John Sonnenschein [error404's blog] posted a code review on 05 Nov 2009: 7360_4.
John Sonnenschein [error404's blog] posted a code review on 05 Nov 2009: 7360_4.

Code Review for 7360_4

Prepared by:John Sonnenschein John.Sonnenschein@Sun.COM on Thursday, November 5, 2009 12:21:11 PM PST
Workspace:/builds/pkg5/pkg-gate (at 2cc910aa3394)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at cd65f8545fd2)
Summary of changes: 178 lines changed: 164 ins; 1 del; 13 mod; 4211 unchg 
7360 indexing workfile size should be configurable
 webrev.6793 tag:cr.opensolaris.org,2009-11-05:~gjelinek/webrev.6793/2009-11-05T19:14:40Z 2009-11-05T19:14:40Z Gerald A. Jelinek
Gerald A. Jelinek [gjelinek] posted a code review on 05 Nov 2009: webrev.6793.
Gerald A. Jelinek [gjelinek] posted a code review on 05 Nov 2009: webrev.6793.

Code Review for pkg

Prepared by:gerald.jelinek@sun.com on 2009-Nov-05 12:11 -0700 MST
Workspace:/export/ws/pkg (at ec5fddb40e58)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 30f9e05c523d)
Summary of changes: 2417 lines changed: 1231 ins; 1025 del; 161 mod; 2157 unchg 
6793 p2v support for ipkg-branded zones
 6898418-OpenSSL_deps tag:cr.opensolaris.org,2009-11-05:~mbp/6898418-OpenSSL_deps/2009-11-05T16:04:30Z 2009-11-05T16:04:30Z Mark Phalan
Mark Phalan [mbp's blog] posted a code review on 05 Nov 2009: 6898418-OpenSSL_deps.
Mark Phalan [mbp's blog] posted a code review on 05 Nov 2009: 6898418-OpenSSL_deps.

Code Review for 6898418-OpenSSL_deps

Prepared by: (mp153739) on 2009-Nov-05 17:02 +0100 CET
Workspace:/rpool/local/ws/6898418-OpenSSL_deps
Compare against: /ws/sfwnv-clone
Summary of changes: 33 lines changed: 29 ins; 0 del; 4 mod; 179 unchg 
6898418 SUNWopenssl packages should include default dependencies
 6898416-symbolic tag:cr.opensolaris.org,2009-11-05:~mbp/6898416-symbolic/2009-11-05T16:03:56Z 2009-11-05T16:03:56Z Mark Phalan
Mark Phalan [mbp's blog] posted a code review on 05 Nov 2009: 6898416-symbolic.
Mark Phalan [mbp's blog] posted a code review on 05 Nov 2009: 6898416-symbolic.

Code Review for 6898416-symbolic

Prepared by: (mp153739) on 2009-Nov-05 17:01 +0100 CET
Workspace:/rpool/local/ws/6898416-symbolic
Compare against: /rpool/local/ws/sfwnv-clone
Summary of changes: 33 lines changed: 0 ins; 31 del; 2 mod; 465 unchg 
6898416 keeping -Bsymbolic keeps OpenSSL in SFW simpler
 pm_12178_export_p5i_5Nov_4pm tag:cr.opensolaris.org,2009-11-05:~jmr/pm_12178_export_p5i_5Nov_4pm/2009-11-05T15:58:08Z 2009-11-05T15:58:08Z John Rice
John Rice [jmr's blog] posted a code review on 05 Nov 2009: pm_12178_export_p5i_5Nov_4pm.
John Rice [jmr's blog] posted a code review on 05 Nov 2009: pm_12178_export_p5i_5Nov_4pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on Thursday, November 5, 2009 3:56:23 PM GMT
Workspace:/export/home/jr140578/work/ips_gate (at 30f9e05c523d)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 30f9e05c523d)
Summary of changes: 103 lines changed: 101 ins; 0 del; 2 mod; 11154 unchg 
no comments found
 gui_list_api_v1 tag:cr.opensolaris.org,2009-11-05:~padraig/gui_list_api_v1/2009-11-05T15:14:27Z 2009-11-05T15:14:27Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 05 Nov 2009: gui_list_api_v1.
Padraig O\'Briain [padraig] posted a code review on 05 Nov 2009: gui_list_api_v1.

Code Review for gui_list_api

Prepared by:Padraig O'Briain padraig.obriain@sun.com on Thursday, November 5, 2009 2:59:39 PM GMT
Workspace:/export/home/padraig/gui_list_api (at b18f5b5ffde0)
Compare against: /export/home/padraig/list_api (at b18f5b5ffde0)
Summary of changes: 150 lines changed: 97 ins; 20 del; 33 mod; 5602 unchg 
no comments found
 pkg-12483-v1 tag:cr.opensolaris.org,2009-11-05:~richb/pkg-12483-v1/2009-11-05T15:07:10Z 2009-11-05T15:07:10Z Rich Burridge
Rich Burridge [richb's blog] posted a code review on 05 Nov 2009: pkg-12483-v1.
Rich Burridge [richb's blog] posted a code review on 05 Nov 2009: pkg-12483-v1.

Code Review for gate

Prepared by:Rich Burridge rich.burridge@sun.com on 2009-Nov-05 07:07 -0800 PST
Workspace:/export/home/richb/pkg/bugs/12483/gate (at 30f9e05c523d)
Compare against: ssh://richb@hg.opensolaris.org/hg/pkg/gate (at 30f9e05c523d)
Summary of changes: 2 lines changed: 2 ins; 0 del; 0 mod; 12 unchg 
no comments found
 ai-err-report-no-pep8 tag:cr.opensolaris.org,2009-10-26:~dambi/ai-err-report-no-pep8/2009-10-26T20:56:27Z 2009-11-05T13:38:56Z Jan Damborsky
Jan Damborsky [dambi] posted a code review on 05 Nov 2009: ai-err-report-no-pep8.
Jan Damborsky [dambi] posted a code review on 05 Nov 2009: ai-err-report-no-pep8.

Code Review for os-install-ai-err-no-pep8

Prepared by:Jan Damborsky jan.damborsky@sun.com on Thursday, November 5, 2009 2:38:55 PM CET
Workspace:/export/home/dambi/ws/os-install-ai-err-no-pep8 (at ee7c275329b4)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_source (at e631367ff83d)
Summary of changes: 1076 lines changed: 625 ins; 221 del; 230 mod; 13167 unchg 
6651 autoinstall needs more useful error messages from Orchestrator module
7433 autoinstall should include output from pkg(5)
8127 Complete /tmp/install_log not copied to /var/sadm/system/logs/install_log
8639 be_init() failed with error code 4044 when username is  in SC manifest
10040 Error reporting when unable to download solaris.zlib/solarismisc.zlib is unobvious
10688 AI should validate repository reachability
11421 ddm_drive_is_cdrom(): ioctl(DKIOCREMOVABLE) failed in /tmp/install_log
11640 decrypt liborchestrator IPS debug messages
merge with William - bug 12459
 ips-12356-v2 tag:cr.opensolaris.org,2009-11-05:~padraig/ips-12356-v2/2009-11-05T12:25:59Z 2009-11-05T12:25:59Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 05 Nov 2009: ips-12356-v2.
Padraig O\'Briain [padraig] posted a code review on 05 Nov 2009: ips-12356-v2.

Code Review for 12356_clone

Prepared by:Padraig O'Briain padraig.obriain@sun.com on Thursday, November 5, 2009 12:12:32 PM GMT
Workspace:/export/home/padraig/12356_clone (at 4411d2a364a8)
Compare against: /export/home/padraig/gate (at 4411d2a364a8)
Summary of changes: 78 lines changed: 47 ins; 7 del; 24 mod; 4969 unchg 
no comments found
 pm_12458_webinstall_focus_5Nov_1150am tag:cr.opensolaris.org,2009-11-05:~jmr/pm_12458_webinstall_focus_5Nov_1150am/2009-11-05T11:54:24Z 2009-11-05T11:54:24Z John Rice
John Rice [jmr's blog] posted a code review on 05 Nov 2009: pm_12458_webinstall_focus_5Nov_1150am.
John Rice [jmr's blog] posted a code review on 05 Nov 2009: pm_12458_webinstall_focus_5Nov_1150am.

Code Review for ips_12458

Prepared by:John Rice john.rice@sun.com on Thursday, November 5, 2009 11:52:38 AM GMT
Workspace:/export/home/jr140578/work/ips_12458 (at 4411d2a364a8)
Compare against: /export/home/jr140578/work/ips_gate (at 4411d2a364a8)
Summary of changes: 19 lines changed: 7 ins; 6 del; 6 mod; 2963 unchg 
no comments found
 6748301 tag:cr.opensolaris.org,2009-11-05:~lewellyn/6748301/2009-11-05T11:51:37Z 2009-11-05T11:51:37Z Matt Lewandowsky
Matt Lewandowsky [lewellyn's blog] posted a code review on 05 Nov 2009: 6748301.
Matt Lewandowsky [lewellyn's blog] posted a code review on 05 Nov 2009: 6748301.

Code Review for 6748301

Prepared by: (pencil) on 2009-Nov-05 03:51 -0800 PST
Workspace:/home/pencil/opensolaris/6748301 (at 2d0d7434a4fb)
Compare against: ssh://anon@hg.opensolaris.org/hg/onnv/onnv-gate (at 2d0d7434a4fb)
Summary of changes: 28 lines changed: 0 ins; 28 del; 0 mod; 4310 unchg 
no comments found
 pm_webinstall_frame_addition_5Nov_1130am tag:cr.opensolaris.org,2009-11-05:~jmr/pm_webinstall_frame_addition_5Nov_1130am/2009-11-05T11:32:16Z 2009-11-05T11:32:16Z John Rice
John Rice [jmr's blog] posted a code review on 05 Nov 2009: pm_webinstall_frame_addition_5Nov_1130am.
John Rice [jmr's blog] posted a code review on 05 Nov 2009: pm_webinstall_frame_addition_5Nov_1130am.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on Thursday, November 5, 2009 11:28:50 AM GMT
Workspace:/export/home/jr140578/work/ips_gate (at 6785a9e640dd)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 6785a9e640dd)
Summary of changes: 30 lines changed: 16 ins; 3 del; 11 mod; 6088 unchg 
no comments found
 6771201 tag:cr.opensolaris.org,2009-11-05:~lewellyn/6771201/2009-11-05T11:21:04Z 2009-11-05T11:21:04Z Matt Lewandowsky
Matt Lewandowsky [lewellyn's blog] posted a code review on 05 Nov 2009: 6771201.
Matt Lewandowsky [lewellyn's blog] posted a code review on 05 Nov 2009: 6771201.

Code Review for 6771201

Prepared by: (pencil) on 2009-Nov-05 03:20 -0800 PST
Workspace:/home/pencil/opensolaris/6771201 (at 2d0d7434a4fb)
Compare against: ssh://anon@hg.opensolaris.org/hg/onnv/onnv-gate (at 2d0d7434a4fb)
Summary of changes: 39 lines changed: 38 ins; 0 del; 1 mod; 4679 unchg 
no comments found
 6848228 tag:cr.opensolaris.org,2009-11-05:~lewellyn/6848228/2009-11-05T10:28:33Z 2009-11-05T10:28:33Z Matt Lewandowsky
Matt Lewandowsky [lewellyn's blog] posted a code review on 05 Nov 2009: 6848228.
Matt Lewandowsky [lewellyn's blog] posted a code review on 05 Nov 2009: 6848228.

Code Review for 6848228

Prepared by: (pencil) on 2009-Nov-05 02:27 -0800 PST
Workspace:/home/pencil/opensolaris/6848228 (at abaf3bbc79a9)
Compare against: ssh://anon@hg.opensolaris.org/hg/onnv/onnv-gate (at abaf3bbc79a9)
Summary of changes: 17 lines changed: 0 ins; 15 del; 2 mod; 8512 unchg 
no comments found
 4858166 tag:cr.opensolaris.org,2009-11-05:~lewellyn/4858166/2009-11-05T10:23:19Z 2009-11-05T10:23:19Z Matt Lewandowsky
Matt Lewandowsky [lewellyn's blog] posted a code review on 05 Nov 2009: 4858166.
Matt Lewandowsky [lewellyn's blog] posted a code review on 05 Nov 2009: 4858166.

Code Review for 4858166

Prepared by: (pencil) on 2009-Nov-05 02:21 -0800 PST
Workspace:/home/pencil/opensolaris/4858166 (at 2d0d7434a4fb)
Compare against: ssh://anon@hg.opensolaris.org/hg/onnv/onnv-gate (at 2d0d7434a4fb)
Summary of changes: 4 lines changed: 0 ins; 2 del; 2 mod; 84 unchg 
Added -u as suggested.
Run against the man pages installed on this system:
-rw-r--r--   1 pencil   other    3494005 Nov  5 02:02 before/windex
-rw-r--r--   1 pencil   other    1716010 Nov  5 02:03 after/windex
 webrev_qlogic_qlge_11 tag:cr.opensolaris.org,2009-11-05:~ss118570/webrev_qlogic_qlge_11/2009-11-05T05:34:08Z 2009-11-05T05:34:08Z Sukumar Swaminathan
Sukumar Swaminathan [ss118570] posted a code review on 05 Nov 2009: webrev_qlogic_qlge_11.
Sukumar Swaminathan [ss118570] posted a code review on 05 Nov 2009: webrev_qlogic_qlge_11.

Code Review for qlogic_qlge

Prepared by:Sukumar Swaminathan Sukumar.Swaminathan@Sun.COM on 2009-Nov-04 21:32 -0800 PST
Workspace:/builds/ss118570/qlogic_qlge (at f2eef5056a13)
Compare against: ssh://anonhg@onnv.sfbay.sun.com//export/onnv-clone (at abaf3bbc79a9)
Summary of changes: 17778 lines changed: 17601 ins; 172 del; 5 mod; 6001 unchg 
PSARC/2009/525 qlge - QLogic PCIe converged NIC driver
6871527 FCoE, qlge driver - Add NIC side of support for new Qlogic FCoE adapter, Europa
 6880568 tag:cr.opensolaris.org,2009-11-05:~esaxe/6880568/2009-11-05T01:15:15Z 2009-11-05T01:15:15Z Eric C. Saxe
Eric C. Saxe [esaxe's blog] posted a code review on 05 Nov 2009: 6880568.
Eric C. Saxe [esaxe's blog] posted a code review on 05 Nov 2009: 6880568.

Code Review for pg

Prepared by:Eric Saxe Eric.Saxe@Sun.COM on Wed Nov 4 17:14:40 PST 2009
Workspace:/export/esaxe/pg (at b3cd02084514)
Compare against: /ws/onnv-clone (at d41e0e73a69e)
Summary of changes: 21 lines changed: 7 ins; 3 del; 11 mod; 1879 unchg 
6880568 panic lurking in cmt_hier_promote()
6897799 cmt_lineage can be incorrect
 ips-12475-v1 tag:cr.opensolaris.org,2009-11-05:~bpytlik/ips-12475-v1/2009-11-05T00:45:41Z 2009-11-05T00:45:41Z Brock Pytlik
Brock Pytlik [bpytlik] posted a code review on 05 Nov 2009: ips-12475-v1.
Brock Pytlik [bpytlik] posted a code review on 05 Nov 2009: ips-12475-v1.

Code Review for bug-12475

Prepared by:Brock Pytlik bpytlik@sun.com on Wednesday, November 4, 2009 4:45:40 PM PST
Workspace:/export/home/bpytlik/IPS/bug-12475 (at eedeb17f6f67)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at bfdf13d64d47)
Summary of changes: 176 lines changed: 176 ins; 0 del; 0 mod; 2079 unchg 
12475 Need a program to migrate a depot from v0 layout to v1 layout
 EMI_webrev.0 tag:cr.opensolaris.org,2009-11-04:~swilcox/EMI_webrev.0/2009-11-04T23:47:44Z 2009-11-04T23:47:44Z Sean D. Wilcox
Sean D. Wilcox [swilcox] posted a code review on 04 Nov 2009: EMI_webrev.0.
Sean D. Wilcox [swilcox] posted a code review on 04 Nov 2009: EMI_webrev.0.

Code Review for webrev.0

Prepared by:Sean Wilcox Sean.Wilcox@Sun.COM on 2009-Nov-04 15:47 -0800 PST
Workspace:/builds/swilcox/myEMI_gate (at c883bc19d858)
Compare against: ssh://swilcox@hg.opensolaris.org//hg/smf-doc/smf-emi (at c883bc19d858)
Summary of changes: 91 lines changed: 19 ins; 60 del; 12 mod; 1434 unchg 
no comments found
 webrev-12128 tag:cr.opensolaris.org,2009-11-04:~johansen/webrev-12128/2009-11-04T00:07:38Z 2009-11-04T23:40:34Z johansen
johansen [johansen] posted a code review on 04 Nov 2009: webrev-12128.
johansen [johansen] posted a code review on 04 Nov 2009: webrev-12128.

Code Review for pkg-mfst

Prepared by:johansen on Wed Nov 4 15:40:22 PST 2009
Workspace:/home/johansen/hg_ws/pkg-mfst (at 4d6fef1e9de2)
Compare against: ssh://johansen@opensolaris.org/hg/pkg/gate (at bfdf13d64d47)
Summary of changes: 603 lines changed: 473 ins; 93 del; 37 mod; 7497 unchg 
12128 client should pipeline manifest retrieval
12418 StreamingFileObj prints AttributeError
12460 traceback if pkg-server absent during valid version test
12478 Temporary download directory needs more cleanup
 libtransfer-coderev tag:cr.opensolaris.org,2009-11-04:~aalok/libtransfer-coderev/2009-11-04T23:11:03Z 2009-11-04T23:11:03Z Alok Aggarwal
Alok Aggarwal [aalok's blog] posted a code review on 04 Nov 2009: libtransfer-coderev.
Alok Aggarwal [aalok's blog] posted a code review on 04 Nov 2009: libtransfer-coderev.

Code Review for libtransfer-coderev

Prepared by:Alok Aggarwal Alok.Aggarwal@Sun.COM on Wednesday, November 4, 2009 3:11:01 PM PST
Workspace:/export/home/aalok/slim-python2.6 (at f757ff2acd33)
Compare against: http://indiana-build.central:8081 (at eb816da8a7f0)
Summary of changes: 1308 lines changed: 105 ins; 55 del; 1148 mod; 333 unchg 
12476 migrate libtransfer to python2.6
 libtransfer-coderev-diffs tag:cr.opensolaris.org,2009-11-04:~aalok/libtransfer-coderev-diffs/2009-11-04T23:10:48Z 2009-11-04T23:10:48Z Alok Aggarwal
Alok Aggarwal [aalok's blog] posted a code review on 04 Nov 2009: libtransfer-coderev-diffs.
Alok Aggarwal [aalok's blog] posted a code review on 04 Nov 2009: libtransfer-coderev-diffs.

Code Review for libtransfer-coderev-diffs

Prepared by:Alok Aggarwal Alok.Aggarwal@Sun.COM on Wednesday, November 4, 2009 3:10:43 PM PST
Workspace:/export/home/aalok/slim-python2.6 (at f757ff2acd33)
Compare against: webrev at libtransfer-pep8
Summary of changes: 167 lines changed: 16 ins; 25 del; 126 mod; 1444 unchg 
12476 migrate libtransfer to python2.6
 pkg-gate1104 tag:cr.opensolaris.org,2009-11-04:~erisch/pkg-gate1104/2009-11-04T22:52:43Z 2009-11-04T22:52:43Z Erik Trauschke
Erik Trauschke [erisch] posted a code review on 04 Nov 2009: pkg-gate1104.
Erik Trauschke [erisch] posted a code review on 04 Nov 2009: pkg-gate1104.

Code Review for pkg-gate

Prepared by:Erik Trauschke Erik.Trauschke@Sun.COM on Wed Nov 4 14:41:45 PST 2009
Workspace:/export/work/pkg/pkg-gate (at bd6ffa78fed9)
Compare against: ssh://Tpkg@hg.opensolaris.org//hg/pkg/gate (at bd6ffa78fed9)
Summary of changes: 17 lines changed: 14 ins; 0 del; 3 mod; 356 unchg 
no comments found
 lxml_makefile tag:cr.opensolaris.org,2009-11-04:~clayb/lxml_makefile/2009-11-04T21:47:18Z 2009-11-04T21:47:18Z Clay Baenziger
Clay Baenziger [clayb] posted a code review on 04 Nov 2009: lxml_makefile.
Clay Baenziger [clayb] posted a code review on 04 Nov 2009: lxml_makefile.

Code Review for slim_prototype_lxml

Prepared by:Clay Baenziger ClayB@OpenSolaris.ORG on Wednesday, November 4, 2009 1:18:42 PM MST
Workspace:/export/backup/hg_workspaces/slim_prototype_lxml (at 37eb6e4beaba)
Compare against: ssh://clayb@hg.opensolaris.org/hg/caiman/slim_prototype (at c0767c15c9a4)
Summary of changes: 1 line changed: 0 ins; 0 del; 1 mod; 69 unchg 
Fix typo in Makefile
 nc_tet_versus_ksh93-6890086.stcnv tag:cr.opensolaris.org,2009-11-01:~vkotal/nc_tet_versus_ksh93-6890086.stcnv/2009-11-01T23:31:13Z 2009-11-04T21:35:36Z Vladimir Kotal
Vladimir Kotal [vkotal's blog] posted a code review on 04 Nov 2009: nc_tet_versus_ksh93-6890086.stcnv.
Vladimir Kotal [vkotal's blog] posted a code review on 04 Nov 2009: nc_tet_versus_ksh93-6890086.stcnv.

Code Review for nc_tet_versus_ksh93-6890086.stcnv

Prepared by:vladimir kotal - Sun Microsystems - Prague Czech Republic (vk199839) on Wed Nov 4 22:35:30 CET 2009
Workspace:/workspaces/nc_tet_versus_ksh93-6890086.stcnv
Compare against: /net/grok.czech/ws-local/stcnv-clone
Summary of changes: 127 lines changed: 96 ins; 8 del; 23 mod; 1967 unchg 
6890086 ksh93 background execution behavior prevents nc test suite from running
6897053 lflag test purposes 012,014 are negative so they should be named so
6897054 nc_kill() should be more careful about which process it is killing
 0000016_rename_failed_003 tag:cr.opensolaris.org,2009-11-04:~senoltj/0000016_rename_failed_003/2009-11-04T21:29:51Z 2009-11-04T21:29:51Z Jan Senolt
Jan Senolt [senoltj] posted a code review on 04 Nov 2009: 0000016_rename_failed_003.
Jan Senolt [senoltj] posted a code review on 04 Nov 2009: 0000016_rename_failed_003.

Code Review for ext2-gate

Prepared by:senoltj@opensolaris.org on Wed Nov 4 22:24:40 CET 2009
Workspace:/export/home/honza/projects/ext2/ext2-gate (at 543743e17b3d)
Compare against: ssh://senoltj@hg.opensolaris.org/hg/ext3/ext2-gate (at f7946f0092f8)
Summary of changes: 703 lines changed: 397 ins; 119 del; 187 mod; 6813 unchg 
0000016_rename_failed_002: ext2_dirremove() and ext2_diraddname() etc were rewritten.
 pkg-on-nightly tag:cr.opensolaris.org,2009-10-30:~edp/pkg-on-nightly/2009-10-30T22:09:37Z 2009-11-04T21:00:50Z Edward Pilatowicz
Edward Pilatowicz [edp's blog] posted a code review on 04 Nov 2009: pkg-on-nightly.
Edward Pilatowicz [edp's blog] posted a code review on 04 Nov 2009: pkg-on-nightly.

Code Review for pkg-on-nightly

Prepared by:Edward Pilatowicz Edward.Pilatowicz@Sun.COM on 2009-Nov-04 13:00 -0800 PST
Workspace:/export/ws/pkg-on-nightly (at bfdf13d64d47)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at d97ba4e58fbb)
Summary of changes: 46 lines changed: 36 ins; 2 del; 8 mod; 441 unchg 
11392 'zoneadm .. install' only uses preferred publisher
 pm_12457_webinstall_proceed_button_4Nov_745pm tag:cr.opensolaris.org,2009-11-04:~jmr/pm_12457_webinstall_proceed_button_4Nov_745pm/2009-11-04T19:44:55Z 2009-11-04T19:44:55Z John Rice
John Rice [jmr's blog] posted a code review on 04 Nov 2009: pm_12457_webinstall_proceed_button_4Nov_745pm.
John Rice [jmr's blog] posted a code review on 04 Nov 2009: pm_12457_webinstall_proceed_button_4Nov_745pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on Wednesday, November 4, 2009 7:42:31 PM GMT
Workspace:/export/home/jr140578/work/ips_gate (at d97ba4e58fbb)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at d97ba4e58fbb)
Summary of changes: 76 lines changed: 28 ins; 48 del; 0 mod; 6370 unchg 
no comments found
 onnv-zmount2 tag:cr.opensolaris.org,2009-11-04:~edp/onnv-zmount2/2009-11-04T19:31:10Z 2009-11-04T19:31:10Z Edward Pilatowicz
Edward Pilatowicz [edp's blog] posted a code review on 04 Nov 2009: onnv-zmount2.
Edward Pilatowicz [edp's blog] posted a code review on 04 Nov 2009: onnv-zmount2.

Code Review for onnv-zmount2

Prepared by:Edward Pilatowicz Edward.Pilatowicz@Sun.COM on 2009-Nov-04 11:31 -0800 PST
Workspace:/export/ws/onnv-zmount2 (at 573c41d2bef3)
Compare against: ssh://anonhg@onnv.sfbay.sun.com//export/onnv-clone (at 588ee15c1f19)
Summary of changes: 1 line changed: 0 ins; 0 del; 1 mod; 7448 unchg 
6898056 native zones no longer boot: zone 'public': missing or invalid brand
 latencytop-gate tag:cr.opensolaris.org,2009-08-18:~ksadhukh/latencytop-gate/2009-08-18T21:27:13Z 2009-11-04T18:41:52Z Krishnendu Sadhukhan
Krishnendu Sadhukhan [ksadhukh] posted a code review on 04 Nov 2009: latencytop-gate.
Krishnendu Sadhukhan [ksadhukh] posted a code review on 04 Nov 2009: latencytop-gate.

Code Review for latencytop-gate

Prepared by:Krishnendu Sadhukhan - Sun Microsystems Krishnendu.Sadhukhan@Sun.COM on 2009-Nov-04 10:41 -0800 PST
Workspace:/export/ksadhukh/latencytop-gate (at 8a695b094402)
Compare against: /ws/onnv-clone (at 343d43cca32b)
Summary of changes: 4 lines changed: 3 ins; 0 del; 1 mod; 30 unchg 
6890546 SUNWlatencytop package dependency on dynamically linked libs not captured
 webrev.6825523-6767257phase1.20091104.23-24.inc tag:cr.opensolaris.org,2009-11-04:~jf_/webrev.6825523-6767257phase1.20091104.23-24.inc/2009-11-04T17:55:32Z 2009-11-04T18:05:46Z Jan Friedel
Jan Friedel [jf_] posted a code review on 04 Nov 2009: webrev.6825523-6767257phase1.20091104.23-24.inc.
Jan Friedel [jf_] posted a code review on 04 Nov 2009: webrev.6825523-6767257phase1.20091104.23-24.inc.

Code Review for webrev.6825523-6767257phase1.20091104.23-24.inc

Prepared by:Jan Friedel Jan.Friedel@Sun.COM on 2009-Nov-04 19:04 +0100 CET
Workspace:/export/data/20090327-6767257-6825523/onnv-clone (at 666ef7be7cdd)
Compare against: webrev at /export/data/www/webrevs/webrev.6825523-6767257phase1.20091022.23
Summary of changes: 328 lines changed: 48 ins; 158 del; 122 mod; 6084 unchg 
6767257 auditd(1M) configuration in SMF - phase 1 - removing the audit_startup(1M) script.
6825523 the auditd service cannot be permanently enabled/disabled from the Audit Control Rights Profile
 webrev.6825523-6767257phase1.20091104.24 tag:cr.opensolaris.org,2009-11-04:~jf_/webrev.6825523-6767257phase1.20091104.24/2009-11-04T17:54:13Z 2009-11-04T18:05:22Z Jan Friedel
Jan Friedel [jf_] posted a code review on 04 Nov 2009: webrev.6825523-6767257phase1.20091104.24.
Jan Friedel [jf_] posted a code review on 04 Nov 2009: webrev.6825523-6767257phase1.20091104.24.

Code Review for webrev.6825523-6767257phase1.20091104.24

Prepared by:Jan Friedel Jan.Friedel@Sun.COM on 2009-Nov-04 19:04 +0100 CET
Workspace:/export/data/20090327-6767257-6825523/onnv-clone (at 666ef7be7cdd)
Compare against: /net/grok.czech/ws-local/onnv-clone (at 6b60693201e3)
Summary of changes: 2118 lines changed: 1603 ins; 259 del; 256 mod; 4395 unchg 
6767257 auditd(1M) configuration in SMF - phase 1 - removing the audit_startup(1M) script.
6825523 the auditd service cannot be permanently enabled/disabled from the Audit Control Rights Profile
 lxml_name_change tag:cr.opensolaris.org,2009-11-04:~clayb/lxml_name_change/2009-11-04T17:50:03Z 2009-11-04T17:50:03Z Clay Baenziger
Clay Baenziger [clayb] posted a code review on 04 Nov 2009: lxml_name_change.
Clay Baenziger [clayb] posted a code review on 04 Nov 2009: lxml_name_change.

Code Review for slim_prototype_lxml

Prepared by:Clay Baenziger ClayB@OpenSolaris.ORG on Wednesday, November 4, 2009 10:49:45 AM MST
Workspace:/export/backup/hg_workspaces/slim_prototype_lxml (at c0767c15c9a4)
Compare against: ssh://clayb@hg.opensolaris.org/hg/caiman/slim_prototype (at 91f90638f7a5)
Summary of changes: 6 lines changed: 0 ins; 0 del; 6 mod; 72 unchg 
12468 - SUNWpython-lxml and SUNWpython26-lxml have poor NAME  DESC fields
 6562055-openssl_FIPS tag:cr.opensolaris.org,2009-09-30:~mbp/6562055-openssl_FIPS/2009-09-30T13:11:07Z 2009-11-04T16:21:16Z Mark Phalan
Mark Phalan [mbp's blog] posted a code review on 04 Nov 2009: 6562055-openssl_FIPS.
Mark Phalan [mbp's blog] posted a code review on 04 Nov 2009: 6562055-openssl_FIPS.

Code Review for 6562055-openssl_FIPS

Prepared by: (mp153739) on 2009-Nov-04 17:19 +0100 CET
Workspace:/rpool/local/ws/6562055-openssl_FIPS
Compare against: /ws/sfwnv-clone
Summary of changes: 2166 lines changed: 1935 ins; 183 del; 48 mod; 2713 unchg 
PSARC/2009/507 FIPS Capable OpenSSL
6562055 FIPS-capable version of OpenSSL
 bug-12459 tag:cr.opensolaris.org,2009-11-04:~wmsch/bug-12459/2009-11-04T11:40:33Z 2009-11-04T16:14:02Z William Schumann
William Schumann [wmsch] posted a code review on 04 Nov 2009: bug-12459.
William Schumann [wmsch] posted a code review on 04 Nov 2009: bug-12459.

Code Review for fdiskerr

Prepared by:William Schumann william.schumann@sun.com on 2009-Nov-04 09:14 -0700 MST
Workspace:/export/home/ws199450/fdiskerr (at 0d820000bb17)
Compare against: ssh://wmsch@hg.opensolaris.org/hg/caiman/slim_source (at 96271a2a70c9)
Summary of changes: 21 lines changed: 14 ins; 3 del; 4 mod; 6684 unchg 
12459 AI hangs if "Disk doesn't contain valid Solaris partition"
 pm_12485_webinstall_focus_4Nov_4pm tag:cr.opensolaris.org,2009-11-04:~jmr/pm_12485_webinstall_focus_4Nov_4pm/2009-11-04T16:04:56Z 2009-11-04T16:04:56Z John Rice
John Rice [jmr's blog] posted a code review on 04 Nov 2009: pm_12485_webinstall_focus_4Nov_4pm.
John Rice [jmr's blog] posted a code review on 04 Nov 2009: pm_12485_webinstall_focus_4Nov_4pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on Wednesday, November 4, 2009 4:02:14 PM GMT
Workspace:/export/home/jr140578/work/ips_gate (at d97ba4e58fbb)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at d97ba4e58fbb)
Summary of changes: 13 lines changed: 7 ins; 0 del; 6 mod; 2969 unchg 
no comments found
 pkg-clone tag:cr.opensolaris.org,2009-04-20:~lianep/pkg-clone/2009-04-20T23:35:08Z 2009-11-04T15:13:26Z Liane Praza
Liane Praza [lianep's blog] posted a code review on 04 Nov 2009: pkg-clone.
Liane Praza [lianep's blog] posted a code review on 04 Nov 2009: pkg-clone.

Code Review for pkg-clone

Prepared by:Liane Praza Liane.Praza@Sun.COM on 2009-Nov-04 07:10 -0800 PST
Workspace:/local/pkg/pkg-clone (at c4347650ca34)
Compare against: http://jurassic-x4600/home/comay/ws/pgate-new/ (at c4347650ca34)
Summary of changes: 1664 lines changed: 1664 ins; 0 del; 0 mod; 14970 unchg
no comments found
 12109_ui_improvements tag:cr.opensolaris.org,2009-11-04:~migi/12109_ui_improvements/2009-11-04T14:43:48Z 2009-11-04T14:43:48Z Michal Pryc
Michal Pryc [migi's blog] posted a code review on 04 Nov 2009: 12109_ui_improvements.
Michal Pryc [migi's blog] posted a code review on 04 Nov 2009: 12109_ui_improvements.

Code Review for 12109_ui_improvements

Prepared by:Michal Pryc Michal.Pryc@Sun.Com on 2009-Nov-04 14:38 +0000 GMT
Workspace:/export/home/migi/Development/12109_ui_improvements (at 6d5abe98a5b7)
Compare against: ssh://migi@hg.opensolaris.org/hg/pkg/gate (at 6d5abe98a5b7)
Summary of changes: 61 lines changed: 43 ins; 6 del; 12 mod; 5649 unchg 
no comments found
 pm_12457_12485_webinstall_proceedicon_focus_4Nov_230pm tag:cr.opensolaris.org,2009-11-04:~jmr/pm_12457_12485_webinstall_proceedicon_focus_4Nov_230pm/2009-11-04T14:29:53Z 2009-11-04T14:29:53Z John Rice
John Rice [jmr's blog] posted a code review on 04 Nov 2009: pm_12457_12485_webinstall_proceedicon_focus_4Nov_230pm.
John Rice [jmr's blog] posted a code review on 04 Nov 2009: pm_12457_12485_webinstall_proceedicon_focus_4Nov_230pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on Wed Nov 4 14:21:03 GMT 2009
Workspace:/export/home/jr140578/work/ips_gate (at 54133287c1c5)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 54133287c1c5)
Summary of changes: 243 lines changed: 142 ins; 68 del; 33 mod; 8574 unchg 
no comments found
 6897972 tag:cr.opensolaris.org,2009-11-04:~jmcp/6897972/2009-11-04T12:13:59Z 2009-11-04T12:13:59Z James C. McPherson
James C. McPherson [jmcp's blog] posted a code review on 04 Nov 2009: 6897972.
James C. McPherson [jmcp's blog] posted a code review on 04 Nov 2009: 6897972.

Code Review for 6897972

Prepared by:jmcp James.McPherson@Sun.COM on 2009-Nov-04 04:13 -0800 PST
Workspace:/space/builds/jmcp/6897972 (at a7d8c6223657)
Compare against: /export/onnv-clone/ (at b3afbf06f20d)
Summary of changes: 21 lines changed: 6 ins; 5 del; 10 mod; 56 unchg 
6897972 README.opensolaris has out of date compiler info
 pm_12000_webinstall_disabled_4Nov_1045am tag:cr.opensolaris.org,2009-11-04:~jmr/pm_12000_webinstall_disabled_4Nov_1045am/2009-11-04T10:46:45Z 2009-11-04T10:46:45Z John Rice
John Rice [jmr's blog] posted a code review on 04 Nov 2009: pm_12000_webinstall_disabled_4Nov_1045am.
John Rice [jmr's blog] posted a code review on 04 Nov 2009: pm_12000_webinstall_disabled_4Nov_1045am.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on Wed Nov 4 10:43:10 GMT 2009
Workspace:/export/home/jr140578/work/ips_gate (at 54133287c1c5)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 54133287c1c5)
Summary of changes: 232 lines changed: 132 ins; 68 del; 32 mod; 8575 unchg 
no comments found
 webrev.sync1104 tag:cr.opensolaris.org,2009-11-04:~mjnelson/webrev.sync1104/2009-11-04T07:41:30Z 2009-11-04T07:41:30Z Mark J. Nelson
Mark J. Nelson [mjnelson's blog] posted a code review on 04 Nov 2009: webrev.sync1104.
Mark J. Nelson [mjnelson's blog] posted a code review on 04 Nov 2009: webrev.sync1104.

Code Review for webrev.sync1104

Prepared by:Mark J. Nelson Mark.J.Nelson@Sun.COM on Wed Nov 4 00:37:29 MST 2009
Workspace:/brmnas/mjnelson/onnv-ips (at 43b3a0443540)
Compare against: ssh://mrliberal.central//export/ws/mjnelson/on-ips-work (at 931603178cca)
Summary of changes: 157 lines changed: 79 ins; 54 del; 24 mod; 6620 unchg 
Sync with 11-03-2009 nightly.  onnv-changeset e52b5709a64a
Sync with 11-04-2009 nightly.  onnv-changeset 30bda6952fd0
 fips-memleak-moveconf tag:cr.opensolaris.org,2009-11-04:~haimay/fips-memleak-moveconf/2009-11-04T05:35:36Z 2009-11-04T05:35:36Z Hai-May Chao
Hai-May Chao [haimay] posted a code review on 04 Nov 2009: fips-memleak-moveconf.
Hai-May Chao [haimay] posted a code review on 04 Nov 2009: fips-memleak-moveconf.

Code Review for onnv1

Prepared by:Hai-May Chao Hai-May.Chao@Sun.COM on 2009-Nov-03 21:35 -0800 PST
Workspace:/builds/haimay/onhg/onnv1 (at 30bda6952fd0)
Compare against: ssh://onnv.sfbay.sun.com//export/onnv-clone (at b0c1106a7114)
Summary of changes: 497 lines changed: 227 ins; 175 del; 95 mod; 12645 unchg 
6897371 cryptoadm needs changes in order to support fips-140 mode in local zones
6897374 Memory leaking in kernel algorithm modules and softtoken dsa with fips enabled
 webrev-12443 tag:cr.opensolaris.org,2009-11-04:~comay/webrev-12443/2009-11-04T02:11:17Z 2009-11-04T02:11:17Z David Comay
David Comay [comay's blog] posted a code review on 04 Nov 2009: webrev-12443.
David Comay [comay's blog] posted a code review on 04 Nov 2009: webrev-12443.

Code Review for pgate-new

Prepared by:David Comay (comay) on 2009-Nov-03 18:09 -0800 PST
Workspace:/home/comay/ws/pgate-new
Compare against: /home/comay/ws/pgate-base
Summary of changes: 290 lines changed: 216 ins; 56 del; 18 mod; 10561 unchg 
no comments found
 pkg-12416 tag:cr.opensolaris.org,2009-11-03:~swalker/pkg-12416/2009-11-03T23:30:31Z 2009-11-03T23:30:31Z Shawn Walker
Shawn Walker [swalker's blog] posted a code review on 03 Nov 2009: pkg-12416.
Shawn Walker [swalker's blog] posted a code review on 03 Nov 2009: pkg-12416.

Code Review for pkg-12416

Prepared by:Shawn Walker srw@sun.com on 2009-Nov-03 17:30 -0600 CST
Workspace:/export/home/swalker/devel/pkg-12416 (at 6d5abe98a5b7)
Compare against: /export/home/swalker/devel/pkg-tip (at 0ef25025d601)
Summary of changes: 75 lines changed: 23 ins; 43 del; 9 mod; 1341 unchg 
12416 race between caching of rss/atom feed and publishing "entire"
12453 importer can traceback on catalog or manifest retrieval failure
12454 importer perms check missing permissions information
 python2.6 tag:cr.opensolaris.org,2009-11-03:~clayb/python2.6/2009-11-03T23:17:33Z 2009-11-03T23:17:33Z Clay Baenziger
Clay Baenziger [clayb] posted a code review on 03 Nov 2009: python2.6.
Clay Baenziger [clayb] posted a code review on 03 Nov 2009: python2.6.

Code Review for slim_python2

Prepared by:Clay Baenziger ClayB@OpenSolaris.ORG on Tuesday, November 3, 2009 4:16:30 PM MST
Workspace:/export/backup/hg_workspaces/slim_python2 (at 8966e27e4a09)
Compare against: http://indiana-build:8081 (at 28446310c75d)
Summary of changes: 1691 lines changed: 268 ins; 224 del; 1199 mod; 1020 unchg 
ai-webserver python changes
8015 list-manifests output is hard to read
12162 Need to transition the AI webserver to use the SQLite3 module instead of PySQLite2
11607 Should remove "prototype" out of AI commands
12424 AI Websever unable to handle manifest with null IPv4 or MAC address criteria if set in at least one manifest
 bug_1436 tag:cr.opensolaris.org,2009-11-03:~mattman/bug_1436/2009-11-03T23:04:28Z 2009-11-03T23:04:28Z Matt Keenan
Matt Keenan [mattman's blog] posted a code review on 03 Nov 2009: bug_1436.
Matt Keenan [mattman's blog] posted a code review on 03 Nov 2009: bug_1436.

Code Review for slim_1436

Prepared by:Matt Keenan matt.keenan@sun.com on Tuesday, November 3, 2009 11:00:44 PM GMT
Workspace:/export/home/caiman/slim_1436 (at f95b3221edc4)
Compare against: ssh://mattman@hg.opensolaris.org/hg/caiman/slim_source (at 96271a2a70c9)
Summary of changes: 529 lines changed: 34 ins; 411 del; 84 mod; 3899 unchg 
1436 Installation does not need to ask Root Password
 7360_3 tag:cr.opensolaris.org,2009-11-03:~error404/7360_3/2009-11-03T22:35:04Z 2009-11-03T22:35:04Z John Sonnenschein
John Sonnenschein [error404's blog] posted a code review on 03 Nov 2009: 7360_3.
John Sonnenschein [error404's blog] posted a code review on 03 Nov 2009: 7360_3.

Code Review for 7360_3

Prepared by:John Sonnenschein John.Sonnenschein@Sun.COM on Tuesday, November 3, 2009 2:41:22 PM PST
Workspace:/builds/pkg5/pkg-gate (at 6e96c832bcb7)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at cd65f8545fd2)
Summary of changes: 48 lines changed: 34 ins; 1 del; 13 mod; 3654 unchg 
7360 indexing workfile size should be configurable
 pkg-5779-12431-v2 tag:cr.opensolaris.org,2009-11-03:~richb/pkg-5779-12431-v2/2009-11-03T21:50:41Z 2009-11-03T21:50:41Z Rich Burridge
Rich Burridge [richb's blog] posted a code review on 03 Nov 2009: pkg-5779-12431-v2.
Rich Burridge [richb's blog] posted a code review on 03 Nov 2009: pkg-5779-12431-v2.

Code Review for gate

Prepared by:Rich Burridge rich.burridge@sun.com on 2009-Nov-03 13:50 -0800 PST
Workspace:/export/home/richb/pkg/bugs/test-5779/gate (at d0b08a7bb65e)
Compare against: ssh://richb@hg.opensolaris.org/hg/pkg/gate (at d0b08a7bb65e)
Summary of changes: 2458 lines changed: 570 ins; 1885 del; 3 mod; 5352 unchg 
no comments found
 7360_2 tag:cr.opensolaris.org,2009-11-03:~error404/7360_2/2009-11-03T21:35:49Z 2009-11-03T21:35:49Z John Sonnenschein
John Sonnenschein [error404's blog] posted a code review on 03 Nov 2009: 7360_2.
John Sonnenschein [error404's blog] posted a code review on 03 Nov 2009: 7360_2.

Code Review for 7360_2

Prepared by:John Sonnenschein John.Sonnenschein@Sun.COM on Tuesday, November 3, 2009 1:44:20 PM PST
Workspace:/builds/pkg5/pkg-gate (at 5cd30bc41863)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at cd65f8545fd2)
Summary of changes: 49 lines changed: 34 ins; 1 del; 14 mod; 3653 unchg 
7360 indexing workfile size should be configurable
 lxml_pkg_fix tag:cr.opensolaris.org,2009-11-03:~clayb/lxml_pkg_fix/2009-11-03T21:32:50Z 2009-11-03T21:32:50Z Clay Baenziger
Clay Baenziger [clayb] posted a code review on 03 Nov 2009: lxml_pkg_fix.
Clay Baenziger [clayb] posted a code review on 03 Nov 2009: lxml_pkg_fix.

Code Review for slim_prototype

Prepared by:Clay Baenziger ClayB@OpenSolaris.ORG on Tuesday, November 3, 2009 2:32:31 PM MST
Workspace:/tmp/slim_prototype (at 91f90638f7a5)
Compare against: ssh://clayb@hg.opensolaris.org/hg/caiman/slim_prototype (at 3a812a61e2a8)
Summary of changes: 2 lines changed: 0 ins; 0 del; 2 mod; 76 unchg 
Need to keep SUNW_PKGVERS="1.0" for proper integration
 onnv-clone tag:cr.opensolaris.org,2009-07-29:~ksadhukh/onnv-clone/2009-07-29T00:44:10Z 2009-11-03T19:51:44Z Krishnendu Sadhukhan
Krishnendu Sadhukhan [ksadhukh] posted a code review on 03 Nov 2009: onnv-clone.
Krishnendu Sadhukhan [ksadhukh] posted a code review on 03 Nov 2009: onnv-clone.

Code Review for onnv-clone

Prepared by:Krishnendu Sadhukhan - Sun Microsystems Krishnendu.Sadhukhan@Sun.COM on 2009-Nov-03 11:51 -0800 PST
Workspace:/export/ksadhukh/onnv-clone (at 89bfb2b10e30)
Compare against: /ws/onnv-clone (at 89bfb2b10e30)
Summary of changes: 136 lines changed: 136 ins; 0 del; 0 mod; 5598 unchg 
no comments found
 6896058 tag:cr.opensolaris.org,2009-11-03:~kupfer/6896058/2009-11-03T18:45:23Z 2009-11-03T18:45:23Z Mike Kupfer
Mike Kupfer [kupfer's blog] posted a code review on 03 Nov 2009: 6896058.
Mike Kupfer [kupfer's blog] posted a code review on 03 Nov 2009: 6896058.

Code Review for 6896058

Prepared by:Mike Kupfer Mike.Kupfer@Sun.COM on 2009-Nov-03 10:45 -0800 PST
Workspace:/net/tonic-gate/builds/kupfer/6896058 (at 42a60fe432db)
Compare against: ssh://anonhg@onnv//export/onnv-clone (at 270624bd70f1)
Summary of changes: 57 lines changed: 41 ins; 4 del; 12 mod; 152 unchg 
Clean up README.opensolaris.tmpl. Handle HTML character entities.
Use [] in begin/end tags.
Fix the error message for when there's no end tag.
README.opensolaris.tmpl details:
- remove #ident
- use hub.os.o URLs
6896058 transition to xwiki broke Tonic build (nightly -O, mkreadme_osol)
 pm_12000_webinstall_disabled_3Nov_333pm tag:cr.opensolaris.org,2009-11-03:~jmr/pm_12000_webinstall_disabled_3Nov_333pm/2009-11-03T15:35:47Z 2009-11-03T15:35:47Z John Rice
John Rice [jmr's blog] posted a code review on 03 Nov 2009: pm_12000_webinstall_disabled_3Nov_333pm.
John Rice [jmr's blog] posted a code review on 03 Nov 2009: pm_12000_webinstall_disabled_3Nov_333pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on Tuesday, November 3, 2009 3:33:34 PM GMT
Workspace:/export/home/jr140578/work/ips_gate (at 54133287c1c5)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 54133287c1c5)
Summary of changes: 157 lines changed: 106 ins; 20 del; 31 mod; 8624 unchg 
no comments found
 pm_12000_webinstall_disabled_3Nov_220pm tag:cr.opensolaris.org,2009-11-03:~jmr/pm_12000_webinstall_disabled_3Nov_220pm/2009-11-03T14:23:45Z 2009-11-03T14:23:45Z John Rice
John Rice [jmr's blog] posted a code review on 03 Nov 2009: pm_12000_webinstall_disabled_3Nov_220pm.
John Rice [jmr's blog] posted a code review on 03 Nov 2009: pm_12000_webinstall_disabled_3Nov_220pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on Tuesday, November 3, 2009 2:21:07 PM GMT
Workspace:/export/home/jr140578/work/ips_gate (at 54133287c1c5)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 54133287c1c5)
Summary of changes: 128 lines changed: 92 ins; 12 del; 24 mod; 2972 unchg 
no comments found
 ips-12356-v1 tag:cr.opensolaris.org,2009-11-03:~padraig/ips-12356-v1/2009-11-03T14:03:52Z 2009-11-03T14:03:52Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 03 Nov 2009: ips-12356-v1.
Padraig O\'Briain [padraig] posted a code review on 03 Nov 2009: ips-12356-v1.

Code Review for 12356_gate

Prepared by:Padraig O'Briain padraig.obriain@sun.com on Tuesday, November 3, 2009 1:51:06 PM GMT
Workspace:/export/home/padraig/12356_gate (at d0b08a7bb65e)
Compare against: /export/home/padraig/gate (at d0b08a7bb65e)
Summary of changes: 54 lines changed: 38 ins; 2 del; 14 mod; 4981 unchg 
no comments found
 ips-12346-v2 tag:cr.opensolaris.org,2009-11-03:~padraig/ips-12346-v2/2009-11-03T09:29:01Z 2009-11-03T09:29:01Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 03 Nov 2009: ips-12346-v2.
Padraig O\'Briain [padraig] posted a code review on 03 Nov 2009: ips-12346-v2.

Code Review for 12346_clone

Prepared by:Padraig O'Briain padraig.obriain@sun.com on Tuesday, November 3, 2009 9:10:26 AM GMT
Workspace:/export/home/padraig/12346_clone (at 54133287c1c5)
Compare against: /export/home/padraig/gate (at 54133287c1c5)
Summary of changes: 125 lines changed: 109 ins; 13 del; 3 mod; 10951 unchg 
no comments found
 ips-12426-v1 tag:cr.opensolaris.org,2009-11-03:~padraig/ips-12426-v1/2009-11-03T08:51:52Z 2009-11-03T08:51:52Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 03 Nov 2009: ips-12426-v1.
Padraig O\'Briain [padraig] posted a code review on 03 Nov 2009: ips-12426-v1.

Code Review for 12426_clone

Prepared by:Padraig O'Briain padraig.obriain@sun.com on Tuesday, November 3, 2009 8:38:58 AM GMT
Workspace:/export/home/padraig/12426_clone (at fdf40c8c6765)
Compare against: /export/home/padraig/gate (at fdf40c8c6765)
Summary of changes: 3 lines changed: 1 ins; 0 del; 2 mod; 4845 unchg 
no comments found
 6857014 tag:cr.opensolaris.org,2009-11-03:~sunandam/6857014/2009-11-03T08:36:35Z 2009-11-03T08:36:35Z Sunanda Menon
Sunanda Menon [sunandam] posted a code review on 03 Nov 2009: 6857014.
Sunanda Menon [sunandam] posted a code review on 03 Nov 2009: 6857014.

Code Review for 6857014

Prepared by:Sunanda Menon (sm156471) on 2009-Nov-03 00:36 -0800 PST
Workspace:/export/home/sunanda/6857014
Compare against: /ws/sfwnv-clone
Summary of changes: 332892 lines changed: 331725 ins; 1012 del; 155 mod; 101128 unchg 
6857014 Update MySQL in Nevada to version 5.1.37
 bug-8140 tag:cr.opensolaris.org,2009-08-28:~dambi/bug-8140/2009-08-28T07:45:15Z 2009-11-03T07:25:12Z Jan Damborsky
Jan Damborsky [dambi] posted a code review on 03 Nov 2009: bug-8140.
Jan Damborsky [dambi] posted a code review on 03 Nov 2009: bug-8140.

Code Review for os-install-bug-8140

Prepared by:Jan Damborsky jan.damborsky@sun.com on Tuesday, November 3, 2009 8:25:12 AM CET
Workspace:/export/home/dambi/ws/os-install-bug-8140 (at 9f362ceb0eb2)
Compare against: ssh://anon@hg.opensolaris.org/hg/caiman/slim_source (at 96271a2a70c9)
Summary of changes: 23 lines changed: 17 ins; 0 del; 6 mod; 1403 unchg 
7966 setting 'livemode=text' is no-op for AI, should be removed from installadm(1M)
8140 Fix for 6440 applied to x86 AI images would reduce x86 AI memory consumption
 FMA_Magny-Cours_webrev tag:cr.opensolaris.org,2009-11-03:~srihari/FMA_Magny-Cours_webrev/2009-11-03T07:03:59Z 2009-11-03T07:03:59Z Srihari Venkatesan
Srihari Venkatesan [srihari] posted a code review on 03 Nov 2009: FMA_Magny-Cours_webrev.
Srihari Venkatesan [srihari] posted a code review on 03 Nov 2009: FMA_Magny-Cours_webrev.

Code Review for onnv-clone

Prepared by:Srihari Venkatesan Srihari.Venkatesan@Sun.COM on 2009-Nov-02 22:43 -0800 PST
Workspace:/net/nwkpen-cr1-ha1-nfs.sfbay/export/ds01/d537/workspace/sv151587/rfes/mc3/onnv-clone (at f41ec9027c83)
Compare against: ssh://onnv.sfbay.sun.com//export/onnv-clone (at 2e39e3d31413)
Summary of changes: 626 lines changed: 371 ins; 131 del; 124 mod; 18259 unchg 
6843035 Need support for Magny-Cours processors
6860401 FMA CPU Topology  Memory Topology needs to support Magny Cours(Multi chip Module)
Portions contributed by Boris.Ostrovsky@amd.com and Hans.Rosenfeld@amd.com
 webrev_qlogic_qlge_10 tag:cr.opensolaris.org,2009-11-03:~ss118570/webrev_qlogic_qlge_10/2009-11-03T05:01:04Z 2009-11-03T05:01:04Z Sukumar Swaminathan
Sukumar Swaminathan [ss118570] posted a code review on 03 Nov 2009: webrev_qlogic_qlge_10.
Sukumar Swaminathan [ss118570] posted a code review on 03 Nov 2009: webrev_qlogic_qlge_10.

Code Review for qlogic_qlge

Prepared by:Sukumar Swaminathan Sukumar.Swaminathan@Sun.COM on 2009-Nov-02 20:58 -0800 PST
Workspace:/builds/ss118570/qlogic_qlge (at 7a46292400fa)
Compare against: ssh://anonhg@onnv.sfbay.sun.com//export/onnv-clone (at e52b5709a64a)
Summary of changes: 17771 lines changed: 17592 ins; 172 del; 7 mod; 6040 unchg 
PSARC/2009/525 qlge - QLogic PCIe converged NIC driver
6871527 FCoE, qlge driver - Add NIC side of support for new Qlogic FCoE adapter, Europa
 pkg-list-api tag:cr.opensolaris.org,2009-11-03:~swalker/pkg-list-api/2009-11-03T04:47:47Z 2009-11-03T04:47:47Z Shawn Walker
Shawn Walker [swalker's blog] posted a code review on 03 Nov 2009: pkg-list-api.
Shawn Walker [swalker's blog] posted a code review on 03 Nov 2009: pkg-list-api.

Code Review for pkg-list-api

Prepared by:Shawn Walker srw@sun.com on Monday, November 2, 2009 10:47:46 PM CST
Workspace:/export/home/swalker/devel/pkg-list-api (at 60d87041e643)
Compare against: /export/home/swalker/devel/pkg-cat-perf/ (at c047b7eff589)
Summary of changes: 1594 lines changed: 1223 ins; 200 del; 171 mod; 18474 unchg 
5872 List APIs required
 pkg-5779-v1 tag:cr.opensolaris.org,2009-11-02:~richb/pkg-5779-v1/2009-11-02T23:39:12Z 2009-11-02T23:39:12Z Rich Burridge
Rich Burridge [richb's blog] posted a code review on 02 Nov 2009: pkg-5779-v1.
Rich Burridge [richb's blog] posted a code review on 02 Nov 2009: pkg-5779-v1.

Code Review for gate

Prepared by:Rich Burridge rich.burridge@sun.com on 2009-Nov-02 15:38 -0800 PST
Workspace:/export/home/richb/pkg/bugs/test-5779/gate (at fdf40c8c6765)
Compare against: ssh://richb@hg.opensolaris.org/hg/pkg/gate (at fdf40c8c6765)
Summary of changes: 1884 lines changed: 283 ins; 1601 del; 0 mod; 686 unchg 
no comments found
 pkg-8123-v3 tag:cr.opensolaris.org,2009-11-02:~richb/pkg-8123-v3/2009-11-02T23:17:48Z 2009-11-02T23:17:48Z Rich Burridge
Rich Burridge [richb's blog] posted a code review on 02 Nov 2009: pkg-8123-v3.
Rich Burridge [richb's blog] posted a code review on 02 Nov 2009: pkg-8123-v3.

Code Review for gate

Prepared by:Rich Burridge rich.burridge@sun.com on 2009-Nov-02 15:17 -0800 PST
Workspace:/export/home/richb/pkg/bugs/8123/gate (at fdf40c8c6765)
Compare against: ssh://richb@hg.opensolaris.org/hg/pkg/gate (at fdf40c8c6765)
Summary of changes: 523 lines changed: 315 ins; 6 del; 202 mod; 664 unchg 
no comments found
 onnv-clone tag:cr.opensolaris.org,2009-11-02:~kucharsk/onnv-clone/2009-11-02T23:15:57Z 2009-11-02T23:15:57Z William Kucharski
William Kucharski [kucharsk] posted a code review on 02 Nov 2009: onnv-clone.
William Kucharski [kucharsk] posted a code review on 02 Nov 2009: onnv-clone.

Code Review for onnv-clone

Prepared by:William Kucharski William.Kucharski@Sun.COM on 2009-Nov-02 16:15 -0700 MST
Workspace:/export/kucharsk/hgtrees/vmware/onnv-clone (at 3372bffccf87)
Compare against: /ws/onnv-clone (at ac35db8a7412)
Summary of changes: 72 lines changed: 72 ins; 0 del; 0 mod; 3401 unchg 
Try INIT-SIPI-SIPI for fast reboot
 disavx.org tag:cr.opensolaris.org,2009-11-02:~kuriakos/disavx.org/2009-11-02T22:57:53Z 2009-11-02T22:57:53Z Kuriakose Kuruvilla
Kuriakose Kuruvilla [kuriakos] posted a code review on 02 Nov 2009: disavx.org.
Kuriakose Kuruvilla [kuriakos] posted a code review on 02 Nov 2009: disavx.org.

Code Review for disavx

Prepared by:Kuriakose Kuruvilla Kuriakose.Kuruvilla@Sun.COM on 2009-Oct-28 09:52 -0700 PDT
Workspace:/export/kk208521/disavx (at 007ca67ca400)
Compare against: ssh://anonhg@onnv.sfbay.sun.com//export/onnv-clone (at 007ca67ca400)
Summary of changes: 53 lines changed: 42 ins; 5 del; 6 mod; 3701 unchg 
no comments found
 11679 tag:cr.opensolaris.org,2009-11-02:~evanl/11679/2009-11-02T20:14:08Z 2009-11-02T21:51:29Z Evan J. Layton
Evan J. Layton [evanl] posted a code review on 02 Nov 2009: 11679.
Evan J. Layton [evanl] posted a code review on 02 Nov 2009: 11679.

Code Review for slim_Py2.6

Prepared by:Evan Layton Evan.Layton@Sun.COM on 2009-Nov-02 15:02 -0700 MST
Workspace:/brmnas/evanl/slim_Py2.6 (at 40db9c21dda7)
Compare against: http://indiana-build:8081 (at d8ec8a7eed3a)
Summary of changes: 1948 lines changed: 634 ins; 503 del; 811 mod; 3958 unchg 
11679 beadm should be updated to work with Python version 2.6
11680 The libbe Python bridge needs to be compiled against libpython2.6
 slim_2.6 tag:cr.opensolaris.org,2009-10-27:~jeanm/slim_2.6/2009-10-27T16:37:17Z 2009-11-02T21:33:50Z Jean E. McCormack
Jean E. McCormack [jeanm] posted a code review on 02 Nov 2009: slim_2.6.
Jean E. McCormack [jeanm] posted a code review on 02 Nov 2009: slim_2.6.

Code Review for slim_2.6

Prepared by:Jean McCormack Jean.McCormack@Sun.COM on 2009-Nov-02 14:45 -0700 MST
Workspace:/brmnas/jeanm/slim_2.6 (at d8ec8a7eed3a)
Compare against: http://indiana-build:8081 (at d8ec8a7eed3a)
Summary of changes: 107 lines changed: 15 ins; 0 del; 92 mod; 1615 unchg 
no comments found
 b128.2/webrev tag:cr.opensolaris.org,2009-11-02:~sn123202/b128.2/webrev/2009-11-02T15:24:05Z 2009-11-02T21:02:35Z Sriram Natarajan
Sriram Natarajan [sn123202] posted a code review on 02 Nov 2009: b128.2/webrev.
Sriram Natarajan [sn123202] posted a code review on 02 Nov 2009: b128.2/webrev.

Code Review for php-gate

Prepared by:Sriram Natarajan (sn123202) on Mon Nov 2 13:02:28 PST 2009
Workspace:/builds/sn123202/php-gate
Compare against: /ws/sfwnv-gate
Summary of changes: 6438 lines changed: 5442 ins; 983 del; 13 mod; 2149 unchg 
6877619 remove redundant PHP DTrace extension
6893914 split 3rd party extensions into its own packages
 webrev.sync1101 tag:cr.opensolaris.org,2009-11-02:~mjnelson/webrev.sync1101/2009-11-02T19:31:02Z 2009-11-02T19:31:02Z Mark J. Nelson
Mark J. Nelson [mjnelson's blog] posted a code review on 02 Nov 2009: webrev.sync1101.
Mark J. Nelson [mjnelson's blog] posted a code review on 02 Nov 2009: webrev.sync1101.

Code Review for webrev.sync1101

Prepared by:Mark J. Nelson Mark.J.Nelson@Sun.COM on Monday, November 2, 2009 12:29:09 PM MST
Workspace:/export/ws/mjnelson/on-ips-work (at 931603178cca)
Compare against: ssh://anon@hg.opensolaris.org//hg/pkg/on_ips (at 765b7802243c)
Summary of changes: 1 line changed: 0 ins; 0 del; 1 mod; 14 unchg 
Sync with 11-01-2009 nightly.  onnv-changeset e2081f502306
 pm_12000_webinstall_disabled_2Nov_520pm tag:cr.opensolaris.org,2009-11-02:~jmr/pm_12000_webinstall_disabled_2Nov_520pm/2009-11-02T17:22:51Z 2009-11-02T17:22:51Z John Rice
John Rice [jmr's blog] posted a code review on 02 Nov 2009: pm_12000_webinstall_disabled_2Nov_520pm.
John Rice [jmr's blog] posted a code review on 02 Nov 2009: pm_12000_webinstall_disabled_2Nov_520pm.

Code Review for ips_gate

Prepared by:John Rice john.rice@sun.com on Mon Nov 2 17:20:34 GMT 2009
Workspace:/export/home/jr140578/work/ips_gate (at 54133287c1c5)
Compare against: ssh://anon@hg.opensolaris.org/hg/pkg/gate (at 54133287c1c5)
Summary of changes: 124 lines changed: 90 ins; 12 del; 22 mod; 2974 unchg 
no comments found
 bug_6897242 tag:cr.opensolaris.org,2009-11-02:~fleyta/bug_6897242/2009-11-02T16:51:59Z 2009-11-02T16:51:59Z Olga Kryzhanovska
Olga Kryzhanovska [fleyta] posted a code review on 02 Nov 2009: bug_6897242.
Olga Kryzhanovska [fleyta] posted a code review on 02 Nov 2009: bug_6897242.

Code Review for onnv-gate.hg

Prepared by:Roland Mainz roland.mainz@nrubsig.org, Olga Kryzhanovska olga.kryzhanovska@gmail.com on Mon Nov 2 17:51:59 CET 2009
Workspace:/home/fleyta/ksh93/on_build2/onnv-gate.hg (at 5b7f6f710599)
Compare against: http://hg.genunix.org/onnv-gate.hg (at 881ceecbca49)
Summary of changes: 13 lines changed: 0 ins; 8 del; 5 mod; 450 unchg 
6897242 ksh93 makefile cleanup required
 pm_12000_webinstall_disabled_2Nov_450pm tag:cr.opensolaris.org,2009-11-02:~jmr/pm_12000_webinstall_disabled_2Nov_450pm/2009-11-02T16:51:38Z 2009-11-02T16:51:38Z John Rice
John Rice [jmr's blog] posted a code review on 02 Nov 2009: pm_12000_webinstall_disabled_2Nov_450pm.
John Rice [jmr's blog] posted a code review on 02 Nov 2009: pm_12000_webinstall_disabled_2Nov_450pm.

Code Review for ips_12000_webinstall_disabled

Prepared by:John Rice john.rice@sun.com on Mon Nov 2 16:49:40 GMT 2009
Workspace:/export/home/jr140578/work/ips_12000_webinstall_disabled (at 54133287c1c5)
Compare against: /export/home/jr140578/work/ips_gate (at 54133287c1c5)
Summary of changes: 123 lines changed: 90 ins; 12 del; 21 mod; 2975 unchg 
no comments found
 ips-12348-v2 tag:cr.opensolaris.org,2009-11-02:~padraig/ips-12348-v2/2009-11-02T11:21:59Z 2009-11-02T11:21:59Z Padraig O\'Briain
Padraig O\'Briain [padraig] posted a code review on 02 Nov 2009: ips-12348-v2.
Padraig O\'Briain [padraig] posted a code review on 02 Nov 2009: ips-12348-v2.

Code Review for 12348_clone

Prepared by:Padraig O'Briain padraig.obriain@sun.com on Monday, November 2, 2009 11:18:51 AM GMT
Workspace:/export/home/padraig/12348_clone (at 54133287c1c5)
Compare against: /export/home/padraig/gate (at 54133287c1c5)
Summary of changes: 3 lines changed: 3 ins; 0 del; 0 mod; 4847 unchg 
no comments found