OpenSolaris

cr.opensolaris.org

This is a site which enables OpenSolaris developers to post code reviews. This was recently identified as a priority by the OpenSolaris community in the Community Priorities poll:

#3. Deploy a public code review facility on opensolaris.org.

Send feedback to website-discuss@opensolaris.org

Account Setup

• An opensolaris.org account
• A valid SSH key on file (for more on SSH keys and OpenSolaris, see opensolaris.org SSH Key Help).

• Your account's contents are visible at http://cr.opensolaris.org/~username.
• Accounts have scp, sftp, and rsync access only. Use scp -r or rsync -avz to upload files. Each account has a .trash folder; use sftp to move directories you want to trash to the .trash folder; a cron job will come along once an hour to nuke them (n.b. this is a workaround for the nuisance that sftp doesn't implement a recursive delete).
• No shell login is permitted.
• Account meta-data such as your SSH public key are backed up, but your webrevs are not. In the event that we have data loss, you will need to re-upload your webrevs; we'll try to keep you informed of any problems. To stay informed, sign up for XXX-YYY@opensolaris.org.

FAQ

I can't seem to contact cr.opensolaris.org or poll.opensolaris.org using ssh?

If you work for Sun, you'll need to either configure a SOCKS proxy for SSH or find a machine with so-called "Direct-Internet-Access." Contact your local IT person or someone who is knowledgeable in this area. The cr.opensolaris.org maintainers probably don't have the cycles to help you with this.

I still can't seem to contact cr.opensolaris.org, but I *can* connect to poll.opensolaris.org using ssh?

Something might be wrong with the site. Please send mail to website-discuss@opensolaris.org.

SSH connects, but I get prompted for a password, and not an SSH key passphrase...

For one reason or another, you might not have an account. Check to see if http://cr.opensolaris.org/~username exists. If not, see the requirements list in the "Account Setup" section above.

Usage Rules / Terms of Use

• Materials posted must be related to codereviews of OpenSolaris-related material; it is acceptable to post related meta-data, such as bug reports, provided you have the appropriate authority to do so.
• Personal home pages, images, pr0n or other materials are NOT permitted.
• Contributors internal to Sun should remember to use "webrev -O". This ensures that links to bug reports, etc. are correct.
• Old codereviews may be automatically deleted to make room if disk space becomes limited.
• Materials must not be considered confidential or private to whatever company or organization you work for. google and the whole world will be able to see what you post.
• A small javascript tracker will be auto-appended to all html pages served by the site. This is at present the google analytics tracker. Access to the analytics is available by request.
• The site authors reserve the right to publish a master list of codereviews present on cr.opensolaris.org. An opt-out facility will be provided. At this time, none of this has been implemented.
• Additional Terms of Service may apply: see the "Terms of Use" link at the bottom of this page.

Example

Posting a review

Let's say you have a webrev in a directory called webrev. But your wad is called something like "cleanup", and you want to post the review as such.

$ scp -r webrev username@cr.opensolaris.org:cleanup
Enter passphrase for key '/home/me/.ssh/id_rsa':
Makefile.lint.wdiff. 100% |*****************************| 19326       00:00
synonyms.h.udiff.htm 100% |*****************************|  2497       00:00
synonyms.h.cdiff.htm 100% |*****************************|  3620       00:00
...

Or, using rsync (which is much faster):

$ cd webrev
$ rsync -avz . username@cr.opensolaris.org:cleanup
Enter passphrase for key '/home/me/.ssh/id_rsa':
./
TotalChangedLines
ancnav.html
ancnav.js
...

rsync has the speed advantage and allows you to easily upload over and over.

Deleting a review

$ echo "rename cleanup .trash/cleanup" | sftp username@cr.opensolaris.org
Enter passphrase for key '/home/me/.ssh/id_rsa':